All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christopher Lameter <cl@linux.com>
To: Marco Elver <elver@google.com>
Cc: akpm@linux-foundation.org, glider@google.com, hpa@zytor.com,
	paulmck@kernel.org, andreyknvl@google.com,
	aryabinin@virtuozzo.com, luto@kernel.org, bp@alien8.de,
	catalin.marinas@arm.com, dave.hansen@linux.intel.com,
	rientjes@google.com, dvyukov@google.com, edumazet@google.com,
	gregkh@linuxfoundation.org, mingo@redhat.com, jannh@google.com,
	Jonathan.Cameron@huawei.com, corbet@lwn.net,
	iamjoonsoo.kim@lge.com, keescook@chromium.org,
	mark.rutland@arm.com, penberg@kernel.org, peterz@infradead.org,
	cai@lca.pw, tglx@linutronix.de, vbabka@suse.cz, will@kernel.org,
	x86@kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
	linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 05/10] mm, kfence: insert KFENCE hooks for SLUB
Date: Thu, 17 Sep 2020 09:40:09 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2009170938030.1492@www.lameter.com> (raw)
In-Reply-To: <20200915132046.3332537-6-elver@google.com>

On Tue, 15 Sep 2020, Marco Elver wrote:

>  void *kmem_cache_alloc(struct kmem_cache *s, gfp_t gfpflags)
>  {
> -	void *ret = slab_alloc(s, gfpflags, _RET_IP_);
> +	void *ret = slab_alloc(s, gfpflags, _RET_IP_, s->object_size);

The additional size parameter is a part of a struct kmem_cache that is
already passed to the function. Why does the parameter list need to be
expanded?


WARNING: multiple messages have this Message-ID (diff)
From: Christopher Lameter <cl@linux.com>
To: Marco Elver <elver@google.com>
Cc: mark.rutland@arm.com, linux-doc@vger.kernel.org,
	peterz@infradead.org, catalin.marinas@arm.com,
	dave.hansen@linux.intel.com, linux-mm@kvack.org,
	edumazet@google.com, glider@google.com, hpa@zytor.com,
	will@kernel.org, corbet@lwn.net, x86@kernel.org,
	kasan-dev@googlegroups.com, mingo@redhat.com, vbabka@suse.cz,
	rientjes@google.com, aryabinin@virtuozzo.com,
	keescook@chromium.org, paulmck@kernel.org, jannh@google.com,
	andreyknvl@google.com, bp@alien8.de, luto@kernel.org,
	Jonathan.Cameron@huawei.com, tglx@linutronix.de,
	iamjoonsoo.kim@lge.com, dvyukov@google.com,
	linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
	linux-kernel@vger.kernel.org, penberg@kernel.org, cai@lca.pw,
	akpm@linux-foundation.org
Subject: Re: [PATCH v2 05/10] mm, kfence: insert KFENCE hooks for SLUB
Date: Thu, 17 Sep 2020 09:40:09 +0000 (UTC)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2009170938030.1492@www.lameter.com> (raw)
In-Reply-To: <20200915132046.3332537-6-elver@google.com>

On Tue, 15 Sep 2020, Marco Elver wrote:

>  void *kmem_cache_alloc(struct kmem_cache *s, gfp_t gfpflags)
>  {
> -	void *ret = slab_alloc(s, gfpflags, _RET_IP_);
> +	void *ret = slab_alloc(s, gfpflags, _RET_IP_, s->object_size);

The additional size parameter is a part of a struct kmem_cache that is
already passed to the function. Why does the parameter list need to be
expanded?


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-17  9:48 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 13:20 [PATCH v2 00/10] KFENCE: A low-overhead sampling-based memory safety error detector Marco Elver
2020-09-15 13:20 ` Marco Elver
2020-09-15 13:20 ` Marco Elver
2020-09-15 13:20 ` [PATCH v2 01/10] mm: add Kernel Electric-Fence infrastructure Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-17 13:26   ` Hillf Danton
2020-09-17 13:26     ` Hillf Danton
2020-09-17 13:36     ` Marco Elver
2020-09-17 13:36       ` Marco Elver
2020-09-17 23:45       ` Hillf Danton
2020-09-17 23:45         ` Hillf Danton
2020-09-15 13:20 ` [PATCH v2 02/10] x86, kfence: enable KFENCE for x86 Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20 ` [PATCH v2 03/10] arm64, kfence: enable KFENCE for ARM64 Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20 ` [PATCH v2 04/10] mm, kfence: insert KFENCE hooks for SLAB Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-17  9:37   ` Christopher Lameter
2020-09-17  9:37     ` Christopher Lameter
2020-09-17  9:37     ` Christopher Lameter
2020-09-17  9:47     ` Alexander Potapenko
2020-09-17  9:47       ` Alexander Potapenko
2020-09-17  9:47       ` Alexander Potapenko
2020-09-15 13:20 ` [PATCH v2 05/10] mm, kfence: insert KFENCE hooks for SLUB Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-17  9:40   ` Christopher Lameter [this message]
2020-09-17  9:40     ` Christopher Lameter
2020-09-17  9:40     ` Christopher Lameter
2020-09-17  9:51     ` Alexander Potapenko
2020-09-17  9:51       ` Alexander Potapenko
2020-09-17  9:51       ` Alexander Potapenko
2020-09-15 13:20 ` [PATCH v2 06/10] kfence, kasan: make KFENCE compatible with KASAN Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20 ` [PATCH v2 07/10] kfence, kmemleak: make KFENCE compatible with KMEMLEAK Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20 ` [PATCH v2 08/10] kfence, lockdep: make KFENCE compatible with lockdep Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20 ` [PATCH v2 09/10] kfence, Documentation: add KFENCE documentation Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20 ` [PATCH v2 10/10] kfence: add test suite Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-15 13:20   ` Marco Elver
2020-09-16  5:13   ` kernel test robot
2020-09-15 13:49 ` [PATCH v2 00/10] KFENCE: A low-overhead sampling-based memory safety error detector Dmitry Vyukov
2020-09-15 13:49   ` Dmitry Vyukov
2020-09-15 13:49   ` Dmitry Vyukov
2020-09-18 11:17 ` Qian Cai
2020-09-18 11:17   ` Qian Cai
2020-09-18 11:17   ` Qian Cai
2020-09-18 11:59   ` Marco Elver
2020-09-18 11:59     ` Marco Elver
2020-09-18 11:59     ` Marco Elver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2009170938030.1492@www.lameter.com \
    --to=cl@linux.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=aryabinin@virtuozzo.com \
    --cc=bp@alien8.de \
    --cc=cai@lca.pw \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=dvyukov@google.com \
    --cc=edumazet@google.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jannh@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rientjes@google.com \
    --cc=tglx@linutronix.de \
    --cc=vbabka@suse.cz \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.