All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: alsa-devel@alsa-project.org,
	Harsha Priya <harshapriya.n@intel.com>,
	intel-gfx@lists.freedesktop.org, stable@vger.kernel.org,
	Emmanuel Jillela <emmanuel.jillela@intel.com>,
	Takashi Iwai <tiwai@suse.de>
Subject: Re: [Intel-gfx] [PATCH] ALSA: hda/hdmi: Disable silent stream on GLK
Date: Wed, 22 Dec 2021 18:57:43 +0200 (EET)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2112221851510.1661468@eliteleevi.tm.intel.com> (raw)
In-Reply-To: <20211222145350.24342-1-ville.syrjala@linux.intel.com>

Hi,

On Wed, 22 Dec 2021, Ville Syrjala wrote:

> The silent stream stuff recurses back into i915 audio
> component .get_power() from the .pin_eld_notify() hook.
> On GLK this will deadlock as i915 may already be holding
> the relevant modeset locks during .pin_eld_notify() and
> the GLK audio vs. CDCLK workaround will try to grab the
> same locks from .get_power().
>
> Until someone comes up with a better fix just disable the
> silent stream support on GLK.

decoupling the call to get_power() is a non-trivial change
(especially as it's done from generic hda_codec.c code),
so I'd say let's go with this patch for GLK:

Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>

Br, Kai

WARNING: multiple messages have this Message-ID (diff)
From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: alsa-devel@alsa-project.org, intel-gfx@lists.freedesktop.org,
	stable@vger.kernel.org, Harsha Priya <harshapriya.n@intel.com>,
	Emmanuel Jillela <emmanuel.jillela@intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ALSA: hda/hdmi: Disable silent stream on GLK
Date: Wed, 22 Dec 2021 18:57:43 +0200 (EET)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2112221851510.1661468@eliteleevi.tm.intel.com> (raw)
In-Reply-To: <20211222145350.24342-1-ville.syrjala@linux.intel.com>

Hi,

On Wed, 22 Dec 2021, Ville Syrjala wrote:

> The silent stream stuff recurses back into i915 audio
> component .get_power() from the .pin_eld_notify() hook.
> On GLK this will deadlock as i915 may already be holding
> the relevant modeset locks during .pin_eld_notify() and
> the GLK audio vs. CDCLK workaround will try to grab the
> same locks from .get_power().
>
> Until someone comes up with a better fix just disable the
> silent stream support on GLK.

decoupling the call to get_power() is a non-trivial change
(especially as it's done from generic hda_codec.c code),
so I'd say let's go with this patch for GLK:

Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>

Br, Kai

WARNING: multiple messages have this Message-ID (diff)
From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: alsa-devel@alsa-project.org,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Harsha Priya <harshapriya.n@intel.com>,
	intel-gfx@lists.freedesktop.org, stable@vger.kernel.org,
	Emmanuel Jillela <emmanuel.jillela@intel.com>,
	Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH] ALSA: hda/hdmi: Disable silent stream on GLK
Date: Wed, 22 Dec 2021 18:57:43 +0200 (EET)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2112221851510.1661468@eliteleevi.tm.intel.com> (raw)
In-Reply-To: <20211222145350.24342-1-ville.syrjala@linux.intel.com>

Hi,

On Wed, 22 Dec 2021, Ville Syrjala wrote:

> The silent stream stuff recurses back into i915 audio
> component .get_power() from the .pin_eld_notify() hook.
> On GLK this will deadlock as i915 may already be holding
> the relevant modeset locks during .pin_eld_notify() and
> the GLK audio vs. CDCLK workaround will try to grab the
> same locks from .get_power().
>
> Until someone comes up with a better fix just disable the
> silent stream support on GLK.

decoupling the call to get_power() is a non-trivial change
(especially as it's done from generic hda_codec.c code),
so I'd say let's go with this patch for GLK:

Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>

Br, Kai

  parent reply	other threads:[~2021-12-22 17:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22 14:53 [PATCH] ALSA: hda/hdmi: Disable silent stream on GLK Ville Syrjala
2021-12-22 14:53 ` Ville Syrjala
2021-12-22 14:53 ` [Intel-gfx] " Ville Syrjala
2021-12-22 15:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-12-22 16:57 ` Kai Vehmanen [this message]
2021-12-22 16:57   ` [PATCH] " Kai Vehmanen
2021-12-22 16:57   ` Kai Vehmanen
2021-12-22 17:37 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2021-12-25  8:17 ` [PATCH] " Takashi Iwai
2021-12-25  8:17   ` Takashi Iwai
2021-12-25  8:17   ` [Intel-gfx] " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.22.394.2112221851510.1661468@eliteleevi.tm.intel.com \
    --to=kai.vehmanen@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=emmanuel.jillela@intel.com \
    --cc=harshapriya.n@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.