From: Len Brown <lenb@kernel.org>
To: "Moore, Robert" <robert.moore@intel.com>
Cc: Bob Copeland <me@bobcopeland.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
"Lin, Ming M" <ming.m.lin@intel.com>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
"Zhao, Yakui" <yakui.zhao@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: RE: [PATCH] ACPI: resume: re-enable SCI-enable workaround
Date: Sat, 16 May 2009 01:49:30 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.00.0905160137210.4571@localhost.localdomain> (raw)
In-Reply-To: <4911F71203A09E4D9981D27F9D8308582DB914DF@orsmsx503.amr.corp.intel.com>
> >The BIOS bug workaround mistakenly got disabled
> >when we followed the ACPI specification more closely
> >by ignoring OS updates to that bit.
>
> Not exactly. ACPICA has always preserved the SCI_EN bit. Linux apparently has a "linux-only" patch to ACPICA that disables this.
>
> The recent version of ACPICA change the #define enough such that the patch no longer works.
"We" here means Linux, and thus the description is accurate.
The fact is that in 2.6.29 Linux had
ACPI_PM1_CONTROL_PRESERVED_BITS 0x0200
and when "we" updated it to 0x201 via the ACPICA update,
the workaround in the Linux resume code became a NOP.
-Len
next prev parent reply other threads:[~2009-05-16 5:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-07 10:58 acpi/suspend - irq 9: nobody cared Bob Copeland
2009-05-08 1:53 ` yakui_zhao
2009-05-12 19:01 ` Bjorn Helgaas
2009-05-12 19:26 ` Bob Copeland
2009-05-12 19:26 ` Bob Copeland
2009-05-13 4:05 ` [BISECTED] Was " Bob Copeland
[not found] ` <d3f22a0905122245h15786220g31ad0dcb8caa3a38@mail.gmail.com>
2009-05-13 5:36 ` Lin Ming
2009-05-13 8:15 ` Rafael J. Wysocki
2009-05-13 15:30 ` Bob Copeland
2009-05-13 15:30 ` Bob Copeland
2009-05-16 2:34 ` [PATCH] ACPI: resume: re-enable SCI-enable workaround Len Brown
2009-05-16 3:30 ` Moore, Robert
2009-05-16 5:49 ` Len Brown [this message]
2009-05-16 6:50 ` Moore, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0905160137210.4571@localhost.localdomain \
--to=lenb@kernel.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=ming.m.lin@intel.com \
--cc=rjw@sisk.pl \
--cc=robert.moore@intel.com \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.