All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Bryan Wu <bryan.wu@canonical.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Linus Walleij <linus.walleij@linaro.org>,
	Richard Purdie <rpurdie@rpsys.net>,
	arnd@arndb.de, tony@atomide.com, jochen@scram.de,
	linux-kernel@vger.kernel.org, jamie@jamieiles.com,
	linux@maxim.org.za, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 00/18] Introduce a led trigger for CPU activity and consolidate LED driver in ARM
Date: Mon, 29 Aug 2011 14:26:55 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1108291424310.20358@xanadu.home> (raw)
In-Reply-To: <CAK5ve-+dEc8ie-pFp8e99rrqxAgWeiW3t30JO_sEBqd3BXeZkg@mail.gmail.com>

On Tue, 30 Aug 2011, Bryan Wu wrote:

> On Mon, Aug 29, 2011 at 11:13 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Mon, Aug 29, 2011 at 09:18:29PM +0800, Bryan Wu wrote:
> >> Yeah, I replied that email with a patch to select LEDS_CLASS when
> >> CONFIG_NEW_LEDS=y.
> >
> > I don't see any point to that:
> >
> 
> Actually, what I really want to propose is to kill this option and
> build in leds-class.c when CONFIG_NEW_LEDS=y, since most of functions
> of leds-class.c are widely used by others.
> 
> And you know, to select it as default is a simple workaround.

Please go ahead with complete solutions when they exist.  We don't want 
the mainline source tree filled with simple workarounds.


Nicolas

WARNING: multiple messages have this Message-ID (diff)
From: nicolas.pitre@linaro.org (Nicolas Pitre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 00/18] Introduce a led trigger for CPU activity and consolidate LED driver in ARM
Date: Mon, 29 Aug 2011 14:26:55 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.00.1108291424310.20358@xanadu.home> (raw)
In-Reply-To: <CAK5ve-+dEc8ie-pFp8e99rrqxAgWeiW3t30JO_sEBqd3BXeZkg@mail.gmail.com>

On Tue, 30 Aug 2011, Bryan Wu wrote:

> On Mon, Aug 29, 2011 at 11:13 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Mon, Aug 29, 2011 at 09:18:29PM +0800, Bryan Wu wrote:
> >> Yeah, I replied that email with a patch to select LEDS_CLASS when
> >> CONFIG_NEW_LEDS=y.
> >
> > I don't see any point to that:
> >
> 
> Actually, what I really want to propose is to kill this option and
> build in leds-class.c when CONFIG_NEW_LEDS=y, since most of functions
> of leds-class.c are widely used by others.
> 
> And you know, to select it as default is a simple workaround.

Please go ahead with complete solutions when they exist.  We don't want 
the mainline source tree filled with simple workarounds.


Nicolas

  reply	other threads:[~2011-08-29 18:27 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-26  9:03 [PATCH v4 00/18] Introduce a led trigger for CPU activity and consolidate LED driver in ARM Bryan Wu
2011-08-26  9:03 ` Bryan Wu
2011-08-26  9:03 ` [PATCH 01/18] led-triggers: use atomic kzalloc during led trigger registering Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 02/18] led-triggers: create a trigger for CPU activity Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 03/18] arm: at91: convert old leds drivers to gpio_led and led_trigger drivers Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 04/18] mach-realview and mach-versatile: retire custom LED code Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 05/18] mach-ks8695: remove leds driver, since nobody use it Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 06/18] mach-shark: retire custom LED code Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 07/18] mach-orion5x: convert custom LED code to gpio_led and LED CPU trigger Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 08/18] mach-integrator: move CM_CTRL to header file for accessing by other functions Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 09/18] mach-integrator: retire custom LED code Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 10/18] mach-clps711x: retire custom LED code of P720T machine Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 11/18] mach-ebsa110: retire custom LED code Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 12/18] mach-footbridge: " Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 13/18] mach-pxa: " Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 14/18] plat-samsung: remove including old leds event API header file Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 15/18] mach-pnx4008: " Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 16/18] mach-omap1: retire custom LED code Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 17/18] mach-sa1100: " Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-26  9:03 ` [PATCH 18/18] ARM: use new LEDS CPU trigger stub to replace old one Bryan Wu
2011-08-26  9:03   ` Bryan Wu
2011-08-29 11:00 ` [PATCH v4 00/18] Introduce a led trigger for CPU activity and consolidate LED driver in ARM Linus Walleij
2011-08-29 11:00   ` Linus Walleij
2011-08-29 13:18   ` Bryan Wu
2011-08-29 13:18     ` Bryan Wu
2011-08-29 15:13     ` Russell King - ARM Linux
2011-08-29 15:13       ` Russell King - ARM Linux
2011-08-29 18:10       ` Bryan Wu
2011-08-29 18:10         ` Bryan Wu
2011-08-29 18:26         ` Nicolas Pitre [this message]
2011-08-29 18:26           ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.1108291424310.20358@xanadu.home \
    --to=nicolas.pitre@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bryan.wu@canonical.com \
    --cc=jamie@jamieiles.com \
    --cc=jochen@scram.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=linux@maxim.org.za \
    --cc=rpurdie@rpsys.net \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.