From: Finn Thain <fthain@telegraphics.com.au>
To: Ming Lei <ming.lei@redhat.com>
Cc: "Juergen E . Fischer" <fischer@norbit.de>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.com>, Christoph Hellwig <hch@lst.de>,
Jim Gill <jgill@vmware.com>, Cathy Avery <cavery@redhat.com>,
"Ewan D . Milne" <emilne@redhat.com>,
Brian King <brking@us.ibm.com>,
James Smart <james.smart@broadcom.com>,
Michael Schmitz <schmitzmic@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-usb@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>,
Benjamin Block <bblock@linux.ibm.com>
Subject: Re: [PATCH V3 10/15] scsi: aha152x: use sg helper to operate scatterlist
Date: Fri, 14 Jun 2019 20:36:38 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.21.1906141931070.65@nippy.intranet> (raw)
In-Reply-To: <20190614081732.GC24393@ming.t460p>
On Fri, 14 Jun 2019, Ming Lei wrote:
>
> Follows the fixed version, could you review again?
>
> From f03484d4bac083c39d70665cfbadb641093b63de Mon Sep 17 00:00:00 2001
> From: Ming Lei <ming.lei@redhat.com>
> Date: Wed, 12 Jun 2019 20:37:35 +0800
> Subject: [PATCH] scsi: aha152x: use sg helper to operate scatterlist
>
> Use the scatterlist iterators and remove direct indexing of the
> scatterlist array.
>
> This way allows us to pre-allocate one small scatterlist, which can be
> chained with one runtime allocated scatterlist if the pre-allocated one
> isn't enough for the whole request.
>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> drivers/scsi/aha152x.c | 34 ++++++++++++++++++++--------------
> 1 file changed, 20 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
> index 97872838b983..7faecdefda56 100644
> --- a/drivers/scsi/aha152x.c
> +++ b/drivers/scsi/aha152x.c
> @@ -2033,7 +2033,7 @@ static void datai_run(struct Scsi_Host *shpnt)
> CURRENT_SC->SCp.buffers_residual > 0) {
> /* advance to next buffer */
> CURRENT_SC->SCp.buffers_residual--;
> - CURRENT_SC->SCp.buffer++;
> + CURRENT_SC->SCp.buffer = sg_next(CURRENT_SC->SCp.buffer);
> CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer);
> CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length;
> }
> @@ -2139,7 +2139,7 @@ static void datao_run(struct Scsi_Host *shpnt)
> if(CURRENT_SC->SCp.this_residual==0 && CURRENT_SC->SCp.buffers_residual>0) {
> /* advance to next buffer */
> CURRENT_SC->SCp.buffers_residual--;
> - CURRENT_SC->SCp.buffer++;
> + CURRENT_SC->SCp.buffer = sg_next(CURRENT_SC->SCp.buffer);
> CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer);
> CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length;
> }
> @@ -2158,22 +2158,28 @@ static void datao_run(struct Scsi_Host *shpnt)
> static void datao_end(struct Scsi_Host *shpnt)
> {
> if(TESTLO(DMASTAT, DFIFOEMP)) {
> - int data_count = (DATA_LEN - scsi_get_resid(CURRENT_SC)) -
> - GETSTCNT();
> + int done = GETSTCNT();
> + int data_count = (DATA_LEN - scsi_get_resid(CURRENT_SC)) - done;
I think that's better than my suggestion.
> + struct scatterlist *sg = scsi_sglist(CURRENT_SC);
> + int i;
>
> CMD_INC_RESID(CURRENT_SC, data_count);
>
> - data_count -= CURRENT_SC->SCp.ptr -
> - SG_ADDRESS(CURRENT_SC->SCp.buffer);
> - while(data_count>0) {
> - CURRENT_SC->SCp.buffer--;
> - CURRENT_SC->SCp.buffers_residual++;
> - data_count -= CURRENT_SC->SCp.buffer->length;
> + /*
> + * rewind where we have done, and we have to start from
> + * the beginning
> + */
How about, "Locate the first SG entry not yet sent".
We could use sg_nents_for_len() but it returns a count of sg entries not a
scatterlist pointer so it's not very helpful here.
> + for (i = 0; done > 0 && !sg_is_last(sg); i++, sg = sg_next(sg)) {
> + if (done < sg->length)
> + break;
> + done -= sg->length;
> }
> - CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer) -
> - data_count;
> - CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length +
> - data_count;
> +
> + CURRENT_SC->SCp.buffers_residual = i;
Contradicting my previous email, that's still not right. I think it would
have to be,
CURRENT_SC->SCp.buffers_residual = scsi_sg_count(CURRENT_SC) - i;
But we could remove all references to SCp.buffers_residual, like I did in
patch 15/15 for NCR5380.c.
> + CURRENT_SC->SCp.buffer = sg;
> + CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer) + done;
> + CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length -
> + done;
> }
>
> SETPORT(SXFRCTL0, CH1|CLRCH1|CLRSTCNT);
>
What do you think of the revised patch below?
diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
index 97872838b983..6d0518f616cb 100644
--- a/drivers/scsi/aha152x.c
+++ b/drivers/scsi/aha152x.c
@@ -948,7 +948,6 @@ static int aha152x_internal_queue(struct scsi_cmnd *SCpnt,
SCp.ptr : buffer pointer
SCp.this_residual : buffer length
SCp.buffer : next buffer
- SCp.buffers_residual : left buffers in list
SCp.phase : current state of the command */
if ((phase & resetting) || !scsi_sglist(SCpnt)) {
@@ -956,13 +955,11 @@ static int aha152x_internal_queue(struct scsi_cmnd *SCpnt,
SCpnt->SCp.this_residual = 0;
scsi_set_resid(SCpnt, 0);
SCpnt->SCp.buffer = NULL;
- SCpnt->SCp.buffers_residual = 0;
} else {
scsi_set_resid(SCpnt, scsi_bufflen(SCpnt));
SCpnt->SCp.buffer = scsi_sglist(SCpnt);
SCpnt->SCp.ptr = SG_ADDRESS(SCpnt->SCp.buffer);
SCpnt->SCp.this_residual = SCpnt->SCp.buffer->length;
- SCpnt->SCp.buffers_residual = scsi_sg_count(SCpnt) - 1;
}
DO_LOCK(flags);
@@ -2030,10 +2027,9 @@ static void datai_run(struct Scsi_Host *shpnt)
}
if (CURRENT_SC->SCp.this_residual == 0 &&
- CURRENT_SC->SCp.buffers_residual > 0) {
+ !sg_is_last(CURRENT_SC->SCp.buffer)) {
/* advance to next buffer */
- CURRENT_SC->SCp.buffers_residual--;
- CURRENT_SC->SCp.buffer++;
+ CURRENT_SC->SCp.buffer = sg_next(CURRENT_SC->SCp.buffer);
CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer);
CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length;
}
@@ -2136,10 +2132,10 @@ static void datao_run(struct Scsi_Host *shpnt)
CMD_INC_RESID(CURRENT_SC, -2 * data_count);
}
- if(CURRENT_SC->SCp.this_residual==0 && CURRENT_SC->SCp.buffers_residual>0) {
+ if(CURRENT_SC->SCp.this_residual==0 &&
+ !sg_is_last(CURRENT_SC->SCp.buffer)) {
/* advance to next buffer */
- CURRENT_SC->SCp.buffers_residual--;
- CURRENT_SC->SCp.buffer++;
+ CURRENT_SC->SCp.buffer = sg_next(CURRENT_SC->SCp.buffer);
CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer);
CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length;
}
@@ -2158,22 +2154,24 @@ static void datao_run(struct Scsi_Host *shpnt)
static void datao_end(struct Scsi_Host *shpnt)
{
if(TESTLO(DMASTAT, DFIFOEMP)) {
- int data_count = (DATA_LEN - scsi_get_resid(CURRENT_SC)) -
- GETSTCNT();
+ int done = GETSTCNT();
+ int data_count = (DATA_LEN - scsi_get_resid(CURRENT_SC)) - done;
+ struct scatterlist *sg = scsi_sglist(CURRENT_SC);
CMD_INC_RESID(CURRENT_SC, data_count);
- data_count -= CURRENT_SC->SCp.ptr -
- SG_ADDRESS(CURRENT_SC->SCp.buffer);
- while(data_count>0) {
- CURRENT_SC->SCp.buffer--;
- CURRENT_SC->SCp.buffers_residual++;
- data_count -= CURRENT_SC->SCp.buffer->length;
+ /* Locate the first SG entry not yet sent */
+ while (done > 0 && !sg_is_last(sg)) {
+ if (done < sg->length)
+ break;
+ done -= sg->length;
+ sg = sg_next(sg);
}
- CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer) -
- data_count;
- CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length +
- data_count;
+
+ CURRENT_SC->SCp.buffer = sg;
+ CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer) + done;
+ CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length -
+ done;
}
SETPORT(SXFRCTL0, CH1|CLRCH1|CLRSTCNT);
@@ -2501,7 +2499,7 @@ static void get_command(struct seq_file *m, struct scsi_cmnd * ptr)
seq_printf(m, "); resid=%d; residual=%d; buffers=%d; phase |",
scsi_get_resid(ptr), ptr->SCp.this_residual,
- ptr->SCp.buffers_residual);
+ sg_nents(ptr->SCp.buffer) - 1);
if (ptr->SCp.phase & not_issued)
seq_puts(m, "not issued|");
--
WARNING: multiple messages have this Message-ID (diff)
From: Finn Thain <fthain@telegraphics.com.au>
To: Ming Lei <ming.lei@redhat.com>
Cc: Michael Schmitz <schmitzmic@gmail.com>,
devel@driverdev.osuosl.org, Hannes Reinecke <hare@suse.com>,
Benjamin Block <bblock@linux.ibm.com>,
linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, James Smart <james.smart@broadcom.com>,
"Ewan D . Milne" <emilne@redhat.com>, Jim Gill <jgill@vmware.com>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Brian King <brking@us.ibm.com>,
"Juergen E . Fischer" <fischer@norbit.de>,
Christoph Hellwig <hch@lst.de>,
Dan Carpenter <dan.carpenter@oracle.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH V3 10/15] scsi: aha152x: use sg helper to operate scatterlist
Date: Fri, 14 Jun 2019 20:36:38 +1000 (AEST) [thread overview]
Message-ID: <alpine.LNX.2.21.1906141931070.65@nippy.intranet> (raw)
In-Reply-To: <20190614081732.GC24393@ming.t460p>
On Fri, 14 Jun 2019, Ming Lei wrote:
>
> Follows the fixed version, could you review again?
>
> From f03484d4bac083c39d70665cfbadb641093b63de Mon Sep 17 00:00:00 2001
> From: Ming Lei <ming.lei@redhat.com>
> Date: Wed, 12 Jun 2019 20:37:35 +0800
> Subject: [PATCH] scsi: aha152x: use sg helper to operate scatterlist
>
> Use the scatterlist iterators and remove direct indexing of the
> scatterlist array.
>
> This way allows us to pre-allocate one small scatterlist, which can be
> chained with one runtime allocated scatterlist if the pre-allocated one
> isn't enough for the whole request.
>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
> drivers/scsi/aha152x.c | 34 ++++++++++++++++++++--------------
> 1 file changed, 20 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
> index 97872838b983..7faecdefda56 100644
> --- a/drivers/scsi/aha152x.c
> +++ b/drivers/scsi/aha152x.c
> @@ -2033,7 +2033,7 @@ static void datai_run(struct Scsi_Host *shpnt)
> CURRENT_SC->SCp.buffers_residual > 0) {
> /* advance to next buffer */
> CURRENT_SC->SCp.buffers_residual--;
> - CURRENT_SC->SCp.buffer++;
> + CURRENT_SC->SCp.buffer = sg_next(CURRENT_SC->SCp.buffer);
> CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer);
> CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length;
> }
> @@ -2139,7 +2139,7 @@ static void datao_run(struct Scsi_Host *shpnt)
> if(CURRENT_SC->SCp.this_residual==0 && CURRENT_SC->SCp.buffers_residual>0) {
> /* advance to next buffer */
> CURRENT_SC->SCp.buffers_residual--;
> - CURRENT_SC->SCp.buffer++;
> + CURRENT_SC->SCp.buffer = sg_next(CURRENT_SC->SCp.buffer);
> CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer);
> CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length;
> }
> @@ -2158,22 +2158,28 @@ static void datao_run(struct Scsi_Host *shpnt)
> static void datao_end(struct Scsi_Host *shpnt)
> {
> if(TESTLO(DMASTAT, DFIFOEMP)) {
> - int data_count = (DATA_LEN - scsi_get_resid(CURRENT_SC)) -
> - GETSTCNT();
> + int done = GETSTCNT();
> + int data_count = (DATA_LEN - scsi_get_resid(CURRENT_SC)) - done;
I think that's better than my suggestion.
> + struct scatterlist *sg = scsi_sglist(CURRENT_SC);
> + int i;
>
> CMD_INC_RESID(CURRENT_SC, data_count);
>
> - data_count -= CURRENT_SC->SCp.ptr -
> - SG_ADDRESS(CURRENT_SC->SCp.buffer);
> - while(data_count>0) {
> - CURRENT_SC->SCp.buffer--;
> - CURRENT_SC->SCp.buffers_residual++;
> - data_count -= CURRENT_SC->SCp.buffer->length;
> + /*
> + * rewind where we have done, and we have to start from
> + * the beginning
> + */
How about, "Locate the first SG entry not yet sent".
We could use sg_nents_for_len() but it returns a count of sg entries not a
scatterlist pointer so it's not very helpful here.
> + for (i = 0; done > 0 && !sg_is_last(sg); i++, sg = sg_next(sg)) {
> + if (done < sg->length)
> + break;
> + done -= sg->length;
> }
> - CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer) -
> - data_count;
> - CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length +
> - data_count;
> +
> + CURRENT_SC->SCp.buffers_residual = i;
Contradicting my previous email, that's still not right. I think it would
have to be,
CURRENT_SC->SCp.buffers_residual = scsi_sg_count(CURRENT_SC) - i;
But we could remove all references to SCp.buffers_residual, like I did in
patch 15/15 for NCR5380.c.
> + CURRENT_SC->SCp.buffer = sg;
> + CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer) + done;
> + CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length -
> + done;
> }
>
> SETPORT(SXFRCTL0, CH1|CLRCH1|CLRSTCNT);
>
What do you think of the revised patch below?
diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c
index 97872838b983..6d0518f616cb 100644
--- a/drivers/scsi/aha152x.c
+++ b/drivers/scsi/aha152x.c
@@ -948,7 +948,6 @@ static int aha152x_internal_queue(struct scsi_cmnd *SCpnt,
SCp.ptr : buffer pointer
SCp.this_residual : buffer length
SCp.buffer : next buffer
- SCp.buffers_residual : left buffers in list
SCp.phase : current state of the command */
if ((phase & resetting) || !scsi_sglist(SCpnt)) {
@@ -956,13 +955,11 @@ static int aha152x_internal_queue(struct scsi_cmnd *SCpnt,
SCpnt->SCp.this_residual = 0;
scsi_set_resid(SCpnt, 0);
SCpnt->SCp.buffer = NULL;
- SCpnt->SCp.buffers_residual = 0;
} else {
scsi_set_resid(SCpnt, scsi_bufflen(SCpnt));
SCpnt->SCp.buffer = scsi_sglist(SCpnt);
SCpnt->SCp.ptr = SG_ADDRESS(SCpnt->SCp.buffer);
SCpnt->SCp.this_residual = SCpnt->SCp.buffer->length;
- SCpnt->SCp.buffers_residual = scsi_sg_count(SCpnt) - 1;
}
DO_LOCK(flags);
@@ -2030,10 +2027,9 @@ static void datai_run(struct Scsi_Host *shpnt)
}
if (CURRENT_SC->SCp.this_residual == 0 &&
- CURRENT_SC->SCp.buffers_residual > 0) {
+ !sg_is_last(CURRENT_SC->SCp.buffer)) {
/* advance to next buffer */
- CURRENT_SC->SCp.buffers_residual--;
- CURRENT_SC->SCp.buffer++;
+ CURRENT_SC->SCp.buffer = sg_next(CURRENT_SC->SCp.buffer);
CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer);
CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length;
}
@@ -2136,10 +2132,10 @@ static void datao_run(struct Scsi_Host *shpnt)
CMD_INC_RESID(CURRENT_SC, -2 * data_count);
}
- if(CURRENT_SC->SCp.this_residual==0 && CURRENT_SC->SCp.buffers_residual>0) {
+ if(CURRENT_SC->SCp.this_residual==0 &&
+ !sg_is_last(CURRENT_SC->SCp.buffer)) {
/* advance to next buffer */
- CURRENT_SC->SCp.buffers_residual--;
- CURRENT_SC->SCp.buffer++;
+ CURRENT_SC->SCp.buffer = sg_next(CURRENT_SC->SCp.buffer);
CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer);
CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length;
}
@@ -2158,22 +2154,24 @@ static void datao_run(struct Scsi_Host *shpnt)
static void datao_end(struct Scsi_Host *shpnt)
{
if(TESTLO(DMASTAT, DFIFOEMP)) {
- int data_count = (DATA_LEN - scsi_get_resid(CURRENT_SC)) -
- GETSTCNT();
+ int done = GETSTCNT();
+ int data_count = (DATA_LEN - scsi_get_resid(CURRENT_SC)) - done;
+ struct scatterlist *sg = scsi_sglist(CURRENT_SC);
CMD_INC_RESID(CURRENT_SC, data_count);
- data_count -= CURRENT_SC->SCp.ptr -
- SG_ADDRESS(CURRENT_SC->SCp.buffer);
- while(data_count>0) {
- CURRENT_SC->SCp.buffer--;
- CURRENT_SC->SCp.buffers_residual++;
- data_count -= CURRENT_SC->SCp.buffer->length;
+ /* Locate the first SG entry not yet sent */
+ while (done > 0 && !sg_is_last(sg)) {
+ if (done < sg->length)
+ break;
+ done -= sg->length;
+ sg = sg_next(sg);
}
- CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer) -
- data_count;
- CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length +
- data_count;
+
+ CURRENT_SC->SCp.buffer = sg;
+ CURRENT_SC->SCp.ptr = SG_ADDRESS(CURRENT_SC->SCp.buffer) + done;
+ CURRENT_SC->SCp.this_residual = CURRENT_SC->SCp.buffer->length -
+ done;
}
SETPORT(SXFRCTL0, CH1|CLRCH1|CLRSTCNT);
@@ -2501,7 +2499,7 @@ static void get_command(struct seq_file *m, struct scsi_cmnd * ptr)
seq_printf(m, "); resid=%d; residual=%d; buffers=%d; phase |",
scsi_get_resid(ptr), ptr->SCp.this_residual,
- ptr->SCp.buffers_residual);
+ sg_nents(ptr->SCp.buffer) - 1);
if (ptr->SCp.phase & not_issued)
seq_puts(m, "not issued|");
--
next prev parent reply other threads:[~2019-06-14 10:36 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 2:53 [PATCH V3 00/15] use sg helper to operate scatterlist Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 01/15] scsi: vmw_pscsi: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 02/15] scsi: advansys: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 03/15] scsi: lpfc: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 04/15] scsi: mvumi: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 05/15] scsi: ipr: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 06/15] scsi: pmcraid: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 07/15] usb: image: microtek: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 5:39 ` Finn Thain
2019-06-14 5:39 ` Finn Thain
2019-06-14 6:57 ` Ming Lei
2019-06-14 6:57 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 08/15] staging: unisys: visorhba: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 5:48 ` Greg Kroah-Hartman
2019-06-14 5:48 ` Greg Kroah-Hartman
2019-06-14 2:53 ` [PATCH V3 09/15] s390: zfcp_fc: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-16 16:25 ` Benjamin Block
2019-06-16 16:25 ` Benjamin Block
2019-06-16 16:25 ` Benjamin Block
2019-06-14 2:53 ` [PATCH V3 10/15] scsi: aha152x: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 5:27 ` Finn Thain
2019-06-14 5:27 ` Finn Thain
2019-06-14 8:17 ` Ming Lei
2019-06-14 8:17 ` Ming Lei
2019-06-14 10:36 ` Finn Thain [this message]
2019-06-14 10:36 ` Finn Thain
2019-06-17 1:14 ` Ming Lei
2019-06-17 1:14 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 11/15] scsi: imm: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 12/15] scsi: pcmcia: nsp_cs: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 13/15] scsi: ppa: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 14/15] scsi: wd33c93: " Ming Lei
2019-06-14 2:53 ` Ming Lei
2019-06-14 2:53 ` [PATCH V3 15/15] NCR5380: Support chained sg lists Ming Lei
2019-06-14 2:53 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.21.1906141931070.65@nippy.intranet \
--to=fthain@telegraphics.com.au \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bblock@linux.ibm.com \
--cc=brking@us.ibm.com \
--cc=bvanassche@acm.org \
--cc=cavery@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=emilne@redhat.com \
--cc=fischer@norbit.de \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=jgill@vmware.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.