From: Keith Busch <keith.busch@intel.com>
To: Alexander Gordeev <agordeev@redhat.com>
Cc: Keith Busch <keith.busch@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Matthew Wilcox <willy@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH 2/2] nvme: Cleanup nvme_dev_start() and fix IRQ leak
Date: Tue, 21 Jan 2014 12:06:20 -0700 (MST) [thread overview]
Message-ID: <alpine.LRH.2.03.1401211151110.25844@AMR> (raw)
In-Reply-To: <20140121100719.GC8847@dhcp-26-207.brq.redhat.com>
On Tue, 21 Jan 2014, Alexander Gordeev wrote:
> This is an attempt to make handling of admin queue in a
> single scope. This update also fixes a IRQ leak in case
> nvme_setup_io_queues() failed to allocate enough iomem
> and bailed out with -ENOMEM errno.
>
> Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> ---
> +static void nvme_teardown_admin_queue(struct nvme_dev *dev)
> +{
> + nvme_disable_queue(dev, 0);
> + nvme_free_queue(dev->queues[0]);
> +}
> @@ -2402,11 +2398,20 @@ static int nvme_dev_start(struct nvme_dev *dev)
> list_add(&dev->node, &dev_list);
> spin_unlock(&dev_list_lock);
>
> - result = nvme_setup_io_queues(dev);
> - if (result && result != -EBUSY)
> + result = set_queue_count(dev, num_online_cpus());
> + if (result == -EBUSY)
> + return -EBUSY;
> +
> + nvme_teardown_admin_queue(dev);
Oh no! Your new teardown function is freeing the admin queue, but it
would be used immediatly after that in nvme_setup_io_queues ...
> +
> + if (result)
> goto disable;
... but you'll never actually get to setup io queues because the 'result'
here is non-zero if we were successful, and is the number of queues the
controller can allocate. I think you meant to do this instead:
+ if (result < 0)
>
> - return result;
> + result = nvme_setup_io_queues(dev, result);
> + if (result)
> + goto disable;
> +
> + return 0;
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH 2/2] nvme: Cleanup nvme_dev_start() and fix IRQ leak
Date: Tue, 21 Jan 2014 12:06:20 -0700 (MST) [thread overview]
Message-ID: <alpine.LRH.2.03.1401211151110.25844@AMR> (raw)
In-Reply-To: <20140121100719.GC8847@dhcp-26-207.brq.redhat.com>
On Tue, 21 Jan 2014, Alexander Gordeev wrote:
> This is an attempt to make handling of admin queue in a
> single scope. This update also fixes a IRQ leak in case
> nvme_setup_io_queues() failed to allocate enough iomem
> and bailed out with -ENOMEM errno.
>
> Signed-off-by: Alexander Gordeev <agordeev at redhat.com>
> ---
> +static void nvme_teardown_admin_queue(struct nvme_dev *dev)
> +{
> + nvme_disable_queue(dev, 0);
> + nvme_free_queue(dev->queues[0]);
> +}
> @@ -2402,11 +2398,20 @@ static int nvme_dev_start(struct nvme_dev *dev)
> list_add(&dev->node, &dev_list);
> spin_unlock(&dev_list_lock);
>
> - result = nvme_setup_io_queues(dev);
> - if (result && result != -EBUSY)
> + result = set_queue_count(dev, num_online_cpus());
> + if (result == -EBUSY)
> + return -EBUSY;
> +
> + nvme_teardown_admin_queue(dev);
Oh no! Your new teardown function is freeing the admin queue, but it
would be used immediatly after that in nvme_setup_io_queues ...
> +
> + if (result)
> goto disable;
... but you'll never actually get to setup io queues because the 'result'
here is non-zero if we were successful, and is the number of queues the
controller can allocate. I think you meant to do this instead:
+ if (result < 0)
>
> - return result;
> + result = nvme_setup_io_queues(dev, result);
> + if (result)
> + goto disable;
> +
> + return 0;
next prev parent reply other threads:[~2014-01-21 19:06 UTC|newest]
Thread overview: 114+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 16:02 [PATCH v2 0/9] Phase out pci_enable_msi_block() Alexander Gordeev
2014-01-17 16:02 ` Alexander Gordeev
2014-01-17 16:02 ` Alexander Gordeev
2014-01-17 9:26 ` [PATCH 10/9] PCI/MSI: Undeprecate pci_enable_msi() Alexander Gordeev
2014-01-29 22:10 ` Bjorn Helgaas
2014-01-17 9:27 ` [PATCH 11/9] PCI/MSI: Phase out pci_enable_msi_block() Alexander Gordeev
2014-01-29 22:22 ` Bjorn Helgaas
2014-01-17 16:02 ` [PATCH v2 1/9] ahci: Fix broken fallback to single MSI mode Alexander Gordeev
2014-01-17 16:02 ` [PATCH v2 2/9] ahci: Use pci_enable_msi_range() Alexander Gordeev
2014-01-17 16:02 ` [PATCH v2 3/9] ipr: Get rid of superfluous call to pci_disable_msi/msix() Alexander Gordeev
2014-01-17 16:02 ` [PATCH v2 4/9] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev
2014-01-28 9:54 ` Alexander Gordeev
2014-01-28 15:28 ` Brian King
2014-01-29 13:26 ` Alexander Gordeev
2014-01-30 14:06 ` Alexander Gordeev
2014-01-30 14:09 ` [PATCH v2 1/2] ipr: Get rid of superfluous call to pci_disable_msi/msix() Alexander Gordeev
2014-02-03 15:20 ` Brian King
2014-01-30 14:10 ` [PATCH v2 2/2] ipr: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev
2014-02-03 15:22 ` Brian King
2014-02-24 8:12 ` [PATCH v2 4/9] " Alexander Gordeev
2014-02-26 15:02 ` Brian King
2014-01-17 16:02 ` [PATCH v2 5/9] nvme: Fix invalid call to irq_set_affinity_hint() Alexander Gordeev
2014-01-17 16:02 ` Alexander Gordeev
2014-01-17 19:40 ` Bjorn Helgaas
2014-01-17 19:40 ` Bjorn Helgaas
2014-01-17 22:01 ` Keith Busch
2014-01-17 22:01 ` Keith Busch
2014-01-20 8:38 ` Alexander Gordeev
2014-01-20 8:38 ` Alexander Gordeev
2014-01-20 8:40 ` [PATCH v3 6/9] nvme: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev
2014-01-20 8:40 ` Alexander Gordeev
2014-02-05 13:07 ` Alexander Gordeev
2014-02-05 13:07 ` Alexander Gordeev
2014-02-18 17:54 ` Keith Busch
2014-02-18 17:54 ` Keith Busch
2014-01-20 8:42 ` [PATCH] nvme: Cleanup nvme_dev_start() and fix IRQ leak Alexander Gordeev
2014-01-20 8:42 ` Alexander Gordeev
2014-01-20 22:48 ` Keith Busch
2014-01-20 22:48 ` Keith Busch
2014-01-21 10:03 ` Alexander Gordeev
2014-01-21 10:03 ` Alexander Gordeev
2014-01-21 10:06 ` [PATCH 1/2] Revert "NVMe: Disable admin queue on init failure" Alexander Gordeev
2014-01-21 10:06 ` Alexander Gordeev
2014-01-21 10:07 ` [PATCH 2/2] nvme: Cleanup nvme_dev_start() and fix IRQ leak Alexander Gordeev
2014-01-21 10:07 ` Alexander Gordeev
2014-01-21 19:06 ` Keith Busch [this message]
2014-01-21 19:06 ` Keith Busch
2014-01-20 8:43 ` [PATCH] nvme: Cleanup nvme_dev_start() Alexander Gordeev
2014-01-20 8:43 ` Alexander Gordeev
2014-01-20 16:41 ` Keith Busch
2014-01-20 16:41 ` Keith Busch
2014-01-17 16:02 ` [PATCH v2 6/9] nvme: Use pci_enable_msi_range() and pci_enable_msix_range() Alexander Gordeev
2014-01-17 16:02 ` Alexander Gordeev
2014-01-17 16:02 ` [PATCH v2 7/9] vfio: " Alexander Gordeev
2014-01-29 21:36 ` Bjorn Helgaas
2014-01-17 16:02 ` [PATCH v2 8/9] ath10k: Use pci_enable_msi_range() Alexander Gordeev
2014-01-17 16:02 ` Alexander Gordeev
2014-01-30 13:48 ` [PATCH 1/3] ath10k: Get rid of superfluous call to pci_disable_msi() Alexander Gordeev
2014-01-30 13:48 ` Alexander Gordeev
2014-02-04 18:32 ` Kalle Valo
2014-02-04 18:32 ` Kalle Valo
2014-02-04 19:09 ` Alexander Gordeev
2014-02-04 19:09 ` Alexander Gordeev
2014-02-05 8:21 ` Kalle Valo
2014-02-05 8:21 ` Kalle Valo
2014-02-05 8:50 ` Alexander Gordeev
2014-02-05 8:50 ` Alexander Gordeev
2014-02-05 8:54 ` Kalle Valo
2014-02-05 8:54 ` Kalle Valo
2014-02-12 0:31 ` Bjorn Helgaas
2014-02-12 0:31 ` Bjorn Helgaas
2014-02-12 13:38 ` Alexander Gordeev
2014-02-12 13:38 ` Alexander Gordeev
2014-02-12 19:28 ` Bjorn Helgaas
2014-02-12 19:28 ` Bjorn Helgaas
2014-02-12 21:30 ` Kalle Valo
2014-02-12 21:30 ` Kalle Valo
2014-02-12 21:40 ` Bjorn Helgaas
2014-02-12 21:40 ` Bjorn Helgaas
2014-02-13 10:29 ` Kalle Valo
2014-02-13 10:29 ` Kalle Valo
2014-02-13 13:18 ` Alexander Gordeev
2014-02-13 16:04 ` Kalle Valo
2014-02-13 16:04 ` Kalle Valo
2014-01-30 13:48 ` [PATCH 2/3] ath10k: Disable MSI in case IRQ configuration is unknown Alexander Gordeev
2014-01-30 13:48 ` Alexander Gordeev
2014-01-30 13:49 ` [PATCH v3 3/3] ath10k: Use pci_enable_msi_range() Alexander Gordeev
2014-01-30 13:49 ` Alexander Gordeev
2014-02-03 11:02 ` [PATCH v2 8/9] " Alexander Gordeev
2014-02-03 11:02 ` Alexander Gordeev
2014-01-17 16:02 ` [PATCH v2 9/9] wil6210: " Alexander Gordeev
2014-01-29 21:37 ` Bjorn Helgaas
2014-02-07 14:46 ` [PATCH] wil6210: Fix switch operator "missing break?" warning Alexander Gordeev
2014-02-10 10:54 ` Vladimir Kondratiev
2014-02-10 12:16 ` Alexander Gordeev
2014-02-11 1:32 ` Fengguang Wu
2014-01-17 21:00 ` [PATCH v2 0/9] Phase out pci_enable_msi_block() Bjorn Helgaas
2014-01-17 21:00 ` Bjorn Helgaas
2014-01-17 21:00 ` Bjorn Helgaas
2014-01-18 7:15 ` Alexander Gordeev
2014-01-18 7:15 ` Alexander Gordeev
2014-01-18 7:15 ` Alexander Gordeev
2014-01-18 14:38 ` Bjorn Helgaas
2014-01-18 14:38 ` Bjorn Helgaas
2014-01-18 14:38 ` Bjorn Helgaas
2014-01-18 14:59 ` Tejun Heo
2014-01-18 14:59 ` Tejun Heo
2014-01-18 14:59 ` Tejun Heo
2014-01-29 21:48 ` Bjorn Helgaas
2014-01-29 21:48 ` Bjorn Helgaas
2014-01-29 21:48 ` Bjorn Helgaas
2014-01-29 13:59 ` Alexander Gordeev
2014-01-29 13:59 ` Alexander Gordeev
2014-01-29 13:59 ` Alexander Gordeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.03.1401211151110.25844@AMR \
--to=keith.busch@intel.com \
--cc=agordeev@redhat.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.