From: Dmitry Osipenko <digetx@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ben Dooks <ben.dooks@codethink.co.uk>,
Thierry Reding <thierry.reding@gmail.com>,
Edward Cragg <edward.cragg@codethink.co.uk>,
linux-tegra@vger.kernel.org, Jon Hunter <jonathanh@nvidia.com>
Subject: Re: [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples
Date: Tue, 28 Jan 2020 20:42:43 +0300 [thread overview]
Message-ID: <047c8caa-e715-5295-9794-67ff3e10cea2@gmail.com> (raw)
In-Reply-To: <20200128121315.GD4689@sirena.org.uk>
28.01.2020 15:13, Mark Brown пишет:
> On Mon, Jan 27, 2020 at 10:20:25PM +0300, Dmitry Osipenko wrote:
>> 24.01.2020 19:50, Jon Hunter пишет:
>
>>> .rates = SNDRV_PCM_RATE_8000_96000,
>>> .formats = SNDRV_PCM_FMTBIT_S32_LE |
>>> - SNDRV_PCM_FMTBIT_S24_LE |
>>> + SNDRV_PCM_FMTBIT_S24_3LE |
>
>> It should solve the problem in my particular case, but I'm not sure that
>> the solution is correct.
>
> If the format implemented by the driver is S24_3LE the driver should
> advertise S24_3LE.
It should be S24_LE, but seems we still don't know for sure.
>> The v5.5 kernel is released now with the broken audio and apparently
>> getting 24bit to work won't be trivial (if possible at all). Ben, could
>> you please send a patch to fix v5.5 by removing the S24 support
>> advertisement from the driver?
>
> Why is that the best fix rather than just advertising the format
> implemented by the driver?
The currently supported format that is known to work well is S16_LE.
I'm suggesting to drop the S24_LE and S32_LE that were added by the
applied patches simply because this series wasn't tested properly before
it was sent out and turned out that it doesn't work well.
> I really don't understand why this is all taking so long, this thread
> just seems to be going round in interminable circles long after it
> looked like the issue was understood. I have to admit I've not read
> every single message in the thread but it's difficult to see why it
> doesn't seem to be making any progress.
Ben was trying to make a fix for the introduced problem, but it's not
easy as we see now.
Perhaps the best solution should be to revert all of the three applied
patches and try again later on, once all current problems will be resolved.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-01-28 17:43 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 15:48 [alsa-devel] tegra30 tdm audio support Ben Dooks
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 1/7] ASoC: tegra: add a TDM configuration callback Ben Dooks
2019-10-24 15:50 ` Jon Hunter
2019-10-25 10:12 ` [alsa-devel] Applied "ASoC: tegra: add a TDM configuration callback" to the asoc tree Mark Brown
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Ben Dooks
2019-10-24 15:54 ` Jon Hunter
2019-10-25 10:12 ` [alsa-devel] Applied "ASoC: tegra: Allow 24bit and 32bit samples" to the asoc tree Mark Brown
2019-11-23 21:09 ` [alsa-devel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Dmitry Osipenko
2019-11-25 10:37 ` Ben Dooks
2019-11-25 17:22 ` Dmitry Osipenko
2019-11-25 17:28 ` Dmitry Osipenko
2019-12-19 21:21 ` Dmitry Osipenko
2019-12-20 10:56 ` Ben Dooks
2019-12-20 11:30 ` Jon Hunter
2019-12-20 11:38 ` Ben Dooks
2019-12-20 13:57 ` Jon Hunter
2019-12-20 14:43 ` Dmitry Osipenko
2019-12-20 14:56 ` Ben Dooks
2019-12-20 15:02 ` Dmitry Osipenko
2019-12-20 15:25 ` Ben Dooks
2019-12-20 16:40 ` Dmitry Osipenko
2019-12-20 17:06 ` Ben Dooks
2019-12-22 17:08 ` Dmitry Osipenko
2020-01-05 0:04 ` Ben Dooks
2020-01-05 1:48 ` Dmitry Osipenko
2020-01-05 10:53 ` Ben Dooks
2020-01-06 19:00 ` [alsa-devel] [Linux-kernel] " Ben Dooks
2020-01-07 1:39 ` Dmitry Osipenko
2020-01-08 11:37 ` Jon Hunter
2020-01-20 16:50 ` Dmitry Osipenko
2020-01-20 17:36 ` Ben Dooks
2020-01-23 19:38 ` Ben Dooks
2020-01-23 21:59 ` Ben Dooks
2020-01-23 22:11 ` Dmitry Osipenko
2020-01-24 4:31 ` Dmitry Osipenko
2020-01-24 16:56 ` Jon Hunter
2020-01-24 17:00 ` Mark Brown
2020-01-24 17:03 ` Ben Dooks
2020-01-24 16:50 ` Jon Hunter
2020-01-24 17:00 ` Ben Dooks
2020-01-28 7:49 ` Ricard Wanderlof
2020-01-24 17:06 ` Ben Dooks
2020-01-27 19:20 ` Dmitry Osipenko
2020-01-27 19:23 ` Dmitry Osipenko
2020-01-28 8:59 ` Ben Dooks
2020-01-28 13:19 ` Jon Hunter
2020-01-28 15:25 ` Dmitry Osipenko
2020-01-28 15:26 ` Mark Brown
2020-01-28 17:45 ` Dmitry Osipenko
2020-01-28 18:42 ` Jon Hunter
2020-01-30 8:04 ` Ben Dooks
2020-01-28 8:58 ` Ben Dooks
2020-01-28 12:13 ` Mark Brown
2020-01-28 17:42 ` Dmitry Osipenko [this message]
2020-01-28 18:19 ` Jon Hunter
2020-01-29 0:17 ` Dmitry Osipenko
2020-01-30 8:05 ` [alsa-devel] (no subject) Ben Dooks
2020-01-30 9:31 ` Clemens Ladisch
2020-01-30 9:39 ` Ben Dooks
2020-01-30 14:58 ` Clemens Ladisch
2020-01-31 10:50 ` Ben Dooks
2020-01-31 11:03 ` Clemens Ladisch
2020-01-29 10:49 ` [alsa-devel] [Linux-kernel] [PATCH v5 2/7] ASoC: tegra: Allow 24bit and 32bit samples Jon Hunter
2020-01-29 14:33 ` Jon Hunter
2020-01-29 15:22 ` Dmitry Osipenko
2020-01-30 8:17 ` Ben Dooks
2020-01-30 12:05 ` Jon Hunter
2020-01-30 12:07 ` Ben Dooks
2020-01-30 13:09 ` Jon Hunter
2020-01-30 13:10 ` Mark Brown
2020-03-19 15:32 ` Ben Dooks
2020-03-20 14:18 ` Dmitry Osipenko
2020-01-30 8:06 ` Ben Dooks
2020-01-29 17:52 ` Ben Dooks
2020-01-07 10:29 ` [alsa-devel] " Jon Hunter
2020-01-07 10:35 ` Ben Dooks
2020-01-21 18:15 ` Ben Dooks
2020-01-21 18:54 ` Dmitry Osipenko
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 3/7] ASoC: tegra: i2s: Add support for more than 2 channels Ben Dooks
2019-10-24 16:12 ` Jon Hunter
2019-10-24 19:18 ` Mark Brown
2019-10-25 7:48 ` Jon Hunter
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 4/7] ASoC: tegra: disable rx_fifo after disable stream Ben Dooks
2019-10-24 16:12 ` Jon Hunter
2019-10-25 10:12 ` [alsa-devel] Applied "ASoC: tegra: disable rx_fifo after disable stream" to the asoc tree Mark Brown
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 5/7] ASoC: tegra: set i2s_offset to 0 for tdm Ben Dooks
2019-10-25 7:58 ` Jon Hunter
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 6/7] ASoC: tegra: config fifos on hw_param changes Ben Dooks
2019-10-25 8:18 ` Jon Hunter
2019-10-18 15:48 ` [alsa-devel] [PATCH v5 7/7] ASoC: tegra: take packing settings from the audio cif_config Ben Dooks
2019-10-25 8:47 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=047c8caa-e715-5295-9794-67ff3e10cea2@gmail.com \
--to=digetx@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben.dooks@codethink.co.uk \
--cc=broonie@kernel.org \
--cc=edward.cragg@codethink.co.uk \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).