* [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error
@ 2014-02-25 8:32 Dan Carpenter
2014-02-25 13:12 ` [alsa-devel] " Liam Girdwood
2014-02-25 23:46 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-02-25 8:32 UTC (permalink / raw)
To: Liam Girdwood; +Cc: Takashi Iwai, alsa-devel, Mark Brown, kernel-janitors
This should be spin_unlock_irqrestore() instead of spin_unlock()
Fixes: 22981243589c ('ASoC: Intel: Add Haswell/Broadwell IPC')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/intel/sst-haswell-ipc.c b/sound/soc/intel/sst-haswell-ipc.c
index 668d486520ae..552aebf2c8f5 100644
--- a/sound/soc/intel/sst-haswell-ipc.c
+++ b/sound/soc/intel/sst-haswell-ipc.c
@@ -527,7 +527,7 @@ static int ipc_tx_message(struct sst_hsw *hsw, u32 header, void *tx_data,
msg = msg_get_empty(hsw);
if (msg == NULL) {
- spin_unlock(&hsw->dsp->spinlock);
+ spin_unlock_irqrestore(&hsw->dsp->spinlock, flags);
return -EBUSY;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [alsa-devel] [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error
2014-02-25 8:32 [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error Dan Carpenter
@ 2014-02-25 13:12 ` Liam Girdwood
2014-02-25 23:46 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2014-02-25 13:12 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Takashi Iwai, alsa-devel, Mark Brown, kernel-janitors
On Tue, 2014-02-25 at 11:32 +0300, Dan Carpenter wrote:
> This should be spin_unlock_irqrestore() instead of spin_unlock()
>
> Fixes: 22981243589c ('ASoC: Intel: Add Haswell/Broadwell IPC')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/sound/soc/intel/sst-haswell-ipc.c b/sound/soc/intel/sst-haswell-ipc.c
> index 668d486520ae..552aebf2c8f5 100644
> --- a/sound/soc/intel/sst-haswell-ipc.c
> +++ b/sound/soc/intel/sst-haswell-ipc.c
> @@ -527,7 +527,7 @@ static int ipc_tx_message(struct sst_hsw *hsw, u32 header, void *tx_data,
>
> msg = msg_get_empty(hsw);
> if (msg == NULL) {
> - spin_unlock(&hsw->dsp->spinlock);
> + spin_unlock_irqrestore(&hsw->dsp->spinlock, flags);
> return -EBUSY;
> }
>
Both
Acked-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error
2014-02-25 8:32 [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error Dan Carpenter
2014-02-25 13:12 ` [alsa-devel] " Liam Girdwood
@ 2014-02-25 23:46 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-02-25 23:46 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, alsa-devel,
kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
On Tue, Feb 25, 2014 at 11:32:50AM +0300, Dan Carpenter wrote:
> This should be spin_unlock_irqrestore() instead of spin_unlock()
Applied both, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-25 23:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-25 8:32 [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error Dan Carpenter
2014-02-25 13:12 ` [alsa-devel] " Liam Girdwood
2014-02-25 23:46 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).