From: Xiubo Li <Li.Xiubo@freescale.com>
To: broonie@kernel.org
Cc: Xiubo Li <Li.Xiubo@freescale.com>,
alsa-devel@alsa-project.org, shawn.guo@linaro.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/3] ASoC: io: Clean up snd_soc_codec_set_cache_io()
Date: Thu, 27 Feb 2014 17:49:51 +0800 [thread overview]
Message-ID: <1393494593-26310-2-git-send-email-Li.Xiubo@freescale.com> (raw)
In-Reply-To: <1393494593-26310-1-git-send-email-Li.Xiubo@freescale.com>
Now that all users have been converted to regmap and the config.reg_bits
and config.val_bits can be setted by each user through regmap core API.
So these two params are redundant here.
Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
---
sound/soc/soc-io.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/sound/soc/soc-io.c b/sound/soc/soc-io.c
index add99e2..18353f1 100644
--- a/sound/soc/soc-io.c
+++ b/sound/soc/soc-io.c
@@ -88,16 +88,11 @@ int snd_soc_codec_set_cache_io(struct snd_soc_codec *codec,
int addr_bits, int data_bits,
enum snd_soc_control_type control)
{
- struct regmap_config config;
int ret;
- memset(&config, 0, sizeof(config));
codec->write = hw_write;
codec->read = hw_read;
- config.reg_bits = addr_bits;
- config.val_bits = data_bits;
-
switch (control) {
case SND_SOC_REGMAP:
/* Device has made its own regmap arrangements */
--
1.8.4
next prev parent reply other threads:[~2014-02-27 10:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 9:49 [PATCH 0/3] To simplify the code for ASoC probe Xiubo Li
2014-02-27 9:49 ` Xiubo Li [this message]
2014-02-28 3:47 ` [PATCH 1/3] ASoC: io: Clean up snd_soc_codec_set_cache_io() Mark Brown
2014-02-27 9:49 ` [PATCH 2/3] ASoC: core: Set the default I/O up try regmap Xiubo Li
2014-02-28 3:52 ` Mark Brown
2014-02-28 4:00 ` Li.Xiubo
2014-02-28 5:29 ` Mark Brown
2014-02-28 5:56 ` Li.Xiubo
2014-02-28 6:38 ` [alsa-devel] " Lars-Peter Clausen
2014-02-28 6:40 ` Li.Xiubo
2014-02-28 6:46 ` Lars-Peter Clausen
2014-02-28 7:08 ` Li.Xiubo
2014-02-28 7:15 ` Lars-Peter Clausen
2014-02-28 7:18 ` Li.Xiubo
2014-02-28 7:50 ` Li.Xiubo
2014-02-28 8:15 ` Lars-Peter Clausen
2014-03-01 4:07 ` Mark Brown
2014-02-27 9:49 ` [PATCH 3/3] ASoC: SGTL5000: Simplify ASoC probe code Xiubo Li
2014-02-28 3:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393494593-26310-2-git-send-email-Li.Xiubo@freescale.com \
--to=li.xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).