From: Lars-Peter Clausen <lars@metafoo.de>
To: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
Cc: Mark Brown <broonie@kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH 2/3] ASoC: core: Set the default I/O up try regmap.
Date: Fri, 28 Feb 2014 08:15:19 +0100 [thread overview]
Message-ID: <53103787.2020702@metafoo.de> (raw)
In-Reply-To: <5d534c2ac77040d9bc373db9e43dde7c@BY2PR03MB505.namprd03.prod.outlook.com>
On 02/28/2014 08:08 AM, Li.Xiubo@freescale.com wrote:
>>>>>> Subject: Re: [PATCH 2/3] ASoC: core: Set the default I/O up try regmap.
>>>>>>
>>>>>> On Fri, Feb 28, 2014 at 04:00:38AM +0000, Li.Xiubo@freescale.com wrote:
>>>>>>
>>>>>>> I'll send another patches to applied to use this for another CODEC
>> drivers.
>>>>>>> And there almost 80 files, Should I send them in one patch or split them
>>>>>> into
>>>>>>> individual patch for each CODEC driver ?
>>>>>>
>>>>>> I'd suggest doing one patch that covers the boring drivers where the
>>>>>> first thing they do is call set_cache_io() but split out the others into
>>>>>> one patch per driver since the need more examination.
>>>>>
>>>>> Got it.
>>>>
>>>> Btw. be careful, just removing the set_cache_io() call will not work for
>> all
>>>> drivers. There are some MFD child devices which use regmap from the parent
>>>> device. So dev_get_regmap() will return NULL for those.
>>>>
>>>
>>> @Lars,
>>>
>>> Do you mean the CODEC drivers like wm5110 and wm8997 ?
>>>
>>
>>
>> Yes.
>>
>
> I only found these two CODEC drivers using MFD who would get its parent's regmap.
>
> Has I missed some ?
A quick grep reveals:
mc13783.c: codec->control_data = dev_get_regmap(codec->dev->parent, NULL);
si476x.c: codec->control_data = dev_get_regmap(codec->dev->parent, NULL);
wm5102.c: codec->control_data = priv->core.arizona->regmap;
wm5110.c: codec->control_data = priv->core.arizona->regmap;
wm8997.c: codec->control_data = priv->core.arizona->regmap;
But there might be more.
next prev parent reply other threads:[~2014-02-28 7:15 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 9:49 [PATCH 0/3] To simplify the code for ASoC probe Xiubo Li
2014-02-27 9:49 ` [PATCH 1/3] ASoC: io: Clean up snd_soc_codec_set_cache_io() Xiubo Li
2014-02-28 3:47 ` Mark Brown
2014-02-27 9:49 ` [PATCH 2/3] ASoC: core: Set the default I/O up try regmap Xiubo Li
2014-02-28 3:52 ` Mark Brown
2014-02-28 4:00 ` Li.Xiubo
2014-02-28 5:29 ` Mark Brown
2014-02-28 5:56 ` Li.Xiubo
2014-02-28 6:38 ` [alsa-devel] " Lars-Peter Clausen
2014-02-28 6:40 ` Li.Xiubo
2014-02-28 6:46 ` Lars-Peter Clausen
2014-02-28 7:08 ` Li.Xiubo
2014-02-28 7:15 ` Lars-Peter Clausen [this message]
2014-02-28 7:18 ` Li.Xiubo
2014-02-28 7:50 ` Li.Xiubo
2014-02-28 8:15 ` Lars-Peter Clausen
2014-03-01 4:07 ` Mark Brown
2014-02-27 9:49 ` [PATCH 3/3] ASoC: SGTL5000: Simplify ASoC probe code Xiubo Li
2014-02-28 3:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53103787.2020702@metafoo.de \
--to=lars@metafoo.de \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).