* [PATCH] ASoC: da732x: Print correct major id
@ 2014-04-03 11:56 Axel Lin
2014-04-07 9:54 ` Opensource [Adam Thomson]
2014-04-07 11:58 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-04-03 11:56 UTC (permalink / raw)
To: Mark Brown; +Cc: Liam Girdwood, alsa-devel, Michal Hajduk, Support Opensource
DA732X_ID_MAJOR_MASK is 0xF0, so the major id is
(reg & DA732X_ID_MAJOR_MASK) >> 4.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/da732x.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/da732x.c b/sound/soc/codecs/da732x.c
index 7d168ec..48f3fef 100644
--- a/sound/soc/codecs/da732x.c
+++ b/sound/soc/codecs/da732x.c
@@ -1571,7 +1571,8 @@ static int da732x_i2c_probe(struct i2c_client *i2c,
}
dev_info(&i2c->dev, "Revision: %d.%d\n",
- (reg & DA732X_ID_MAJOR_MASK), (reg & DA732X_ID_MINOR_MASK));
+ (reg & DA732X_ID_MAJOR_MASK) >> 4,
+ (reg & DA732X_ID_MINOR_MASK));
ret = snd_soc_register_codec(&i2c->dev, &soc_codec_dev_da732x,
da732x_dai, ARRAY_SIZE(da732x_dai));
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: da732x: Print correct major id
2014-04-03 11:56 [PATCH] ASoC: da732x: Print correct major id Axel Lin
@ 2014-04-07 9:54 ` Opensource [Adam Thomson]
2014-04-07 11:58 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Opensource [Adam Thomson] @ 2014-04-07 9:54 UTC (permalink / raw)
To: Axel Lin, Mark Brown; +Cc: alsa-devel, Support Opensource, Liam Girdwood
On Thu, Apr 3, 2014 at 12:57:32PM +0000, Axel Lin wrote:
> DA732X_ID_MAJOR_MASK is 0xF0, so the major id is
> (reg & DA732X_ID_MAJOR_MASK) >> 4.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> sound/soc/codecs/da732x.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/da732x.c b/sound/soc/codecs/da732x.c
> index 7d168ec..48f3fef 100644
> --- a/sound/soc/codecs/da732x.c
> +++ b/sound/soc/codecs/da732x.c
> @@ -1571,7 +1571,8 @@ static int da732x_i2c_probe(struct i2c_client *i2c,
> }
>
> dev_info(&i2c->dev, "Revision: %d.%d\n",
> - (reg & DA732X_ID_MAJOR_MASK), (reg &
> DA732X_ID_MINOR_MASK));
> + (reg & DA732X_ID_MAJOR_MASK) >> 4,
> + (reg & DA732X_ID_MINOR_MASK));
>
> ret = snd_soc_register_codec(&i2c->dev, &soc_codec_dev_da732x,
> da732x_dai, ARRAY_SIZE(da732x_dai));
> --
> 1.8.3.2
>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: da732x: Print correct major id
2014-04-03 11:56 [PATCH] ASoC: da732x: Print correct major id Axel Lin
2014-04-07 9:54 ` Opensource [Adam Thomson]
@ 2014-04-07 11:58 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-04-07 11:58 UTC (permalink / raw)
To: Axel Lin; +Cc: Liam Girdwood, alsa-devel, Michal Hajduk, Support Opensource
[-- Attachment #1.1: Type: text/plain, Size: 164 bytes --]
On Thu, Apr 03, 2014 at 07:56:32PM +0800, Axel Lin wrote:
> DA732X_ID_MAJOR_MASK is 0xF0, so the major id is
> (reg & DA732X_ID_MAJOR_MASK) >> 4.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-07 11:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-03 11:56 [PATCH] ASoC: da732x: Print correct major id Axel Lin
2014-04-07 9:54 ` Opensource [Adam Thomson]
2014-04-07 11:58 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).