From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: mark.rutland@arm.com, alsa-devel@alsa-project.org,
wim@linux-watchdog.org, broonie@kernel.org,
yong.liang@mediatek.com, Jiaxin Yu <jiaxin.yu@mediatek.com>,
lgirdwood@gmail.com, tzungbi@google.com, robh+dt@kernel.org,
linux-mediatek@lists.infradead.org,
Philipp Zabel <p.zabel@pengutronix.de>,
eason.yen@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH v2 2/4] watchdog: mtk_wdt: mt8183: Add reset controller
Date: Mon, 30 Sep 2019 16:17:19 +0800 [thread overview]
Message-ID: <1569831439.15728.9.camel@mtksdaap41> (raw)
In-Reply-To: <20190928174923.GA25512@roeck-us.net>
On Sat, 2019-09-28 at 10:49 -0700, Guenter Roeck wrote:
> On Fri, Sep 27, 2019 at 06:31:55PM +0800, Jiaxin Yu wrote:
> > From: "yong.liang" <yong.liang@mediatek.com>
> >
> > Provide assert/deassert/reset API in watchdog driver.
> > Register reset controller for toprgu device in watchdog probe.
> >
> > Signed-off-by: yong.liang <yong.liang@mediatek.com>
> > ---
> > drivers/watchdog/Kconfig | 1 +
> > drivers/watchdog/mtk_wdt.c | 110 ++++++++++++++++++++++++++++++++++++-
> > 2 files changed, 110 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index 2e07caab9db2..629249fe5305 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -717,6 +717,7 @@ config MEDIATEK_WATCHDOG
> > tristate "Mediatek SoCs watchdog support"
> > depends on ARCH_MEDIATEK || COMPILE_TEST
> > select WATCHDOG_CORE
> > + select RESET_CONTROLLER
> > help
> > Say Y here to include support for the watchdog timer
> > in Mediatek SoCs.
<...snip...>
> > +static void toprgu_register_reset_controller(struct platform_device *pdev,
> > + int regofs)
> > +{
> > + int ret;
> > + struct mtk_wdt_dev *mtk_wdt = platform_get_drvdata(pdev);
> > +
> > + spin_lock_init(&mtk_wdt->reset_controller.lock);
> > +
> > + mtk_wdt->dev_comp = of_device_get_match_data(&pdev->dev);
> > + mtk_wdt->reset_controller.toprgu_swrst_base = mtk_wdt->wdt_base;
> > + mtk_wdt->reset_controller.regofs = regofs;
> > + mtk_wdt->reset_controller.rcdev.owner = THIS_MODULE;
> > + mtk_wdt->reset_controller.rcdev.nr_resets =
> > + mtk_wdt->dev_comp->sw_rst_num;
> > + mtk_wdt->reset_controller.rcdev.ops = &toprgu_reset_ops;
> > + mtk_wdt->reset_controller.rcdev.of_node = pdev->dev.of_node;
> > + ret = reset_controller_register(&mtk_wdt->reset_controller.rcdev);
> > + if (ret != 0)
> > + dev_err(&pdev->dev,
> > + "couldn't register wdt reset controller: %d\n", ret);
> > +}
> > +
> > static int mtk_wdt_restart(struct watchdog_device *wdt_dev,
> > unsigned long action, void *data)
> > {
> > @@ -187,9 +287,12 @@ static int mtk_wdt_probe(struct platform_device *pdev)
> > if (unlikely(err))
> > return err;
> >
> > - dev_info(dev, "Watchdog enabled (timeout=%d sec, nowayout=%d)\n",
> > + dev_info(&pdev->dev, "Watchdog enabled (timeout=%d sec, nowayout=%d)\n",
> > mtk_wdt->wdt_dev.timeout, nowayout);
> >
> > + mtk_wdt->dev_comp = of_device_get_match_data(&pdev->dev);
> > + if (mtk_wdt->dev_comp)
> > + toprgu_register_reset_controller(pdev, WDT_SWSYSRST);
>
> Please explain why you can not use the watchdog device built-in support
> for handling system resets.
Guenter,
This is not about system reset.
Besides watchdog, MTK toprgu module also provide sub-system (eg, audio,
camera, codec and connectivity) software reset functionality. Software
can use this to reset specific sub-system.
This patch add support for this using reset controller framework. We
follow the case of drivers/clk/mediatek/reset.c to add this
functionality in watchdog driver.
Joe.C
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-09-30 8:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 10:31 [alsa-devel] [PATCH v2 0/4] ASoC: mt8183: fix audio playback slowly after playback Jiaxin Yu
2019-09-27 10:31 ` [alsa-devel] [PATCH v2 1/4] dt-bindings: mediatek: mt8183: Add #reset-cells Jiaxin Yu
2019-09-27 10:31 ` [alsa-devel] [PATCH v2 2/4] watchdog: mtk_wdt: mt8183: Add reset controller Jiaxin Yu
2019-09-28 17:49 ` Guenter Roeck
2019-09-30 8:17 ` Yingjoe Chen [this message]
2019-10-03 13:49 ` Guenter Roeck
2019-10-05 5:59 ` Yingjoe Chen
2019-10-05 14:46 ` Guenter Roeck
2019-10-08 14:08 ` Philipp Zabel
2019-10-05 5:50 ` Yingjoe Chen
2019-09-27 10:31 ` [alsa-devel] [PATCH v2 3/4] dt-bindings: medaitek: mt8183: add property "resets" && "reset-names" Jiaxin Yu
2019-10-08 12:53 ` [alsa-devel] Applied "dt-bindings: medaitek: mt8183: add property "resets" && "reset-names"" to the asoc tree Mark Brown
2019-09-27 10:31 ` [alsa-devel] [PATCH v2 4/4] ASoC: mt8183: fix audio playback slowly after playback during bootup Jiaxin Yu
2019-10-05 6:07 ` Yingjoe Chen
2019-10-08 12:11 ` Mark Brown
2019-10-08 12:53 ` [alsa-devel] Applied "ASoC: mt8183: fix audio playback slowly after playback during bootup" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569831439.15728.9.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=eason.yen@mediatek.com \
--cc=jiaxin.yu@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=tzungbi@google.com \
--cc=wim@linux-watchdog.org \
--cc=yong.liang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).