alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: rt5682: Fix the fast discharge for headset unplugging in soundwire mode
@ 2021-06-04  6:31 Oder Chiou
  2021-06-04 11:08 ` Mark Brown
  2021-06-04 16:32 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Oder Chiou @ 2021-06-04  6:31 UTC (permalink / raw)
  To: broonie, lgirdwood
  Cc: libin.yang, jack.yu, alsa-devel, Oder Chiou, sathya.prakash.m.r,
	derek.fang, bard.liao, shumingf, flove

Based on ("5a15cd7fce20b1fd4aece6a0240e2b58cd6a225d"), the setting also
should be set in soundwire mode.

Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
---
 sound/soc/codecs/rt5682-sdw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rt5682-sdw.c b/sound/soc/codecs/rt5682-sdw.c
index fed80c8f994f..e78ba3b064c4 100644
--- a/sound/soc/codecs/rt5682-sdw.c
+++ b/sound/soc/codecs/rt5682-sdw.c
@@ -462,7 +462,8 @@ static int rt5682_io_init(struct device *dev, struct sdw_slave *slave)
 
 	regmap_update_bits(rt5682->regmap, RT5682_CBJ_CTRL_2,
 		RT5682_EXT_JD_SRC, RT5682_EXT_JD_SRC_MANUAL);
-	regmap_write(rt5682->regmap, RT5682_CBJ_CTRL_1, 0xd042);
+	regmap_write(rt5682->regmap, RT5682_CBJ_CTRL_1, 0xd142);
+	regmap_update_bits(rt5682->regmap, RT5682_CBJ_CTRL_5, 0x0700, 0x0600);
 	regmap_update_bits(rt5682->regmap, RT5682_CBJ_CTRL_3,
 		RT5682_CBJ_IN_BUF_EN, RT5682_CBJ_IN_BUF_EN);
 	regmap_update_bits(rt5682->regmap, RT5682_SAR_IL_CMD_1,
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: rt5682: Fix the fast discharge for headset unplugging  in soundwire mode
  2021-06-04  6:31 [PATCH] ASoC: rt5682: Fix the fast discharge for headset unplugging in soundwire mode Oder Chiou
@ 2021-06-04 11:08 ` Mark Brown
  2021-06-04 16:32 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-06-04 11:08 UTC (permalink / raw)
  To: Oder Chiou
  Cc: libin.yang, jack.yu, alsa-devel, lgirdwood, sathya.prakash.m.r,
	derek.fang, bard.liao, shumingf, flove

[-- Attachment #1: Type: text/plain, Size: 518 bytes --]

On Fri, Jun 04, 2021 at 02:31:50PM +0800, Oder Chiou wrote:
> Based on ("5a15cd7fce20b1fd4aece6a0240e2b58cd6a225d"), the setting also

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: rt5682: Fix the fast discharge for headset unplugging in soundwire mode
  2021-06-04  6:31 [PATCH] ASoC: rt5682: Fix the fast discharge for headset unplugging in soundwire mode Oder Chiou
  2021-06-04 11:08 ` Mark Brown
@ 2021-06-04 16:32 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2021-06-04 16:32 UTC (permalink / raw)
  To: lgirdwood, Oder Chiou
  Cc: libin.yang, jack.yu, alsa-devel, shumingf, Mark Brown,
	derek.fang, flove, sathya.prakash.m.r, bard.liao

On Fri, 4 Jun 2021 14:31:50 +0800, Oder Chiou wrote:
> Based on ("5a15cd7fce20b1fd4aece6a0240e2b58cd6a225d"), the setting also
> should be set in soundwire mode.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: rt5682: Fix the fast discharge for headset unplugging in soundwire mode
      commit: 49783c6f4a4f49836b5a109ae0daf2f90b0d7713

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-04 16:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04  6:31 [PATCH] ASoC: rt5682: Fix the fast discharge for headset unplugging in soundwire mode Oder Chiou
2021-06-04 11:08 ` Mark Brown
2021-06-04 16:32 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).