alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] ASoC: SOF: Kconfig: Fix the dependency for client modules
@ 2022-08-23 12:15 Peter Ujfalusi
  2022-08-23 12:15 ` [PATCH 1/2] ASoC: SOF: Kconfig: Make IPC_FLOOD_TEST depend on SND_SOC_SOF Peter Ujfalusi
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2022-08-23 12:15 UTC (permalink / raw)
  To: lgirdwood, broonie, pierre-louis.bossart
  Cc: alsa-devel, ranjani.sridharan, kai.vehmanen

Hi,

There is still a chance to end up with a client driver selected as built in
while the core SOF is as module.

Fix this by making the client drivers depend on SND_SOC_SOF.

Regards,
Peter
---
Peter Ujfalusi (2):
  ASoC: SOF: Kconfig: Make IPC_FLOOD_TEST depend on SND_SOC_SOF
  ASoC: SOF: Kconfig: Make IPC_MESSAGE_INJECTOR depend on SND_SOC_SOF

 sound/soc/sof/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.37.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] ASoC: SOF: Kconfig: Make IPC_FLOOD_TEST depend on SND_SOC_SOF
  2022-08-23 12:15 [PATCH 0/2] ASoC: SOF: Kconfig: Fix the dependency for client modules Peter Ujfalusi
@ 2022-08-23 12:15 ` Peter Ujfalusi
  2022-08-23 12:15 ` [PATCH 2/2] ASoC: SOF: Kconfig: Make IPC_MESSAGE_INJECTOR " Peter Ujfalusi
  2022-08-23 18:37 ` [PATCH 0/2] ASoC: SOF: Kconfig: Fix the dependency for client modules Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2022-08-23 12:15 UTC (permalink / raw)
  To: lgirdwood, broonie, pierre-louis.bossart
  Cc: alsa-devel, ranjani.sridharan, kai.vehmanen

Make sure that the IPC_FLOOD client can not be built in when SND_SOC_SOF is
built as module.

Fixes: 6e9548cdb30e5 ("ASoC: SOF: Convert the generic IPC flood test into SOF client")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/sof/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig
index e90f173d067c..cfb244e4e142 100644
--- a/sound/soc/sof/Kconfig
+++ b/sound/soc/sof/Kconfig
@@ -196,6 +196,7 @@ config SND_SOC_SOF_DEBUG_ENABLE_FIRMWARE_TRACE
 
 config SND_SOC_SOF_DEBUG_IPC_FLOOD_TEST
 	tristate "SOF enable IPC flood test"
+	depends on SND_SOC_SOF
 	select SND_SOC_SOF_CLIENT
 	help
 	  This option enables a separate client device for IPC flood test
-- 
2.37.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ASoC: SOF: Kconfig: Make IPC_MESSAGE_INJECTOR depend on SND_SOC_SOF
  2022-08-23 12:15 [PATCH 0/2] ASoC: SOF: Kconfig: Fix the dependency for client modules Peter Ujfalusi
  2022-08-23 12:15 ` [PATCH 1/2] ASoC: SOF: Kconfig: Make IPC_FLOOD_TEST depend on SND_SOC_SOF Peter Ujfalusi
@ 2022-08-23 12:15 ` Peter Ujfalusi
  2022-08-23 18:37 ` [PATCH 0/2] ASoC: SOF: Kconfig: Fix the dependency for client modules Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2022-08-23 12:15 UTC (permalink / raw)
  To: lgirdwood, broonie, pierre-louis.bossart
  Cc: alsa-devel, ranjani.sridharan, kai.vehmanen

Make sure that the IPC_MESSAGE_INJECTOR client can not be built in when
SND_SOC_SOF is built as module.

Fixes: cac0b0887e530 ("ASoC: SOF: Convert the generic IPC message injector into SOF client")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/sof/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sof/Kconfig b/sound/soc/sof/Kconfig
index cfb244e4e142..37f7df5fde17 100644
--- a/sound/soc/sof/Kconfig
+++ b/sound/soc/sof/Kconfig
@@ -215,6 +215,7 @@ config SND_SOC_SOF_DEBUG_IPC_FLOOD_TEST_NUM
 
 config SND_SOC_SOF_DEBUG_IPC_MSG_INJECTOR
 	tristate "SOF enable IPC message injector"
+	depends on SND_SOC_SOF
 	select SND_SOC_SOF_CLIENT
 	help
 	  This option enables the IPC message injector which can be used to send
-- 
2.37.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] ASoC: SOF: Kconfig: Fix the dependency for client modules
  2022-08-23 12:15 [PATCH 0/2] ASoC: SOF: Kconfig: Fix the dependency for client modules Peter Ujfalusi
  2022-08-23 12:15 ` [PATCH 1/2] ASoC: SOF: Kconfig: Make IPC_FLOOD_TEST depend on SND_SOC_SOF Peter Ujfalusi
  2022-08-23 12:15 ` [PATCH 2/2] ASoC: SOF: Kconfig: Make IPC_MESSAGE_INJECTOR " Peter Ujfalusi
@ 2022-08-23 18:37 ` Mark Brown
  2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-08-23 18:37 UTC (permalink / raw)
  To: pierre-louis.bossart, Peter Ujfalusi, lgirdwood
  Cc: alsa-devel, ranjani.sridharan, kai.vehmanen

On Tue, 23 Aug 2022 15:15:52 +0300, Peter Ujfalusi wrote:
> There is still a chance to end up with a client driver selected as built in
> while the core SOF is as module.
> 
> Fix this by making the client drivers depend on SND_SOC_SOF.
> 
> Regards,
> Peter
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: SOF: Kconfig: Make IPC_FLOOD_TEST depend on SND_SOC_SOF
      commit: 3942499fba11de048c3ac1390b808e9e6ae88de5
[2/2] ASoC: SOF: Kconfig: Make IPC_MESSAGE_INJECTOR depend on SND_SOC_SOF
      commit: 2cf520ffbcbd55c0f2b4276065444d7526d9d197

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-08-23 18:38 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23 12:15 [PATCH 0/2] ASoC: SOF: Kconfig: Fix the dependency for client modules Peter Ujfalusi
2022-08-23 12:15 ` [PATCH 1/2] ASoC: SOF: Kconfig: Make IPC_FLOOD_TEST depend on SND_SOC_SOF Peter Ujfalusi
2022-08-23 12:15 ` [PATCH 2/2] ASoC: SOF: Kconfig: Make IPC_MESSAGE_INJECTOR " Peter Ujfalusi
2022-08-23 18:37 ` [PATCH 0/2] ASoC: SOF: Kconfig: Fix the dependency for client modules Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).