alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: fsl: Remove unused inline function imx_pcm_dma_params_init_data()
@ 2022-09-23  9:03 Gaosheng Cui
  2022-09-23 17:06 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Gaosheng Cui @ 2022-09-23  9:03 UTC (permalink / raw)
  To: shengjiu.wang, Xiubo.Lee, festevam, nicoleotsuka, lgirdwood,
	broonie, perex, tiwai, shawnguo, s.hauer, kernel, linux-imx,
	cuigaosheng1
  Cc: alsa-devel, linuxppc-dev, linux-arm-kernel

The imx_pcm_dma_params_init_data() are no longer used since
commit c31da0b196f9 ("ASoC: imx-ssi: Remove unused driver"),
and the function is used to initialize some members of
"struct imx_dma_data", it's more readable to assign the value
directly, imx_pcm_dma_params_init_data is useless, so remove it.

Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
 sound/soc/fsl/imx-pcm.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/sound/soc/fsl/imx-pcm.h b/sound/soc/fsl/imx-pcm.h
index 06b25f4b26b6..ac5f57c3cc55 100644
--- a/sound/soc/fsl/imx-pcm.h
+++ b/sound/soc/fsl/imx-pcm.h
@@ -18,15 +18,6 @@
 
 #define IMX_DEFAULT_DMABUF_SIZE	(64 * 1024)
 
-static inline void
-imx_pcm_dma_params_init_data(struct imx_dma_data *dma_data,
-	int dma, enum sdma_peripheral_type peripheral_type)
-{
-	dma_data->dma_request = dma;
-	dma_data->priority = DMA_PRIO_HIGH;
-	dma_data->peripheral_type = peripheral_type;
-}
-
 struct imx_pcm_fiq_params {
 	int irq;
 	void __iomem *base;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: fsl: Remove unused inline function imx_pcm_dma_params_init_data()
  2022-09-23  9:03 [PATCH] ASoC: fsl: Remove unused inline function imx_pcm_dma_params_init_data() Gaosheng Cui
@ 2022-09-23 17:06 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2022-09-23 17:06 UTC (permalink / raw)
  To: linux-imx, shawnguo, perex, nicoleotsuka, shengjiu.wang, tiwai,
	s.hauer, lgirdwood, kernel, Xiubo.Lee, Gaosheng Cui, festevam
  Cc: alsa-devel, linuxppc-dev, linux-arm-kernel

On Fri, 23 Sep 2022 17:03:55 +0800, Gaosheng Cui wrote:
> The imx_pcm_dma_params_init_data() are no longer used since
> commit c31da0b196f9 ("ASoC: imx-ssi: Remove unused driver"),
> and the function is used to initialize some members of
> "struct imx_dma_data", it's more readable to assign the value
> directly, imx_pcm_dma_params_init_data is useless, so remove it.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: fsl: Remove unused inline function imx_pcm_dma_params_init_data()
      commit: 4f865485e8ef1d04de23fc1def1fa4e39fb00b91

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-09-23 17:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-23  9:03 [PATCH] ASoC: fsl: Remove unused inline function imx_pcm_dma_params_init_data() Gaosheng Cui
2022-09-23 17:06 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).