[PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema

[PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema

[Saalim Quadri]

Convert the WM8523 audio CODEC bindings to DT schema

Signed-off-by: Saalim Quadri <danascape@gmail.com>
---
 .../devicetree/bindings/sound/wlf,wm8523.yaml | 40 +++++++++++++++++++
 .../devicetree/bindings/sound/wm8523.txt      | 16 --------
 2 files changed, 40 insertions(+), 16 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
 delete mode 100644 Documentation/devicetree/bindings/sound/wm8523.txt

diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
new file mode 100644
index 000000000000..decc395bb873
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/wlf,wm8523.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: WM8523 audio CODEC
+
+maintainers:
+  - patches@opensource.cirrus.com
+
+allOf:
+  - $ref: dai-common.yaml#
+
+properties:
+  compatible:
+    const: wlf,wm8523
+
+  reg:
+    maxItems: 1
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        codec@1a {
+            compatible = "wlf,wm8523";
+            reg = <0x1a>;
+        };
+    };        
diff --git a/Documentation/devicetree/bindings/sound/wm8523.txt b/Documentation/devicetree/bindings/sound/wm8523.txt
deleted file mode 100644
index f3a6485f4b8a..000000000000
--- a/Documentation/devicetree/bindings/sound/wm8523.txt
+++ /dev/null
@@ -1,16 +0,0 @@
-WM8523 audio CODEC
-
-This device supports I2C only.
-
-Required properties:
-
-  - compatible : "wlf,wm8523"
-
-  - reg : the I2C address of the device.
-
-Example:
-
-wm8523: codec@1a {
-	compatible = "wlf,wm8523";
-	reg = <0x1a>;
-};
-- 
2.34.1

Re: [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema

[Krzysztof Kozlowski]

On 05/04/2023 22:34, Saalim Quadri wrote:
> Convert the WM8523 audio CODEC bindings to DT schema
> 
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
> ---
>  .../devicetree/bindings/sound/wlf,wm8523.yaml | 40 +++++++++++++++++++
>  .../devicetree/bindings/sound/wm8523.txt      | 16 --------
>  2 files changed, 40 insertions(+), 16 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/wm8523.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
> new file mode 100644
> index 000000000000..decc395bb873
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/wlf,wm8523.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/wlf,wm8523.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: WM8523 audio CODEC
> +
> +maintainers:
> +  - patches@opensource.cirrus.com
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: wlf,wm8523
> +
> +  reg:
> +    maxItems: 1
> +
> +  "#sound-dai-cells":
> +    const: 0
> +

Please squash all your three WM bindings (wm8711, wm8580 and wm8523)
into one binding, if they are the same. Probably other WM from your
previous submissions as well. We really do not need binding per each of
this simple codecs. If they ever need to grow, then we can split them.

Best regards,
Krzysztof

Re: [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

On Thu, Apr 06, 2023 at 07:38:19PM +0200, Krzysztof Kozlowski wrote:

> Please squash all your three WM bindings (wm8711, wm8580 and wm8523)
> into one binding, if they are the same. Probably other WM from your
> previous submissions as well. We really do not need binding per each of
> this simple codecs. If they ever need to grow, then we can split them.

At a minimum all of these devices should have separate regulator
specifications should they ever grow regulator support (and ideally
would have regulators specified in the binding from the get go).

There's also no reason to restrict simple CODECs to a particular
manufacturer...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema

[Saalim Quadri]

Hi,

I will check if there are other bindings under wm as well and squash them up into one.

Kind Regards,

Saalim

Re: [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema

[Saalim Quadri]

Hi,

Having a single file for other manufacturers, wouldn't that might cause issues with finding them?

Kind Regards,

Saalim

Re: [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema

[Krzysztof Kozlowski]

On 06/04/2023 22:26, Mark Brown wrote:
> On Thu, Apr 06, 2023 at 07:38:19PM +0200, Krzysztof Kozlowski wrote:
> 
>> Please squash all your three WM bindings (wm8711, wm8580 and wm8523)
>> into one binding, if they are the same. Probably other WM from your
>> previous submissions as well. We really do not need binding per each of
>> this simple codecs. If they ever need to grow, then we can split them.
> 
> At a minimum all of these devices should have separate regulator
> specifications should they ever grow regulator support (and ideally
> would have regulators specified in the binding from the get go).

Good point. The bindings are incomplete that's why they look so similar.
Therefore maybe we should not merge them, just like we do not add
non-trivial-devices to trivial-devices schema, just because device is
incomplete.

> There's also no reason to restrict simple CODECs to a particular
> manufacturer...

True, we could extend it to other brands.

Best regards,
Krzysztof

Re: [PATCH] ASoC: dt-bindings: wm8523: Convert to dtschema

[Mark Brown]

On Thu, 06 Apr 2023 02:04:19 +0530, Saalim Quadri wrote:
> Convert the WM8523 audio CODEC bindings to DT schema
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: wm8523: Convert to dtschema
      commit: 3e5f79723dc3f22fed30ba5a559db11b53b632ae

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark