[PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list for acp6x

[PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list for acp6x

[Baishan Jiang]

ThinkBook 14 G5+ ARP uses Ryzen 7735H processor, and has the same 
microphone problem as ThinkBook 14 G4+ ARA.

Adding 21HY to acp6x quirks table enables microphone for ThinkBook 
14 G5+ ARP.

Signed-off-by: Baishan Jiang <bjiang400@outlook.com>
---
V1 -> V2: Fixed signed-off-by format
---
 sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 0acdf0156f07..62d8a8e060d2 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -178,6 +178,13 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21EN"),
 		}
 	},
+	{
+		.driver_data = &acp6x_card,
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
+		}
+	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.40.0

RE: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list for acp6x

[Limonciello, Mario via Alsa-devel]

[-- Attachment #0: Type: message/rfc822, Size: 12597 bytes --]

From: "Limonciello, Mario" <Mario.Limonciello@amd.com>
To: Baishan Jiang <bjiang400@outlook.com>, Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, Mark Pearson <mpearson-lenovo@squebb.ca>
Subject: RE: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list for acp6x
Date: Wed, 12 Apr 2023 14:47:01 +0000
Message-ID: <MN0PR12MB61013DABE036B5D1BB3518A5E29B9@MN0PR12MB6101.namprd12.prod.outlook.com>

[Public]

Loop Mark Pearson from Lenovo for awareness.

> -----Original Message-----
> From: Baishan Jiang <bjiang400@outlook.com>
> Sent: Wednesday, April 12, 2023 03:41
> To: Mark Brown <broonie@kernel.org>; Takashi Iwai <tiwai@suse.com>;
> Limonciello, Mario <Mario.Limonciello@amd.com>; alsa-devel@alsa-
> project.org
> Cc: Baishan Jiang <bjiang400@outlook.com>
> Subject: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list
> for acp6x
> 
> ThinkBook 14 G5+ ARP uses Ryzen 7735H processor, and has the same
> microphone problem as ThinkBook 14 G4+ ARA.
> 
> Adding 21HY to acp6x quirks table enables microphone for ThinkBook
> 14 G5+ ARP.
> 
> Signed-off-by: Baishan Jiang <bjiang400@outlook.com>

It would be generally preferred for systems to start including the _DSD in the
BIOS so we can stop growing the quirk list, but if they don't then patches like
this make sense.

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
> V1 -> V2: Fixed signed-off-by format
> ---
>  sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-
> mach.c
> index 0acdf0156f07..62d8a8e060d2 100644
> --- a/sound/soc/amd/yc/acp6x-mach.c
> +++ b/sound/soc/amd/yc/acp6x-mach.c
> @@ -178,6 +178,13 @@ static const struct dmi_system_id
> yc_acp_quirk_table[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "21EN"),
>  		}
>  	},
> +	{
> +		.driver_data = &acp6x_card,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
> +		}
> +	},
>  	{
>  		.driver_data = &acp6x_card,
>  		.matches = {
> --
> 2.40.0

Re: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list for acp6x

[Mark Brown]

On Wed, 12 Apr 2023 16:40:43 +0800, Baishan Jiang wrote:
> ThinkBook 14 G5+ ARP uses Ryzen 7735H processor, and has the same
> microphone problem as ThinkBook 14 G4+ ARA.
> 
> Adding 21HY to acp6x quirks table enables microphone for ThinkBook
> 14 G5+ ARP.
> 
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list for acp6x
      commit: a8f5da0bf4d85a6ad03810d902aba61c572102a6

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

Re: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list for acp6x

[Mark Pearson]

On Wed, Apr 12, 2023, at 10:47 AM, Limonciello, Mario wrote:
> [Public]
>
> Loop Mark Pearson from Lenovo for awareness.
>
>> -----Original Message-----
>> From: Baishan Jiang <bjiang400@outlook.com>
>> Sent: Wednesday, April 12, 2023 03:41
>> To: Mark Brown <broonie@kernel.org>; Takashi Iwai <tiwai@suse.com>;
>> Limonciello, Mario <Mario.Limonciello@amd.com>; alsa-devel@alsa-
>> project.org
>> Cc: Baishan Jiang <bjiang400@outlook.com>
>> Subject: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list
>> for acp6x
>> 
>> ThinkBook 14 G5+ ARP uses Ryzen 7735H processor, and has the same
>> microphone problem as ThinkBook 14 G4+ ARA.
>> 
>> Adding 21HY to acp6x quirks table enables microphone for ThinkBook
>> 14 G5+ ARP.
>> 
>> Signed-off-by: Baishan Jiang <bjiang400@outlook.com>
>
> It would be generally preferred for systems to start including the _DSD in the
> BIOS so we can stop growing the quirk list, but if they don't then patches like
> this make sense.

Ack. I've forwarded to the FW team. Internal ticket is LO-2404.

Realistically though - I'd recommend still carrying on with the patch. This platform isn't in the Linux program and it could take me a while to see if I can get them to accept making changes I'm afraid.

Mark

>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
>
>> ---
>> V1 -> V2: Fixed signed-off-by format
>> ---
>>  sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>> 
>> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-
>> mach.c
>> index 0acdf0156f07..62d8a8e060d2 100644
>> --- a/sound/soc/amd/yc/acp6x-mach.c
>> +++ b/sound/soc/amd/yc/acp6x-mach.c
>> @@ -178,6 +178,13 @@ static const struct dmi_system_id
>> yc_acp_quirk_table[] = {
>>  			DMI_MATCH(DMI_PRODUCT_NAME, "21EN"),
>>  		}
>>  	},
>> +	{
>> +		.driver_data = &acp6x_card,
>> +		.matches = {
>> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
>> +		}
>> +	},
>>  	{
>>  		.driver_data = &acp6x_card,
>>  		.matches = {
>> --
>> 2.40.0

RE: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list for acp6x

[Limonciello, Mario via Alsa-devel]

[-- Attachment #0: Type: message/rfc822, Size: 13948 bytes --]

From: "Limonciello, Mario" <Mario.Limonciello@amd.com>
To: Mark Pearson <mpearson-lenovo@squebb.ca>, Baishan Jiang <bjiang400@outlook.com>, Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: RE: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks list for acp6x
Date: Thu, 13 Apr 2023 16:35:40 +0000
Message-ID: <MN0PR12MB6101890FB094506EACB94F72E2989@MN0PR12MB6101.namprd12.prod.outlook.com>

[Public]



> -----Original Message-----
> From: Mark Pearson <mpearson-lenovo@squebb.ca>
> Sent: Thursday, April 13, 2023 11:34
> To: Limonciello, Mario <Mario.Limonciello@amd.com>; Baishan Jiang
> <bjiang400@outlook.com>; Mark Brown <broonie@kernel.org>; Takashi Iwai
> <tiwai@suse.com>; alsa-devel@alsa-project.org
> Subject: Re: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks
> list for acp6x
> 
> 
> On Wed, Apr 12, 2023, at 10:47 AM, Limonciello, Mario wrote:
> > [Public]
> >
> > Loop Mark Pearson from Lenovo for awareness.
> >
> >> -----Original Message-----
> >> From: Baishan Jiang <bjiang400@outlook.com>
> >> Sent: Wednesday, April 12, 2023 03:41
> >> To: Mark Brown <broonie@kernel.org>; Takashi Iwai <tiwai@suse.com>;
> >> Limonciello, Mario <Mario.Limonciello@amd.com>; alsa-devel@alsa-
> >> project.org
> >> Cc: Baishan Jiang <bjiang400@outlook.com>
> >> Subject: [PATCH v2] ASoC: amd: yc: Add ThinkBook 14 G5+ ARP to quirks
> list
> >> for acp6x
> >>
> >> ThinkBook 14 G5+ ARP uses Ryzen 7735H processor, and has the same
> >> microphone problem as ThinkBook 14 G4+ ARA.
> >>
> >> Adding 21HY to acp6x quirks table enables microphone for ThinkBook
> >> 14 G5+ ARP.
> >>
> >> Signed-off-by: Baishan Jiang <bjiang400@outlook.com>
> >
> > It would be generally preferred for systems to start including the _DSD in
> the
> > BIOS so we can stop growing the quirk list, but if they don't then patches
> like
> > this make sense.
> 
> Ack. I've forwarded to the FW team. Internal ticket is LO-2404.
> 
> Realistically though - I'd recommend still carrying on with the patch. This
> platform isn't in the Linux program and it could take me a while to see if I can
> get them to accept making changes I'm afraid.

Right, I also think the patch makes sense but if you can try to get the BIOS team to
get it added on other newer systems not in the Linux program it could avoid it
in the future for those.

> 
> Mark
> 
> >
> > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> >
> >> ---
> >> V1 -> V2: Fixed signed-off-by format
> >> ---
> >>  sound/soc/amd/yc/acp6x-mach.c | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-
> >> mach.c
> >> index 0acdf0156f07..62d8a8e060d2 100644
> >> --- a/sound/soc/amd/yc/acp6x-mach.c
> >> +++ b/sound/soc/amd/yc/acp6x-mach.c
> >> @@ -178,6 +178,13 @@ static const struct dmi_system_id
> >> yc_acp_quirk_table[] = {
> >>  			DMI_MATCH(DMI_PRODUCT_NAME, "21EN"),
> >>  		}
> >>  	},
> >> +	{
> >> +		.driver_data = &acp6x_card,
> >> +		.matches = {
> >> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> >> +			DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
> >> +		}
> >> +	},
> >>  	{
> >>  		.driver_data = &acp6x_card,
> >>  		.matches = {
> >> --
> >> 2.40.0