From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
"Marcin Ślusarz" <marcin.slusarz@gmail.com>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Len Brown <lenb@kernel.org>
Subject: Re: Crash in acpi_ns_validate_handle triggered by soundwire on Linux 5.10
Date: Wed, 20 Jan 2021 16:28:23 -0600 [thread overview]
Message-ID: <1f0f7273-597e-cdf0-87d1-908e56c13133@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0iapmc8ywuySwexwTagKr89Hj7TPXkAvd_HXMhdLoyyQQ@mail.gmail.com>
>> Linux 5.10 fails to boot on my IceLake laptop, where 5.9 worked fine.
>> I'm not sure whether it's a bug in ACPI or Soundwire subsystem, so I'm
>> sending this to both
>> lists. The W taint flag is because of an unrelated nouveau failure (It
>> was busted on 5.9, and is
>> still on 5.10). Full kernel log down below.
>> It's from a distro kernel, but I can build my own kernel with patches if needed.
>
> Please try to add a check for handle against NULL to
> snd_intel_dsp_check_soundwire() after
>
> handle = ACPI_HANDLE(&pci->dev);
>
> and see if this makes any difference.
>
> This should check handle against NULL anyway, even if it didn't crash later on.
Is there a way you can share the DSDT?
The only thing we do in that sdw_intel_acpi_scan() function is check for
an _ADR and read two _DSD properties. I think it's been 2 years since we
wrote it and never had an issue, never say never I guess...
If you want to bypass this problem for the time being, you can add a
kernel option in /etc/modprobe.d/alsa-base.conf
options snd-intel-dspcfg dsp_driver=1
that will force the use of the HDaudio legacy driver and bypass the
driver autodetection.
next prev parent reply other threads:[~2021-01-20 22:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 19:56 Crash in acpi_ns_validate_handle triggered by soundwire on Linux 5.10 Marcin Ślusarz
2021-01-20 20:34 ` Rafael J. Wysocki
2021-01-20 22:28 ` Pierre-Louis Bossart [this message]
2021-01-21 17:47 ` Marcin Ślusarz
2021-01-27 16:36 ` Marcin Ślusarz
2021-01-27 17:28 ` Pierre-Louis Bossart
2021-01-27 19:18 ` Marcin Ślusarz
2021-01-27 21:52 ` Pierre-Louis Bossart
2021-01-27 22:02 ` Pierre-Louis Bossart
2021-01-28 13:25 ` Marcin Ślusarz
2021-01-28 13:31 ` Rafael J. Wysocki
2021-01-28 12:13 ` Rafael J. Wysocki
2021-01-28 12:39 ` Rafael J. Wysocki
2021-01-28 13:45 ` Marcin Ślusarz
2021-01-28 14:32 ` Marcin Ślusarz
2021-01-29 18:59 ` Marcin Ślusarz
2021-01-29 20:03 ` Marcin Ślusarz
2021-02-01 11:42 ` Rafael J. Wysocki
2021-02-01 12:16 ` Marcin Ślusarz
2021-02-04 12:11 ` Marcin Ślusarz
2021-02-04 12:48 ` Marcin Ślusarz
2021-02-05 15:40 ` [PATCH] soundwire: intel: fix possible crash when no device is detected (was Re: Crash in acpi_ns_validate_handle triggered by soundwire on Linux 5.10) Marcin Ślusarz
2021-02-05 16:16 ` Pierre-Louis Bossart
2021-02-08 12:01 ` [PATCH 1/2] soundwire: intel: fix possible crash when no device is detected Marcin Ślusarz
2021-02-08 12:01 ` [PATCH 2/2] ACPICA: update documentation of acpi_walk_namespace Marcin Ślusarz
2021-02-08 12:43 ` Rafael J. Wysocki
2021-02-08 12:37 ` [PATCH 1/2] soundwire: intel: fix possible crash when no device is detected Rafael J. Wysocki
2021-02-10 23:15 ` Pierre-Louis Bossart
2021-02-11 5:20 ` Vinod Koul
2021-01-28 13:29 ` Crash in acpi_ns_validate_handle triggered by soundwire on Linux 5.10 Marcin Ślusarz
2021-01-28 13:36 ` Rafael J. Wysocki
2021-01-25 18:38 ` Salvatore Bonaccorso
2021-01-25 19:26 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f0f7273-597e-cdf0-87d1-908e56c13133@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).