* [patch] ASoC: Intel: sst-firmware: missing curly braces (harmless)
@ 2014-02-21 8:52 Dan Carpenter
2014-02-25 23:46 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-02-21 8:52 UTC (permalink / raw)
To: Liam Girdwood
Cc: alsa-devel, Takashi Iwai, kernel-janitors, Vinod Koul, Mark Brown
There were some curly braces intended here, but the code actually
works the same either way so it's not a bug.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/intel/sst-firmware.c b/sound/soc/intel/sst-firmware.c
index b6f9b5ecb66a..51b56a473bc5 100644
--- a/sound/soc/intel/sst-firmware.c
+++ b/sound/soc/intel/sst-firmware.c
@@ -293,7 +293,7 @@ static int block_module_prepare(struct sst_module *module)
/* enable each block so that's it'e ready for module P/S data */
list_for_each_entry(block, &module->block_list, module_list) {
- if (block->ops && block->ops->enable)
+ if (block->ops && block->ops->enable) {
ret = block->ops->enable(block);
if (ret < 0) {
dev_err(module->dsp->dev,
@@ -301,6 +301,7 @@ static int block_module_prepare(struct sst_module *module)
block->type, block->index);
goto err;
}
+ }
}
return ret;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] ASoC: Intel: sst-firmware: missing curly braces (harmless)
2014-02-21 8:52 [patch] ASoC: Intel: sst-firmware: missing curly braces (harmless) Dan Carpenter
@ 2014-02-25 23:46 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-02-25 23:46 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, Vinod Koul,
alsa-devel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
On Fri, Feb 21, 2014 at 11:52:40AM +0300, Dan Carpenter wrote:
> There were some curly braces intended here, but the code actually
> works the same either way so it's not a bug.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-25 23:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-21 8:52 [patch] ASoC: Intel: sst-firmware: missing curly braces (harmless) Dan Carpenter
2014-02-25 23:46 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).