[PATCH 1/2] ASoC: fsl: Separation of the main audio options and boards

[PATCH 1/2] ASoC: fsl: Separation of the main audio options and boards

[Alexander Shiyan]

This patch provide separation of the main audio options and boards.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 sound/soc/fsl/Kconfig | 36 ++++++++++++++++++++++--------------
 1 file changed, 22 insertions(+), 14 deletions(-)

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index 07f8f14..ecc1092 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -1,3 +1,5 @@
+menu "SoC Audio for Freescale CPUs"
+
 config SND_SOC_FSL_SAI
 	tristate
 	select SND_SOC_GENERIC_DMAENGINE_PCM
@@ -14,13 +16,27 @@ config SND_SOC_FSL_ESAI
 config SND_SOC_FSL_UTILS
 	tristate
 
-menuconfig SND_POWERPC_SOC
+config SND_SOC_IMX_PCM_DMA
+	tristate
+	select SND_SOC_GENERIC_DMAENGINE_PCM
+
+config SND_SOC_IMX_AUDMUX
+	tristate
+
+config SND_POWERPC_SOC
 	tristate "SoC Audio for Freescale PowerPC CPUs"
 	depends on FSL_SOC || PPC_MPC52xx
 	help
 	  Say Y or M if you want to add support for codecs attached to
 	  the PowerPC CPUs.
 
+config SND_IMX_SOC
+	tristate "SoC Audio for Freescale i.MX CPUs"
+	depends on ARCH_MXC || COMPILE_TEST
+	help
+	  Say Y or M if you want to add support for codecs attached to
+	  the i.MX CPUs.
+
 if SND_POWERPC_SOC
 
 config SND_MPC52xx_DMA
@@ -29,6 +45,8 @@ config SND_MPC52xx_DMA
 config SND_SOC_POWERPC_DMA
 	tristate
 
+comment "SoC Audio support for Freescale PPC boards:"
+
 config SND_SOC_MPC8610_HPCD
 	tristate "ALSA SoC support for the Freescale MPC8610 HPCD board"
 	# I2C is necessary for the CS4270 driver
@@ -106,13 +124,6 @@ config SND_MPC52xx_SOC_EFIKA
 
 endif # SND_POWERPC_SOC
 
-menuconfig SND_IMX_SOC
-	tristate "SoC Audio for Freescale i.MX CPUs"
-	depends on ARCH_MXC || COMPILE_TEST
-	help
-	  Say Y or M if you want to add support for codecs attached to
-	  the i.MX CPUs.
-
 if SND_IMX_SOC
 
 config SND_SOC_IMX_SSI
@@ -122,12 +133,7 @@ config SND_SOC_IMX_PCM_FIQ
 	tristate
 	select FIQ
 
-config SND_SOC_IMX_PCM_DMA
-	tristate
-	select SND_SOC_GENERIC_DMAENGINE_PCM
-
-config SND_SOC_IMX_AUDMUX
-	tristate
+comment "SoC Audio support for Freescale i.MX boards:"
 
 config SND_MXC_SOC_WM1133_EV1
 	tristate "Audio on the i.MX31ADS with WM1133-EV1 fitted"
@@ -219,3 +225,5 @@ config SND_SOC_IMX_MC13783
 	select SND_SOC_IMX_PCM_DMA
 
 endif # SND_IMX_SOC
+
+endmenu
-- 
1.8.3.2

[PATCH 2/2] ASoC: fsl: Allow to select individual common options

[Alexander Shiyan]

This patch allow to select individual common sound options and
as a result allow using sound cards/codecs based on DT description.

Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
 sound/soc/fsl/Kconfig | 23 ++++++++++++++++++++---
 1 file changed, 20 insertions(+), 3 deletions(-)

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index ecc1092..ed74c19 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -1,14 +1,26 @@
 menu "SoC Audio for Freescale CPUs"
 
+comment "Common SoC Audio options for Freescale CPUs:"
+
 config SND_SOC_FSL_SAI
 	tristate
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 
 config SND_SOC_FSL_SSI
-	tristate
+	tristate "Synchronous Serial Interface module support"
+	help
+	  Say Y if you want to add Synchronous Serial Interface (SSI)
+	  support for the Freescale CPUs.
+	  This option is only useful for out-of-tree drivers since
+	  in-tree drivers select it automatically.
 
 config SND_SOC_FSL_SPDIF
-	tristate
+	tristate "Sony/Philips Digital Interface module support"
+	help
+	  Say Y if you want to add Sony/Philips Digital Interface (SPDIF)
+	  support for the Freescale CPUs.
+	  This option is only useful for out-of-tree drivers since
+	  in-tree drivers select it automatically.
 
 config SND_SOC_FSL_ESAI
 	tristate
@@ -21,7 +33,12 @@ config SND_SOC_IMX_PCM_DMA
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 
 config SND_SOC_IMX_AUDMUX
-	tristate
+	tristate "Digital Audio Mux module support"
+	help
+	  Say Y if you want to add Digital Audio Mux (AUDMUX) support
+	  for the ARM i.MX CPUs.
+	  This option is only useful for out-of-tree drivers since
+	  in-tree drivers select it automatically.
 
 config SND_POWERPC_SOC
 	tristate "SoC Audio for Freescale PowerPC CPUs"
-- 
1.8.3.2

Re: [PATCH 1/2] ASoC: fsl: Separation of the main audio options and boards

[Shawn Guo]

On Wed, Feb 05, 2014 at 09:31:51PM +0400, Alexander Shiyan wrote:
> This patch provide separation of the main audio options and boards.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  sound/soc/fsl/Kconfig | 36 ++++++++++++++++++++++--------------
>  1 file changed, 22 insertions(+), 14 deletions(-)
> 
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index 07f8f14..ecc1092 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -1,3 +1,5 @@
> +menu "SoC Audio for Freescale CPUs"
> +
>  config SND_SOC_FSL_SAI
>  	tristate
>  	select SND_SOC_GENERIC_DMAENGINE_PCM
> @@ -14,13 +16,27 @@ config SND_SOC_FSL_ESAI
>  config SND_SOC_FSL_UTILS
>  	tristate
>  
> -menuconfig SND_POWERPC_SOC
> +config SND_SOC_IMX_PCM_DMA
> +	tristate
> +	select SND_SOC_GENERIC_DMAENGINE_PCM
> +
> +config SND_SOC_IMX_AUDMUX
> +	tristate
> +
> +config SND_POWERPC_SOC
>  	tristate "SoC Audio for Freescale PowerPC CPUs"
>  	depends on FSL_SOC || PPC_MPC52xx
>  	help
>  	  Say Y or M if you want to add support for codecs attached to
>  	  the PowerPC CPUs.
>  
> +config SND_IMX_SOC
> +	tristate "SoC Audio for Freescale i.MX CPUs"
> +	depends on ARCH_MXC || COMPILE_TEST
> +	help
> +	  Say Y or M if you want to add support for codecs attached to
> +	  the i.MX CPUs.
> +
>  if SND_POWERPC_SOC
>  
>  config SND_MPC52xx_DMA
> @@ -29,6 +45,8 @@ config SND_MPC52xx_DMA
>  config SND_SOC_POWERPC_DMA
>  	tristate
>  
> +comment "SoC Audio support for Freescale PPC boards:"
> +
>  config SND_SOC_MPC8610_HPCD
>  	tristate "ALSA SoC support for the Freescale MPC8610 HPCD board"
>  	# I2C is necessary for the CS4270 driver
> @@ -106,13 +124,6 @@ config SND_MPC52xx_SOC_EFIKA
>  
>  endif # SND_POWERPC_SOC
>  
> -menuconfig SND_IMX_SOC
> -	tristate "SoC Audio for Freescale i.MX CPUs"
> -	depends on ARCH_MXC || COMPILE_TEST
> -	help
> -	  Say Y or M if you want to add support for codecs attached to
> -	  the i.MX CPUs.
> -
>  if SND_IMX_SOC
>  
>  config SND_SOC_IMX_SSI
> @@ -122,12 +133,7 @@ config SND_SOC_IMX_PCM_FIQ
>  	tristate
>  	select FIQ

Hmm, why do you choose to have SND_SOC_IMX_SSI and SND_SOC_IMX_PCM_FIQ
still stay in board section?

Shawn

>  
> -config SND_SOC_IMX_PCM_DMA
> -	tristate
> -	select SND_SOC_GENERIC_DMAENGINE_PCM
> -
> -config SND_SOC_IMX_AUDMUX
> -	tristate
> +comment "SoC Audio support for Freescale i.MX boards:"
>  
>  config SND_MXC_SOC_WM1133_EV1
>  	tristate "Audio on the i.MX31ADS with WM1133-EV1 fitted"
> @@ -219,3 +225,5 @@ config SND_SOC_IMX_MC13783
>  	select SND_SOC_IMX_PCM_DMA
>  
>  endif # SND_IMX_SOC
> +
> +endmenu
> -- 
> 1.8.3.2
> 

Re: [PATCH 2/2] ASoC: fsl: Allow to select individual common options

[Shawn Guo]

On Wed, Feb 05, 2014 at 09:31:52PM +0400, Alexander Shiyan wrote:
> This patch allow to select individual common sound options and
> as a result allow using sound cards/codecs based on DT description.
> 
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  sound/soc/fsl/Kconfig | 23 ++++++++++++++++++++---
>  1 file changed, 20 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> index ecc1092..ed74c19 100644
> --- a/sound/soc/fsl/Kconfig
> +++ b/sound/soc/fsl/Kconfig
> @@ -1,14 +1,26 @@
>  menu "SoC Audio for Freescale CPUs"
>  
> +comment "Common SoC Audio options for Freescale CPUs:"
> +
>  config SND_SOC_FSL_SAI
>  	tristate
>  	select SND_SOC_GENERIC_DMAENGINE_PCM

Why do you skip SND_SOC_FSL_SAI and SND_SOC_FSL_ESAI for the change?

>  
>  config SND_SOC_FSL_SSI
> -	tristate
> +	tristate "Synchronous Serial Interface module support"
> +	help
> +	  Say Y if you want to add Synchronous Serial Interface (SSI)
> +	  support for the Freescale CPUs.
> +	  This option is only useful for out-of-tree drivers since
> +	  in-tree drivers select it automatically.
>  
>  config SND_SOC_FSL_SPDIF
> -	tristate
> +	tristate "Sony/Philips Digital Interface module support"
> +	help
> +	  Say Y if you want to add Sony/Philips Digital Interface (SPDIF)
> +	  support for the Freescale CPUs.
> +	  This option is only useful for out-of-tree drivers since
> +	  in-tree drivers select it automatically.
>  
>  config SND_SOC_FSL_ESAI
>  	tristate
> @@ -21,7 +33,12 @@ config SND_SOC_IMX_PCM_DMA
>  	select SND_SOC_GENERIC_DMAENGINE_PCM

Doesn't the simple card driver need this to work on IMX?

Shawn

>  
>  config SND_SOC_IMX_AUDMUX
> -	tristate
> +	tristate "Digital Audio Mux module support"
> +	help
> +	  Say Y if you want to add Digital Audio Mux (AUDMUX) support
> +	  for the ARM i.MX CPUs.
> +	  This option is only useful for out-of-tree drivers since
> +	  in-tree drivers select it automatically.
>  
>  config SND_POWERPC_SOC
>  	tristate "SoC Audio for Freescale PowerPC CPUs"
> -- 
> 1.8.3.2
> 

Re: [PATCH 1/2] ASoC: fsl: Separation of the main audio options and boards

[Alexander Shiyan]

Hello.

> On Wed, Feb 05, 2014 at 09:31:51PM +0400, Alexander Shiyan wrote:
> > This patch provide separation of the main audio options and boards.
> > 
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> >  sound/soc/fsl/Kconfig | 36 ++++++++++++++++++++++--------------
> >  1 file changed, 22 insertions(+), 14 deletions(-)
> > 
> > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
...
> >  if SND_IMX_SOC
> >  
> >  config SND_SOC_IMX_SSI
> > @@ -122,12 +133,7 @@ config SND_SOC_IMX_PCM_FIQ
> >  	tristate
> >  	select FIQ
> 
> Hmm, why do you choose to have SND_SOC_IMX_SSI and SND_SOC_IMX_PCM_FIQ
> still stay in board section?

SND_SOC_IMX_SSI is used for ATAGS boards only, and selected for each individual
platform driver, so there are no need to select this option especially.

For SND_SOC_IMX_PCM_FIQ I just not imagine yet how to describe this option
in Kconfig ;) In any case, it can be done later if the total change concept looks good.

Thanks.

---

Re: [PATCH 2/2] ASoC: fsl: Allow to select individual common options

[Alexander Shiyan]

Hello.

> On Wed, Feb 05, 2014 at 09:31:52PM +0400, Alexander Shiyan wrote:
> > This patch allow to select individual common sound options and
> > as a result allow using sound cards/codecs based on DT description.
> > 
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> >  sound/soc/fsl/Kconfig | 23 ++++++++++++++++++++---
> >  1 file changed, 20 insertions(+), 3 deletions(-)
> > 
> > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> > index ecc1092..ed74c19 100644
> > --- a/sound/soc/fsl/Kconfig
> > +++ b/sound/soc/fsl/Kconfig
> > @@ -1,14 +1,26 @@
> >  menu "SoC Audio for Freescale CPUs"
> >  
> > +comment "Common SoC Audio options for Freescale CPUs:"
> > +
> >  config SND_SOC_FSL_SAI
> >  	tristate
> >  	select SND_SOC_GENERIC_DMAENGINE_PCM
> 
> Why do you skip SND_SOC_FSL_SAI and SND_SOC_FSL_ESAI for the change?

My comments here are the same as for the patch 1/2.

...
> >  config SND_SOC_FSL_ESAI
> >  	tristate
> > @@ -21,7 +33,12 @@ config SND_SOC_IMX_PCM_DMA
> >  	select SND_SOC_GENERIC_DMAENGINE_PCM
> 
> Doesn't the simple card driver need this to work on IMX?

Simple card driver does not work for i.MX at now due to some other issues
which should be resolved in separate patches for that driver.
Just one example:
http://mailman.alsa-project.org/pipermail/alsa-devel/2014-January/070697.html

Thanks.
---

Re: [PATCH 1/2] ASoC: fsl: Separation of the main audio options and boards

[Alexander Shiyan]

Понедельник, 10 февраля 2014, 10:29 +04:00 от Alexander Shiyan <shc_work@mail.ru>:
> Hello.
> 
> > On Wed, Feb 05, 2014 at 09:31:51PM +0400, Alexander Shiyan wrote:
> > > This patch provide separation of the main audio options and boards.
> > > 
> > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > ---
> > >  sound/soc/fsl/Kconfig | 36 ++++++++++++++++++++++--------------
> > >  1 file changed, 22 insertions(+), 14 deletions(-)
> > > 
> > > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> ...
> > >  if SND_IMX_SOC
> > >  
> > >  config SND_SOC_IMX_SSI
> > > @@ -122,12 +133,7 @@ config SND_SOC_IMX_PCM_FIQ
> > >  	tristate
> > >  	select FIQ
> > 
> > Hmm, why do you choose to have SND_SOC_IMX_SSI and SND_SOC_IMX_PCM_FIQ
> > still stay in board section?
> 
> SND_SOC_IMX_SSI is used for ATAGS boards only, and selected for each individual
> platform driver, so there are no need to select this option especially.
> 
> For SND_SOC_IMX_PCM_FIQ I just not imagine yet how to describe this option
> in Kconfig ;) In any case, it can be done later if the total change concept looks good.

Ping.

---
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH 1/2] ASoC: fsl: Separation of the main audio options and boards

[Shawn Guo]

On Thu, Feb 27, 2014 at 08:56:58PM +0400, Alexander Shiyan wrote:
> Понедельник, 10 февраля 2014, 10:29 +04:00 от Alexander Shiyan <shc_work@mail.ru>:
> > Hello.
> > 
> > > On Wed, Feb 05, 2014 at 09:31:51PM +0400, Alexander Shiyan wrote:
> > > > This patch provide separation of the main audio options and boards.
> > > > 
> > > > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > > > ---
> > > >  sound/soc/fsl/Kconfig | 36 ++++++++++++++++++++++--------------
> > > >  1 file changed, 22 insertions(+), 14 deletions(-)
> > > > 
> > > > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> > ...
> > > >  if SND_IMX_SOC
> > > >  
> > > >  config SND_SOC_IMX_SSI
> > > > @@ -122,12 +133,7 @@ config SND_SOC_IMX_PCM_FIQ
> > > >  	tristate
> > > >  	select FIQ
> > > 
> > > Hmm, why do you choose to have SND_SOC_IMX_SSI and SND_SOC_IMX_PCM_FIQ
> > > still stay in board section?
> > 
> > SND_SOC_IMX_SSI is used for ATAGS boards only, and selected for each individual
> > platform driver, so there are no need to select this option especially.
> > 
> > For SND_SOC_IMX_PCM_FIQ I just not imagine yet how to describe this option
> > in Kconfig ;) In any case, it can be done later if the total change concept looks good.
> 
> Ping.

I'm fine with it.

Shawn

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel