* [PATCH] ASoC: si476x: Fix IO setup
@ 2014-03-04 8:41 Lars-Peter Clausen
2014-03-10 11:26 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2014-03-04 8:41 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: Andrey Smirnov, alsa-devel, Xiubo Li, Lars-Peter Clausen
The si476x is a MFD device and the CODEC driver is using the regmap struct of
the parent device, hence automatic IO setup will not work and we need to
manually call snd_soc_codec_set_cache_io(). The issue was introduced commit
d6173df35f ("ASoC: si476x: Remove custom register I/O implementation")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
sound/soc/codecs/si476x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/si476x.c b/sound/soc/codecs/si476x.c
index 52e7cb0..fa2b8e0 100644
--- a/sound/soc/codecs/si476x.c
+++ b/sound/soc/codecs/si476x.c
@@ -210,7 +210,7 @@ out:
static int si476x_codec_probe(struct snd_soc_codec *codec)
{
codec->control_data = dev_get_regmap(codec->dev->parent, NULL);
- return 0;
+ return snd_soc_codec_set_cache_io(codec, 0, 0, SND_SOC_REGMAP);
}
static struct snd_soc_dai_ops si476x_dai_ops = {
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: si476x: Fix IO setup
2014-03-04 8:41 [PATCH] ASoC: si476x: Fix IO setup Lars-Peter Clausen
@ 2014-03-10 11:26 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-03-10 11:26 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: Andrey Smirnov, alsa-devel, Xiubo Li, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 501 bytes --]
On Tue, Mar 04, 2014 at 09:41:53AM +0100, Lars-Peter Clausen wrote:
> The si476x is a MFD device and the CODEC driver is using the regmap struct of
> the parent device, hence automatic IO setup will not work and we need to
> manually call snd_soc_codec_set_cache_io(). The issue was introduced commit
> d6173df35f ("ASoC: si476x: Remove custom register I/O implementation")
Applied, thanks. Please if you're listing which commit is being fixed
do it using a Fixes tag - it makes it easier to apply.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-10 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-04 8:41 [PATCH] ASoC: si476x: Fix IO setup Lars-Peter Clausen
2014-03-10 11:26 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).