[PATCH 1/2] ASoC: ak5386: Add regulators to documentation and fix sparse warning

[PATCH 1/2] ASoC: ak5386: Add regulators to documentation and fix sparse warning

[Daniel Mack]

Document the newly added regulators to the DT binding document.

Also, "static const char const *x" is not identical to "static const
char * const x", which sparse now complains about. Fix it.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 Documentation/devicetree/bindings/sound/ak5386.txt | 4 ++++
 sound/soc/codecs/ak5386.c                          | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/ak5386.txt b/Documentation/devicetree/bindings/sound/ak5386.txt
index dc3914f..ec3df3a 100644
--- a/Documentation/devicetree/bindings/sound/ak5386.txt
+++ b/Documentation/devicetree/bindings/sound/ak5386.txt
@@ -10,10 +10,14 @@ Optional properties:
 
   - reset-gpio : a GPIO spec for the reset/power down pin.
 		 If specified, it will be deasserted at probe time.
+  - va-supply : a regulator spec, providing 5.0V
+  - vd-supply : a regulator spec, providing 3.3V
 
 Example:
 
 spdif: ak5386@0 {
 	compatible = "asahi-kasei,ak5386";
 	reset-gpio = <&gpio0 23>;
+	va-supply = <&vdd_5v0_reg>;
+	vd-supply = <&vdd_3v3_reg>;
 };
diff --git a/sound/soc/codecs/ak5386.c b/sound/soc/codecs/ak5386.c
index a30be5c..8107a1c 100644
--- a/sound/soc/codecs/ak5386.c
+++ b/sound/soc/codecs/ak5386.c
@@ -19,7 +19,7 @@
 #include <sound/pcm.h>
 #include <sound/initval.h>
 
-static const char const *supply_names[] = {
+static const char * const supply_names[] = {
 	"va", "vd"
 };
 
-- 
1.8.5.3

[PATCH 2/2] ASoC: ak4104: Add regulator to documentation

[Daniel Mack]

Add the 3v3 supply to Documentation/devicetree/bindings/sound/ak4104.txt.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 Documentation/devicetree/bindings/sound/ak4104.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/ak4104.txt b/Documentation/devicetree/bindings/sound/ak4104.txt
index b902ee3..deca5e1 100644
--- a/Documentation/devicetree/bindings/sound/ak4104.txt
+++ b/Documentation/devicetree/bindings/sound/ak4104.txt
@@ -8,6 +8,8 @@ Required properties:
 
   - reg : The chip select number on the SPI bus
 
+  - vdd-supply : A regulator node, providing 2.7V - 3.6V
+
 Optional properties:
 
   - reset-gpio : a GPIO spec for the reset pin. If specified, it will be
@@ -19,4 +21,5 @@ spdif: ak4104@0 {
 	compatible = "asahi-kasei,ak4104";
 	reg = <0>;
 	spi-max-frequency = <5000000>;
+	vdd-supply = <&vdd_3v3_reg>;
 };
-- 
1.8.5.3

Re: [PATCH 1/2] ASoC: ak5386: Add regulators to documentation and fix sparse warning

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 351 bytes --]

On Fri, Mar 28, 2014 at 07:05:04PM +0100, Daniel Mack wrote:
> Document the newly added regulators to the DT binding document.
> 
> Also, "static const char const *x" is not identical to "static const
> char * const x", which sparse now complains about. Fix it.

Applied, though this should really have been two patches as there's no
overlap.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 2/2] ASoC: ak4104: Add regulator to documentation

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 188 bytes --]

On Fri, Mar 28, 2014 at 07:05:05PM +0100, Daniel Mack wrote:
> Add the 3v3 supply to Documentation/devicetree/bindings/sound/ak4104.txt.

Applied, thanks (changelog is slightly wrong...).

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 1/2] ASoC: ak5386: Add regulators to documentation and fix sparse warning

[Daniel Mack]

[-- Attachment #1.1: Type: text/plain, Size: 598 bytes --]

On 03/29/2014 11:17 AM, Mark Brown wrote:
> On Fri, Mar 28, 2014 at 07:05:04PM +0100, Daniel Mack wrote:
>> Document the newly added regulators to the DT binding document.
>>
>> Also, "static const char const *x" is not identical to "static const
>> char * const x", which sparse now complains about. Fix it.
> 
> Applied, though this should really have been two patches as there's no
> overlap.
> 

Hmm, for some reason, this patch didn't make it to mainline yet. Same
for another one that patches the same file which I sent the same day.
Want me to resend?


Thanks,
Daniel



[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: [PATCH 1/2] ASoC: ak5386: Add regulators to documentation and fix sparse warning

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 363 bytes --]

On Wed, Jun 18, 2014 at 05:12:49PM +0200, Daniel Mack wrote:

> Hmm, for some reason, this patch didn't make it to mainline yet. Same
> for another one that patches the same file which I sent the same day.
> Want me to resend?

It's probably poor network connectivity to kernel.org at the time I
applied them but I can't tell any more.  They should be there now.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]