* [PATCH] ASoC: rcar: mark device data as constant
@ 2015-03-31 18:35 Uwe Kleine-König
2015-04-01 9:28 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2015-03-31 18:35 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, alsa-devel
Cc: Oder Chiou, Bard Liao, Fabian Frederick, kernel
A driver's device data should and can be const. This is a follow-up on
commit 33187fb4a203 (ASoC: rsnd: constify of_device_id array) which
marked the of_device_id as const.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
This is also patch 4 of my series[1] which degraded to this hunk when
rebasing to next because all the other changes were already addressed by
Fabian.
Best regards
Uwe
[1] http://thread.gmane.org/gmane.linux.alsa.devel/136241/
sound/soc/sh/rcar/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c
index 3d8e4d60c83d..9f48d75fa992 100644
--- a/sound/soc/sh/rcar/core.c
+++ b/sound/soc/sh/rcar/core.c
@@ -99,11 +99,11 @@
#define RSND_RATES SNDRV_PCM_RATE_8000_96000
#define RSND_FMTS (SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S16_LE)
-static struct rsnd_of_data rsnd_of_data_gen1 = {
+static const struct rsnd_of_data rsnd_of_data_gen1 = {
.flags = RSND_GEN1,
};
-static struct rsnd_of_data rsnd_of_data_gen2 = {
+static const struct rsnd_of_data rsnd_of_data_gen2 = {
.flags = RSND_GEN2,
};
--
2.1.4
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: rcar: mark device data as constant
2015-03-31 18:35 [PATCH] ASoC: rcar: mark device data as constant Uwe Kleine-König
@ 2015-04-01 9:28 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-04-01 9:28 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Oder Chiou, alsa-devel, Liam Girdwood, Fabian Frederick, kernel,
Bard Liao
[-- Attachment #1.1: Type: text/plain, Size: 406 bytes --]
On Tue, Mar 31, 2015 at 08:35:09PM +0200, Uwe Kleine-König wrote:
> A driver's device data should and can be const. This is a follow-up on
> commit 33187fb4a203 (ASoC: rsnd: constify of_device_id array) which
> marked the of_device_id as const.
Applied, thanks. Please CC maintainers on patches and try to avoid
CCing people who aren't really relevant - the latter helps cut down on
mail volume.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-01 9:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-31 18:35 [PATCH] ASoC: rcar: mark device data as constant Uwe Kleine-König
2015-04-01 9:28 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).