alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: cs4271: Increase delay time after reset
@ 2015-04-02  8:17 pascal.huerst
  2015-04-02 14:15 ` Brian Austin
  2015-04-02 17:15 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: pascal.huerst @ 2015-04-02  8:17 UTC (permalink / raw)
  To: patch
  Cc: alsa-devel, lgirdwood, tiwai, brian.austin, Paul.Handrigan,
	broonie, Pascal Huerst

From: Pascal Huerst <pascal.huerst@gmail.com>

The delay time after a reset in the codec probe callback was too short,
and did not work on certain hw because the codec needs more time to
power on. This increases the delay time from 1us to 1ms.

Signed-off-by: Pascal Huerst <pascal.huerst@gmail.com>
---
 sound/soc/codecs/cs4271.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c
index 7d3a6ac..e770ee6 100644
--- a/sound/soc/codecs/cs4271.c
+++ b/sound/soc/codecs/cs4271.c
@@ -561,10 +561,10 @@ static int cs4271_codec_probe(struct snd_soc_codec *codec)
 	if (gpio_is_valid(cs4271->gpio_nreset)) {
 		/* Reset codec */
 		gpio_direction_output(cs4271->gpio_nreset, 0);
-		udelay(1);
+		mdelay(1);
 		gpio_set_value(cs4271->gpio_nreset, 1);
 		/* Give the codec time to wake up */
-		udelay(1);
+		mdelay(1);
 	}
 
 	ret = regmap_update_bits(cs4271->regmap, CS4271_MODE2,
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: cs4271: Increase delay time after reset
  2015-04-02  8:17 [PATCH] ASoC: cs4271: Increase delay time after reset pascal.huerst
@ 2015-04-02 14:15 ` Brian Austin
  2015-04-02 17:15 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Brian Austin @ 2015-04-02 14:15 UTC (permalink / raw)
  To: Pascal Huerst
  Cc: brian.austin, patch, tiwai, alsa-devel, Paul.Handrigan,
	lgirdwood, broonie


On Thu, 2 Apr 2015, pascal.huerst@gmail.com wrote:

> From: Pascal Huerst <pascal.huerst@gmail.com>
> 
> The delay time after a reset in the codec probe callback was too short,
> and did not work on certain hw because the codec needs more time to
> power on. This increases the delay time from 1us to 1ms.
> 
> Signed-off-by: Pascal Huerst <pascal.huerst@gmail.com>
Thanks for the patch.

Acked-by: Brian Austin <brian.austin@cirrus.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: cs4271: Increase delay time after reset
  2015-04-02  8:17 [PATCH] ASoC: cs4271: Increase delay time after reset pascal.huerst
  2015-04-02 14:15 ` Brian Austin
@ 2015-04-02 17:15 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2015-04-02 17:15 UTC (permalink / raw)
  To: pascal.huerst
  Cc: alsa-devel, patch, lgirdwood, tiwai, brian.austin, Paul.Handrigan


[-- Attachment #1.1: Type: text/plain, Size: 353 bytes --]

On Thu, Apr 02, 2015 at 10:17:40AM +0200, pascal.huerst@gmail.com wrote:
> From: Pascal Huerst <pascal.huerst@gmail.com>
> 
> The delay time after a reset in the codec probe callback was too short,
> and did not work on certain hw because the codec needs more time to
> power on. This increases the delay time from 1us to 1ms.

Applied, thanks.

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-04-02 17:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-02  8:17 [PATCH] ASoC: cs4271: Increase delay time after reset pascal.huerst
2015-04-02 14:15 ` Brian Austin
2015-04-02 17:15 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).