Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream() - Pierre-Louis Bossart

From: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>
To: "Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
	"Vinod Koul" <vkoul@kernel.org>,
	"Mark Brown" <broonie@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"bgoswami@codeaurora.org" <bgoswami@codeaurora.org>,
	"plai@codeaurora.org" <plai@codeaurora.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"spapothi@codeaurora.org" <spapothi@codeaurora.org>
Subject: Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream()
Date: Wed, 9 Oct 2019 09:29:39 -0500	[thread overview]
Message-ID: <53bb3105-8e85-a972-fce8-a7911ae4d461@linux.intel.com> (raw)
Message-ID: <20191009142939.wqDQpajTCcTLZexMmhK2X08zJYOBJ-hjWjA2aRoA2Dk@z> (raw)
In-Reply-To: <5e08f822-3507-6c69-5d83-4ce2a9f5c04f@linaro.org>

On 10/9/19 3:32 AM, Srinivas Kandagatla wrote:
> Hi Pierre,
> 
> On 14/08/2019 15:09, Pierre-Louis Bossart wrote:
>>
>>
>> On 8/13/19 11:11 PM, Vinod Koul wrote:
>>> On 13-08-19, 20:58, Mark Brown wrote:
>>>> On Tue, Aug 13, 2019 at 02:38:53PM -0500, Pierre-Louis Bossart wrote:
>>>>
>>>>> Indeed. I don't have a full understanding of that part to be 
>>>>> honest, nor why
>>>>> we need something SoundWire-specific. We already abused the 
>>>>> set_tdm_slot API
>>>>> to store an HDaudio stream, now we have a rather confusing stream
>>>>> information for SoundWire and I have about 3 other 'stream' 
>>>>> contexts in
>>>>> SOF... I am still doing basic cleanups but this has been on my 
>>>>> radar for a
>>>>> while.
>>>>
>>>> There is something to be said for not abusing the TDM slot API if it 
>>>> can
>>>> make things clearer by using bus-idiomatic mechanisms, but it does mean
>>>> everything needs to know about each individual bus :/ .
>>>
>>> Here ASoC doesn't need to know about sdw bus. As Srini explained, this
>>> helps in the case for him to get the stream context and set the stream
>>> context from the machine driver.
>>>
>>> Nothing else is expected to be done from this API. We already do a set
>>> using snd_soc_dai_set_sdw_stream(). Here we add the 
>>> snd_soc_dai_get_sdw_stream() to query
>>
>> I didn't see a call to snd_soc_dai_set_sdw_stream() in Srini's code?
> 
> 
> There is a snd_soc_dai_get_sdw_stream() to get stream context and we add 
> slave streams(amplifier in this case) to that context using 
> sdw_stream_add_slave() in machine driver[1].
> 
> Without this helper there is no way to link slave streams to stream 
> context in non dai based setup like smart speaker amplifiers.
> 
> Currently this driver is blocked on this patch, If you think there are 
> other ways to do this, am happy to try them out.

So to be clear, you are *not* using snd_soc_dai_set_sdw_stream?

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel