From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Cc: "Kuppuswamy Sathyanarayanan"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
linux-aspeed@lists.ozlabs.org,
"David Daney" <david.daney@cavium.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
alsa-devel@alsa-project.org, "Peter Tyser" <ptyser@xes-inc.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@st.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Fabio Estevam" <festevam@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
"Marek Vasut" <marek.vasut+renesas@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Kevin Hilman" <khilman@kernel.org>,
"Michal Simek" <michal.simek@xilinx.com>,
"Marek Behun" <marek.behun@nic.cz>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
bcm-kernel-feedback-list@broadcom.com,
"Joel Stanley" <joel@jms.id.au>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Bamvor Jian Zhang" <bamv2005@gmail.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
linux-pwm@vger.kernel.org,
"Grygorii Strashko" <grygorii.strashko@ti.com>,
"Charles Keepax" <ckeepax@opensource.cirrus.com>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
mazziesaccount@gmail.com, "Ray Jui" <rjui@broadcom.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"William Breathitt Gray" <vilhelm.gray@gmail.com>,
linux-gpio@vger.kernel.org,
"Richard Fitzgerald" <rf@opensource.cirrus.com>,
"Santosh Shilimkar" <ssantosh@kernel.org>,
linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Scott Branden" <sbranden@broadcom.com>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Enrico Weigelt, metux IT consult" <info@metux.net>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
"Thorsten Scherer" <t.scherer@eckelmann.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
patches@opensource.cirrus.com, "Shawn Guo" <shawnguo@kernel.org>
Subject: Re: [alsa-devel] [PATCH v2 2/2] gpio: Use new GPIO_LINE_DIRECTION
Date: Wed, 6 Nov 2019 16:22:26 +0200 [thread overview]
Message-ID: <20191106142226.GB32742@smile.fi.intel.com> (raw)
In-Reply-To: <42f40109e2926bca197b30fd9624c609653b23e5.1573029228.git.matti.vaittinen@fi.rohmeurope.com>
On Wed, Nov 06, 2019 at 10:54:12AM +0200, Matti Vaittinen wrote:
> It's hard for occasional GPIO code reader/writer to know if values 0/1
> equal to IN or OUT. Use defined GPIO_LINE_DIRECTION_IN and
> GPIO_LINE_DIRECTION_OUT to help them out.
>
> NOTE - for gpio-amd-fch and gpio-bd9571mwv:
> This commit also changes the return value for direction get to equal 1
> for direction INPUT. Prior this commit these drivers might have
> returned some other positive value but 1 for INPUT.
> drivers/gpio/gpio-ich.c | 5 ++++-
> drivers/gpio/gpio-merrifield.c | 5 ++++-
> drivers/gpio/gpio-pca953x.c | 5 ++++-
> drivers/gpio/gpio-sch.c | 5 ++++-
> drivers/gpio/gpio-wcove.c | 7 +++++--
Since maintainers seems in favour of this and bloat-o-meter shows no difference
on selected module,
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
for the stuff I'm involved in.
Thanks!
> diff --git a/drivers/gpio/gpio-ich.c b/drivers/gpio/gpio-ich.c
> index 90bf7742f9b0..2f086d0aa1f4 100644
> --- a/drivers/gpio/gpio-ich.c
> +++ b/drivers/gpio/gpio-ich.c
> @@ -159,7 +159,10 @@ static bool ichx_gpio_check_available(struct gpio_chip *gpio, unsigned nr)
>
> static int ichx_gpio_get_direction(struct gpio_chip *gpio, unsigned nr)
> {
> - return ichx_read_bit(GPIO_IO_SEL, nr);
> + if (ichx_read_bit(GPIO_IO_SEL, nr))
> + return GPIO_LINE_DIRECTION_IN;
> +
> + return GPIO_LINE_DIRECTION_OUT;
> }
>
> static int ichx_gpio_direction_input(struct gpio_chip *gpio, unsigned nr)
> diff --git a/drivers/gpio/gpio-merrifield.c b/drivers/gpio/gpio-merrifield.c
> index 2f1e9da81c1e..d4fa6e9560f3 100644
> --- a/drivers/gpio/gpio-merrifield.c
> +++ b/drivers/gpio/gpio-merrifield.c
> @@ -162,7 +162,10 @@ static int mrfld_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
> {
> void __iomem *gpdr = gpio_reg(chip, offset, GPDR);
>
> - return !(readl(gpdr) & BIT(offset % 32));
> + if (readl(gpdr) & BIT(offset % 32))
> + return GPIO_LINE_DIRECTION_OUT;
> +
> + return GPIO_LINE_DIRECTION_IN;
> }
>
> static int mrfld_gpio_set_debounce(struct gpio_chip *chip, unsigned int offset,
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index de5d1383f28d..82122c3c688a 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -449,7 +449,10 @@ static int pca953x_gpio_get_direction(struct gpio_chip *gc, unsigned off)
> if (ret < 0)
> return ret;
>
> - return !!(reg_val & bit);
> + if (reg_val & bit)
> + return GPIO_LINE_DIRECTION_IN;
> +
> + return GPIO_LINE_DIRECTION_OUT;
> }
>
> static void pca953x_gpio_set_multiple(struct gpio_chip *gc,
> diff --git a/drivers/gpio/gpio-sch.c b/drivers/gpio/gpio-sch.c
> index fb143f28c386..c65f35b68202 100644
> --- a/drivers/gpio/gpio-sch.c
> +++ b/drivers/gpio/gpio-sch.c
> @@ -127,7 +127,10 @@ static int sch_gpio_get_direction(struct gpio_chip *gc, unsigned gpio_num)
> {
> struct sch_gpio *sch = gpiochip_get_data(gc);
>
> - return sch_gpio_reg_get(sch, gpio_num, GIO);
> + if (sch_gpio_reg_get(sch, gpio_num, GIO))
> + return GPIO_LINE_DIRECTION_IN;
> +
> + return GPIO_LINE_DIRECTION_OUT;
> }
>
> static const struct gpio_chip sch_gpio_chip = {
> diff --git a/drivers/gpio/gpio-wcove.c b/drivers/gpio/gpio-wcove.c
> index 444fe9e7f04a..8b481b3c1ebe 100644
> --- a/drivers/gpio/gpio-wcove.c
> +++ b/drivers/gpio/gpio-wcove.c
> @@ -170,13 +170,16 @@ static int wcove_gpio_get_direction(struct gpio_chip *chip, unsigned int gpio)
> int ret, reg = to_reg(gpio, CTRL_OUT);
>
> if (reg < 0)
> - return 0;
> + return GPIO_LINE_DIRECTION_OUT;
>
> ret = regmap_read(wg->regmap, reg, &val);
> if (ret)
> return ret;
>
> - return !(val & CTLO_DIR_OUT);
> + if (val & CTLO_DIR_OUT)
> + return GPIO_LINE_DIRECTION_OUT;
> +
> + return GPIO_LINE_DIRECTION_IN;
> }
>
> static int wcove_gpio_get(struct gpio_chip *chip, unsigned int gpio)
--
With Best Regards,
Andy Shevchenko
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-06 15:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 8:51 [alsa-devel] [PATCH v2 0/2] Add definition for GPIO direction Matti Vaittinen
2019-11-06 8:51 ` [alsa-devel] [PATCH v2 1/2] gpio: " Matti Vaittinen
2019-11-07 8:20 ` Linus Walleij
2019-11-06 8:54 ` [alsa-devel] [PATCH v2 2/2] gpio: Use new GPIO_LINE_DIRECTION Matti Vaittinen
2019-11-06 14:22 ` Andy Shevchenko [this message]
2019-11-06 14:43 ` William Breathitt Gray
2019-11-06 17:35 ` Kuppuswamy Sathyanarayanan
2019-11-06 12:08 ` [alsa-devel] [PATCH v2 0/2] Add definition for GPIO direction Sebastian Reichel
2019-11-06 12:25 ` Vaittinen, Matti
2019-11-06 14:24 ` andriy.shevchenko
2019-11-07 8:22 ` Linus Walleij
2019-11-06 14:39 ` William Breathitt Gray
2019-11-06 17:28 ` Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191106142226.GB32742@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexandre.torgue@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@aj.id.au \
--cc=bamv2005@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.daney@cavium.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=info@metux.net \
--cc=joel@jms.id.au \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=marek.behun@nic.cz \
--cc=marek.vasut+renesas@gmail.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mazziesaccount@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=patches@opensource.cirrus.com \
--cc=ptyser@xes-inc.com \
--cc=rf@opensource.cirrus.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t.scherer@eckelmann.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vilhelm.gray@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).