From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "sre@kernel.org" <sre@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"david.daney@cavium.com" <david.daney@cavium.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"sathyanarayanan.kuppuswamy@linux.intel.com"
<sathyanarayanan.kuppuswamy@linux.intel.com>,
"ptyser@xes-inc.com" <ptyser@xes-inc.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"marek.behun@nic.cz" <marek.behun@nic.cz>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"marek.vasut+renesas@gmail.com" <marek.vasut+renesas@gmail.com>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"khilman@kernel.org" <khilman@kernel.org>,
"michal.simek@xilinx.com" <michal.simek@xilinx.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"bamv2005@gmail.com" <bamv2005@gmail.com>,
"joel@jms.id.au" <joel@jms.id.au>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"linux-imx@nxp.com" <linux-imx@nxp.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
"grygorii.strashko@ti.com" <grygorii.strashko@ti.com>,
"ckeepax@opensource.cirrus.com" <ckeepax@opensource.cirrus.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"rjui@broadcom.com" <rjui@broadcom.com>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"vilhelm.gray@gmail.com" <vilhelm.gray@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"rf@opensource.cirrus.com" <rf@opensource.cirrus.com>,
"ssantosh@kernel.org" <ssantosh@kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"sbranden@broadcom.com" <sbranden@broadcom.com>,
"yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"info@metux.net" <info@metux.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"t.scherer@eckelmann.de" <t.scherer@eckelmann.de>,
"ludovic.desroches@microchip.com"
<ludovic.desroches@microchip.com>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"patches@opensource.cirrus.com" <patches@opensource.cirrus.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Subject: Re: [alsa-devel] [PATCH v2 0/2] Add definition for GPIO direction
Date: Wed, 6 Nov 2019 12:25:18 +0000 [thread overview]
Message-ID: <ddcd02cc6c709837a28cae2cbfa672c506927659.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <20191106120846.5bunrqj3uz4khih5@earth.universe>
On Wed, 2019-11-06 at 13:08 +0100, Sebastian Reichel wrote:
> Hi,
>
> On Wed, Nov 06, 2019 at 10:51:06AM +0200, Matti Vaittinen wrote:
> > The patch series adds definitions for GPIO line directions.
> >
> > For occasional GPIO contributor like me it is always a pain to
> > remember
> > whether 1 or 0 was used for GPIO direction INPUT/OUTPUT.
>
> Maybe also update the GPIO drivers in pinctrl?
>
> $ git grep -l gpio_get_direction drivers/pinctrl
> drivers/pinctrl/bcm/pinctrl-bcm2835.c
> drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> drivers/pinctrl/intel/pinctrl-baytrail.c
> drivers/pinctrl/intel/pinctrl-cherryview.c
> drivers/pinctrl/intel/pinctrl-intel.c
> drivers/pinctrl/mediatek/pinctrl-mtk-common.c
> drivers/pinctrl/mediatek/pinctrl-paris.c
> drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
> drivers/pinctrl/pinctrl-amd.c
> drivers/pinctrl/pinctrl-at91.c
> drivers/pinctrl/pinctrl-axp209.c
> drivers/pinctrl/pinctrl-ingenic.c
> drivers/pinctrl/pinctrl-ocelot.c
> drivers/pinctrl/pinctrl-oxnas.c
> drivers/pinctrl/pinctrl-pic32.c
> drivers/pinctrl/pinctrl-pistachio.c
> drivers/pinctrl/pinctrl-rk805.c
> drivers/pinctrl/pinctrl-rockchip.c
> drivers/pinctrl/pinctrl-rza1.c
> drivers/pinctrl/pinctrl-st.c
> drivers/pinctrl/pinctrl-stmfx.c
> drivers/pinctrl/pinctrl-sx150x.c
> drivers/pinctrl/qcom/pinctrl-msm.c
> drivers/pinctrl/stm32/pinctrl-stm32.c
> drivers/pinctrl/vt8500/pinctrl-wmt.c
Ouch. I didn't check from pinctrl but I see those should be converted
as well. I'm a bit short on time right now so if anyone else is
interested I won't mind :)
Luckily the value for IN and OUT is not changed - only the defines were
added - so all of the drivers do not need to be done at once. If no one
else will take the pinctrl part then I can probably do pinctrl patches
for v5.6 cycle.
Br,
Matti Vaittinen
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-11-06 13:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 8:51 [alsa-devel] [PATCH v2 0/2] Add definition for GPIO direction Matti Vaittinen
2019-11-06 8:51 ` [alsa-devel] [PATCH v2 1/2] gpio: " Matti Vaittinen
2019-11-07 8:20 ` Linus Walleij
2019-11-06 8:54 ` [alsa-devel] [PATCH v2 2/2] gpio: Use new GPIO_LINE_DIRECTION Matti Vaittinen
2019-11-06 14:22 ` Andy Shevchenko
2019-11-06 14:43 ` William Breathitt Gray
2019-11-06 17:35 ` Kuppuswamy Sathyanarayanan
2019-11-06 12:08 ` [alsa-devel] [PATCH v2 0/2] Add definition for GPIO direction Sebastian Reichel
2019-11-06 12:25 ` Vaittinen, Matti [this message]
2019-11-06 14:24 ` andriy.shevchenko
2019-11-07 8:22 ` Linus Walleij
2019-11-06 14:39 ` William Breathitt Gray
2019-11-06 17:28 ` Vaittinen, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddcd02cc6c709837a28cae2cbfa672c506927659.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=alexandre.torgue@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@aj.id.au \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bamv2005@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bgolaszewski@baylibre.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=david.daney@cavium.com \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=info@metux.net \
--cc=joel@jms.id.au \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-tegra@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=marek.behun@nic.cz \
--cc=marek.vasut+renesas@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=patches@opensource.cirrus.com \
--cc=ptyser@xes-inc.com \
--cc=rf@opensource.cirrus.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t.scherer@eckelmann.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=vilhelm.gray@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).