alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [alsa-devel] [asoc:for-5.4 438/441] sound/soc/sof/sof-pci-dev.c:136:15: error: 'snd_soc_acpi_intel_cml_machines' undeclared here (not in a function); did you mean 'snd_soc_acpi_intel_cnl_machines'?
@ 2019-11-17  2:02 kbuild test robot
  2019-11-18 15:31 ` Pierre-Louis Bossart
  0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2019-11-17  2:02 UTC (permalink / raw)
  To: Liam Girdwood; +Cc: alsa-devel, Mark Brown, kbuild-all, Pierre-Louis Bossart

[-- Attachment #1: Type: text/plain, Size: 1884 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4
head:   fe23be2d85b05f561431d75acddec726ea807d2a
commit: 130d3e90777fe974e4b8fa100cec8faf19cac998 [438/441] ASoC: SOF: Intel: Fix CFL and CML FW nocodec binary names.
config: i386-randconfig-c002-20191117 (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        git checkout 130d3e90777fe974e4b8fa100cec8faf19cac998
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> sound/soc/sof/sof-pci-dev.c:136:15: error: 'snd_soc_acpi_intel_cml_machines' undeclared here (not in a function); did you mean 'snd_soc_acpi_intel_cnl_machines'?
     .machines  = snd_soc_acpi_intel_cml_machines,
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                  snd_soc_acpi_intel_cnl_machines

vim +136 sound/soc/sof/sof-pci-dev.c

   131	
   132	#if IS_ENABLED(CONFIG_SND_SOC_SOF_COMETLAKE_LP) || \
   133		IS_ENABLED(CONFIG_SND_SOC_SOF_COMETLAKE_H)
   134	
   135	static const struct sof_dev_desc cml_desc = {
 > 136		.machines		= snd_soc_acpi_intel_cml_machines,
   137		.resindex_lpe_base	= 0,
   138		.resindex_pcicfg_base	= -1,
   139		.resindex_imr_base	= -1,
   140		.irqindex_host_ipc	= -1,
   141		.resindex_dma_base	= -1,
   142		.chip_info = &cnl_chip_info,
   143		.default_fw_path = "intel/sof",
   144		.default_tplg_path = "intel/sof-tplg",
   145		.nocodec_fw_filename = "sof-cml.ri",
   146		.nocodec_tplg_filename = "sof-cnl-nocodec.tplg",
   147		.ops = &sof_cnl_ops,
   148		.arch_ops = &sof_xtensa_arch_ops
   149	};
   150	#endif
   151	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39331 bytes --]

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [alsa-devel] [asoc:for-5.4 438/441] sound/soc/sof/sof-pci-dev.c:136:15: error: 'snd_soc_acpi_intel_cml_machines' undeclared here (not in a function); did you mean 'snd_soc_acpi_intel_cnl_machines'?
  2019-11-17  2:02 [alsa-devel] [asoc:for-5.4 438/441] sound/soc/sof/sof-pci-dev.c:136:15: error: 'snd_soc_acpi_intel_cml_machines' undeclared here (not in a function); did you mean 'snd_soc_acpi_intel_cnl_machines'? kbuild test robot
@ 2019-11-18 15:31 ` Pierre-Louis Bossart
  2019-11-18 15:55   ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Pierre-Louis Bossart @ 2019-11-18 15:31 UTC (permalink / raw)
  To: kbuild test robot, Liam Girdwood; +Cc: alsa-devel, Mark Brown, kbuild-all




On 11/16/19 8:02 PM, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4
> head:   fe23be2d85b05f561431d75acddec726ea807d2a
> commit: 130d3e90777fe974e4b8fa100cec8faf19cac998 [438/441] ASoC: SOF: Intel: Fix CFL and CML FW nocodec binary names.
> config: i386-randconfig-c002-20191117 (attached as .config)
> compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
> reproduce:
>          git checkout 130d3e90777fe974e4b8fa100cec8faf19cac998
>          # save the attached .config to linux build tree
>          make ARCH=i386
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>>> sound/soc/sof/sof-pci-dev.c:136:15: error: 'snd_soc_acpi_intel_cml_machines' undeclared here (not in a function); did you mean 'snd_soc_acpi_intel_cnl_machines'?
>       .machines  = snd_soc_acpi_intel_cml_machines,
>                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>                    snd_soc_acpi_intel_cnl_machines

Looks like the for-5.4 branch did not pick up all the patches from the 
series [PATCH 0/3] ASoC: Intel/SOF: split CFL, CNL, CML firmware names​

it's missing:
[PATCH 1/3] ASoC: Intel: acpi-match: split CNL tables in three
[PATCH 3/3] ASoC: SOF: Intel: hda: use fallback for firmware name


> 
> vim +136 sound/soc/sof/sof-pci-dev.c
> 
>     131	
>     132	#if IS_ENABLED(CONFIG_SND_SOC_SOF_COMETLAKE_LP) || \
>     133		IS_ENABLED(CONFIG_SND_SOC_SOF_COMETLAKE_H)
>     134	
>     135	static const struct sof_dev_desc cml_desc = {
>   > 136		.machines		= snd_soc_acpi_intel_cml_machines,
>     137		.resindex_lpe_base	= 0,
>     138		.resindex_pcicfg_base	= -1,
>     139		.resindex_imr_base	= -1,
>     140		.irqindex_host_ipc	= -1,
>     141		.resindex_dma_base	= -1,
>     142		.chip_info = &cnl_chip_info,
>     143		.default_fw_path = "intel/sof",
>     144		.default_tplg_path = "intel/sof-tplg",
>     145		.nocodec_fw_filename = "sof-cml.ri",
>     146		.nocodec_tplg_filename = "sof-cnl-nocodec.tplg",
>     147		.ops = &sof_cnl_ops,
>     148		.arch_ops = &sof_xtensa_arch_ops
>     149	};
>     150	#endif
>     151	
> 
> ---
> 0-DAY kernel test infrastructure                 Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
> 
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [alsa-devel] [asoc:for-5.4 438/441] sound/soc/sof/sof-pci-dev.c:136:15: error: 'snd_soc_acpi_intel_cml_machines' undeclared here (not in a function); did you mean 'snd_soc_acpi_intel_cnl_machines'?
  2019-11-18 15:31 ` Pierre-Louis Bossart
@ 2019-11-18 15:55   ` Mark Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2019-11-18 15:55 UTC (permalink / raw)
  To: Pierre-Louis Bossart
  Cc: Liam Girdwood, alsa-devel, kbuild-all, kbuild test robot


[-- Attachment #1.1: Type: text/plain, Size: 494 bytes --]

On Mon, Nov 18, 2019 at 09:31:12AM -0600, Pierre-Louis Bossart wrote:

> Looks like the for-5.4 branch did not pick up all the patches from the
> series [PATCH 0/3] ASoC: Intel/SOF: split CFL, CNL, CML firmware names​
> 
> it's missing:
> [PATCH 1/3] ASoC: Intel: acpi-match: split CNL tables in three
> [PATCH 3/3] ASoC: SOF: Intel: hda: use fallback for firmware name

Only one of those looks like a fix...  I've reverted the commit from
5.4.  Stephen reported this last week...

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-11-18 15:56 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-17  2:02 [alsa-devel] [asoc:for-5.4 438/441] sound/soc/sof/sof-pci-dev.c:136:15: error: 'snd_soc_acpi_intel_cml_machines' undeclared here (not in a function); did you mean 'snd_soc_acpi_intel_cnl_machines'? kbuild test robot
2019-11-18 15:31 ` Pierre-Louis Bossart
2019-11-18 15:55   ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).