* [alsa-devel] cp: upmix: code formatting and cleanup, generalize format
[not found] <1574268341798404932-webhooks-bot@alsa-project.org>
@ 2019-11-20 16:45 ` GitHub pull_request - opened
0 siblings, 0 replies; only message in thread
From: GitHub pull_request - opened @ 2019-11-20 16:45 UTC (permalink / raw)
To: alsa-devel
alsa-project/alsa-plugins pull request #2 was opened from bku-sue:
The main purpose of this change is to be able to change the format to e.g. S32 instead of S16 by changing only two lines on the top of the source. So a new symbol `UPMIX_PCM_FORMAT` is added to hide the actual format, and a special type `upmix_sample_t` marks the sample type, instead of fixed `short`.
I fixed the `average_copy` function as well, which was actually expecting the `nchns` parameter to be 2, otherwise its local arrays would be overindexed.
The rest is just better naming for `i` as it denotes the channel index in every case, and applying consistent whitespace.
The behavior of the plugin remains identical though.
Request URL : https://github.com/alsa-project/alsa-plugins/pull/2
Patch URL : https://github.com/alsa-project/alsa-plugins/pull/2.patch
Repository URL: https://github.com/alsa-project/alsa-plugins
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-11-20 16:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1574268341798404932-webhooks-bot@alsa-project.org>
2019-11-20 16:45 ` [alsa-devel] cp: upmix: code formatting and cleanup, generalize format GitHub pull_request - opened
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).