Re: [alsa-devel] [PATCH for-5.6 02/23] ASoC: atmel: Drop superfluous ioctl PCM ops

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>,
	alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
	Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Subject: Re: [alsa-devel] [PATCH for-5.6 02/23] ASoC: atmel: Drop superfluous ioctl PCM ops
Date: Tue, 10 Dec 2019 16:13:27 +0100	[thread overview]
Message-ID: <20191210151327.GO1463890@piout.net> (raw)
In-Reply-To: <20191210145406.21419-3-tiwai@suse.de>

On 10/12/2019 15:53:45+0100, Takashi Iwai wrote:
> ASoC PCM core deals the empty ioctl field now as default.
> Let's kill the redundant lines.
> 
> Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/soc/atmel/atmel-pcm-pdc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

> diff --git a/sound/soc/atmel/atmel-pcm-pdc.c b/sound/soc/atmel/atmel-pcm-pdc.c
> index 18a2fd02fffe..59c1331a6984 100644
> --- a/sound/soc/atmel/atmel-pcm-pdc.c
> +++ b/sound/soc/atmel/atmel-pcm-pdc.c
> @@ -379,7 +379,6 @@ static int atmel_pcm_close(struct snd_soc_component *component,
>  static const struct snd_soc_component_driver atmel_soc_platform = {
>  	.open		= atmel_pcm_open,
>  	.close		= atmel_pcm_close,
> -	.ioctl		= snd_soc_pcm_lib_ioctl,
>  	.hw_params	= atmel_pcm_hw_params,
>  	.hw_free	= atmel_pcm_hw_free,
>  	.prepare	= atmel_pcm_prepare,
> -- 
> 2.16.4
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel