Re: [alsa-devel] [PATCH for-5.6 17/23] ASoC: sprd: Drop superfluous ioctl PCM ops

From: Orson Zhai <orsonzhai@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Baolin Wang <baolin.wang7@gmail.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>
Subject: Re: [alsa-devel] [PATCH for-5.6 17/23] ASoC: sprd: Drop superfluous ioctl PCM ops
Date: Wed, 11 Dec 2019 08:21:14 +0800	[thread overview]
Message-ID: <CA+H2tpGWxhd8TOu1rnA19gPRxOuXBNCj33OxY9Gja=ZinmxszA@mail.gmail.com> (raw)
In-Reply-To: <20191210145406.21419-18-tiwai@suse.de>

On Tue, Dec 10, 2019 at 10:54 PM Takashi Iwai <tiwai@suse.de> wrote:
>
> ASoC PCM core deals the empty ioctl field now as default.
> Let's kill the redundant lines.
>
> Cc: Orson Zhai <orsonzhai@gmail.com>
> Cc: Baolin Wang <baolin.wang7@gmail.com>
> Cc: Chunyan Zhang <zhang.lyra@gmail.com>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  sound/soc/sprd/sprd-pcm-dma.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/sprd/sprd-pcm-dma.c b/sound/soc/sprd/sprd-pcm-dma.c
> index da4b8f5f192b..2284558684bc 100644
> --- a/sound/soc/sprd/sprd-pcm-dma.c
> +++ b/sound/soc/sprd/sprd-pcm-dma.c
> @@ -508,7 +508,6 @@ static const struct snd_soc_component_driver sprd_soc_component = {
>         .name           = DRV_NAME,
>         .open           = sprd_pcm_open,
>         .close          = sprd_pcm_close,
> -       .ioctl          = snd_soc_pcm_lib_ioctl,
>         .hw_params      = sprd_pcm_hw_params,
>         .hw_free        = sprd_pcm_hw_free,
>         .trigger        = sprd_pcm_trigger,
> --
> 2.16.4
>

Got it. Thank you!
-Orson
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel