From: Keyon Jie <yang.jie@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, Keyon Jie <yang.jie@linux.intel.com>
Subject: [alsa-devel] [PATCH] ALSA: pcm: fix buffer_bytes max constrained by preallocated bytes issue
Date: Thu, 16 Jan 2020 12:53:18 +0800 [thread overview]
Message-ID: <20200116045318.5498-1-yang.jie@linux.intel.com> (raw)
With today's code, we preallocate DMA buffer for substreams at pcm_new()
stage, and the substream->buffer_bytes_max and substream->dma_max will
save as the actually preallocated buffer size and maximum size that the
dma buffer can be expanded by at hw_params() state, correspondingly.
At pcm_open() stage, the maximum constraint of HW_PARAM_BUFFER_BYTES is
set to substream->buffer_bytes_max and returned to user space as the max
interval of the HW_PARAM_BUFFER_BYTES, this will lead to issue that user
can't choose any buffer-bytes larger than the preallocated buffer size,
and the buffer reallocation will never happen actually.
Here change to use substream->dma_max as the maximum constraint of the
HW_PARAM_BUFFER_BYTES and fix the issue mentioned above.
Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
---
sound/core/pcm_native.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index c375c41496f8..326e921006e7 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -2301,7 +2301,7 @@ static int snd_pcm_hw_rule_buffer_bytes_max(struct snd_pcm_hw_params *params,
struct snd_interval t;
struct snd_pcm_substream *substream = rule->private;
t.min = 0;
- t.max = substream->buffer_bytes_max;
+ t.max = substream->dma_max;
t.openmin = 0;
t.openmax = 0;
t.integer = 1;
--
2.20.1
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next reply other threads:[~2020-01-16 4:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 4:53 Keyon Jie [this message]
2020-01-16 7:15 ` [alsa-devel] [PATCH] ALSA: pcm: fix buffer_bytes max constrained by preallocated bytes issue Takashi Iwai
2020-01-16 9:50 ` Keyon Jie
2020-01-16 10:27 ` Takashi Iwai
2020-01-16 11:25 ` Keyon Jie
2020-01-16 11:50 ` Takashi Iwai
2020-01-16 14:14 ` Jie, Yang
2020-01-16 15:31 ` Jie, Yang
2020-01-16 16:07 ` Takashi Iwai
2020-01-16 16:39 ` Pierre-Louis Bossart
2020-01-16 17:25 ` Rajwa, Marcin
2020-01-16 17:40 ` Pierre-Louis Bossart
2020-01-16 20:37 ` Takashi Iwai
2020-01-17 5:30 ` Keyon Jie
2020-01-17 7:57 ` Takashi Iwai
2020-01-17 10:13 ` Keyon Jie
2020-01-17 10:30 ` Takashi Iwai
2020-01-17 10:56 ` Keyon Jie
2020-01-17 11:15 ` Takashi Iwai
2020-01-17 5:37 ` Keyon Jie
2020-01-17 8:00 ` Takashi Iwai
2020-01-17 10:43 ` Keyon Jie
2020-01-17 11:12 ` Takashi Iwai
2020-01-19 3:52 ` Keyon Jie
2020-01-19 7:09 ` Takashi Iwai
2020-01-19 8:11 ` Keyon Jie
2020-01-19 9:04 ` Takashi Iwai
2020-01-19 10:14 ` Keyon Jie
2020-01-19 10:43 ` Takashi Iwai
2020-01-20 2:23 ` Keyon Jie
2020-01-16 15:45 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116045318.5498-1-yang.jie@linux.intel.com \
--to=yang.jie@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).