From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-kernel@vger.kernel.org, Merlijn Wajer <merlijn@wizzup.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>,
"Arthur D ." <spinal.by@gmail.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>
Subject: Re: [PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card
Date: Tue, 18 Feb 2020 07:34:29 -0800 [thread overview]
Message-ID: <20200218153429.GJ35972@atomide.com> (raw)
In-Reply-To: <07989190-e110-13c4-50ea-875431725b47@ti.com>
* Peter Ujfalusi <peter.ujfalusi@ti.com> [200218 15:28]:
>
>
> On 18/02/2020 1.36, Tony Lindgren wrote:
> > * Tony Lindgren <tony@atomide.com> [200217 23:10]:
> >> * Peter Ujfalusi <peter.ujfalusi@ti.com> [200217 12:10]:
> >>> On 14/02/2020 19.03, Tony Lindgren wrote:
> >>>> But right now in droid4 voice call case mcbsp is just the i2s transport,
> >>>> and everything happens betwee the modem and the cpcap pmic.
> >>>
> >>> Iow you don't need McBSP DAI at all. If you would have added the dummy
> >>> codec to McBSP !3 and use that, it would work in a same way, or to DMIC
> >>> or McPDM...
> >>>
> >>> The McBSP ops are NULL for the dummy dai, so McBSP is turned off.
> >>
> >> Hmm yeah I don't know if the cpcap codec on the same mcbsp needs
> >> mcbsp for voice call.
> >>
> >> According to Sebastian sounds like mcbsp can be idle at that point.
> >>
> >> But what about capture of voice call at the mcbsp from the
> >> TDM slot? In that case mcbsp would be active.
> >
> > Looks like only initializing only one mcbsp3 instance here
> > instead of two will produce an oops as below.
> >
> > I'm not sure how this is supposed to work for
> > snd-soc-audio-graph-card with multipe endpoints connected
> > to just one mcbsp dai instance?
> >
> > Regards,
> >
> > Tony
> >
> > 8< -------------------
> What is the kernel version?
> The context is missing...
> Who printed the line:
> dev_err(dev, "ASoC: Failed to register DAIs: %d\n", ret);
Oh sorry, this was just a quick test with droid4-pending-v5.5 branch
with only one mcbsp dai initialized.
> This is only possible if snd_soc_component_initialize() fail, which can
> only fail if snd_soc_component_unique_name() fails.
>
> > Internal error: Oops: 805 [#1] PREEMPT SMP ARM
> > snd_soc_del_component_unlocked+0xf4/0x110
>
> Not too helpful ;)
Yeah I have not looked at it closer so far..
Regards,
Tony
> > ...
> > [ 39.616027] Backtrace:
> > [ 39.616149] [<bf3f6bc4>] (snd_soc_del_component_unlocked [snd_soc_core]) from [<bf3f8ff4>] (snd_soc_add_component+0x238/0x374 [snd_s)
> > [ 39.616149] r7:00000002 r6:00000002 r5:ec9a0e78 r4:00000122
> > [ 39.678283] qmi_wwan 1-1:1.6: cdc-wdm1: USB WDM device
> > [ 39.739074] [<bf3f8dbc>] (snd_soc_add_component [snd_soc_core]) from [<bf3f9180>] (snd_soc_register_component+0x50/0x60 [snd_soc_cor)
> > [ 39.739074] r10:bf4582d0 r9:ec9d0840 r8:00000002 r7:00000002 r6:ec9d0640 r5:bf4584ac
> > [ 39.800842] asoc-audio-graph-card soundcard: using device tree for GPIO lookup
> > [ 39.808685] r4:eed52410
> > [ 39.862304] [<bf3f9130>] (snd_soc_register_component [snd_soc_core]) from [<bf4088b4>] (devm_snd_soc_register_component+0x54/0x90 [s)
> > [ 39.862304] r7:ec9d0640 r6:bf4584ac r5:ec9d3040 r4:eed52410
> > [ 39.925048] qmi_wwan 1-1:1.6 wwan1: register 'qmi_wwan' at usb-4a064800.ohci-1, WWAN/QMI device, 2e:59:df:3f:4f:ef
> > [ 39.984558] [<bf408860>] (devm_snd_soc_register_component [snd_soc_core]) from [<bf456fb8>] (asoc_mcbsp_probe+0x3e8/0x574 [snd_soc_o)
> > [ 39.984558] r9:ec9d0840 r8:ec9f4000 r7:eed52410 r6:00000000 r5:eed52400 r4:ec9d0840
> > [ 39.984588] [<bf456bd0>] (asoc_mcbsp_probe [snd_soc_omap_mcbsp]) from [<c068475c>] (platform_drv_probe+0x58/0xa8)
> > [ 39.984619] r10:00000000 r9:0000002e r8:bf459014 r7:00000000 r6:bf459014 r5:00000000
> > [ 40.044342] of_get_named_gpiod_flags: can't parse 'pa-gpios' property of node '/soundcard[0]'
> > [ 40.051788] r4:eed52410
> > [ 40.100769] [<c0684704>] (platform_drv_probe) from [<c06820ac>] (really_probe+0x1ec/0x358)
> >
>
> - Péter
>
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-02-18 15:35 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 17:16 [alsa-devel] [PATCH] ASoC: ti: Allocate dais dynamically for TDM and audio graph card Tony Lindgren
2020-02-12 8:02 ` Peter Ujfalusi
2020-02-12 14:35 ` Tony Lindgren
2020-02-14 0:34 ` Sebastian Reichel
2020-02-14 1:34 ` Tony Lindgren
2020-02-14 13:04 ` Sebastian Reichel
2020-02-14 17:09 ` Tony Lindgren
2020-02-18 14:04 ` Sebastian Reichel
2020-02-18 14:19 ` Tony Lindgren
2020-02-18 16:35 ` Sebastian Reichel
2020-02-14 12:41 ` [alsa-devel] " Peter Ujfalusi
2020-02-14 12:49 ` Mark Brown
2020-02-14 17:05 ` Tony Lindgren
2020-02-14 20:05 ` Mark Brown
2020-02-14 17:03 ` Tony Lindgren
2020-02-17 1:38 ` Kuninori Morimoto
2020-02-17 5:25 ` Kuninori Morimoto
2020-02-17 12:09 ` Peter Ujfalusi
2020-02-17 23:10 ` Tony Lindgren
2020-02-17 23:36 ` Tony Lindgren
2020-02-18 15:26 ` Peter Ujfalusi
2020-02-18 15:34 ` Tony Lindgren [this message]
2020-02-18 12:43 ` Peter Ujfalusi
2020-02-18 15:28 ` Tony Lindgren
2020-02-20 14:07 ` Peter Ujfalusi
2020-02-20 20:13 ` Tony Lindgren
2020-02-21 14:07 ` Peter Ujfalusi
2020-02-18 21:16 ` Sebastian Reichel
2020-02-20 14:15 ` Peter Ujfalusi
2020-02-20 20:15 ` Tony Lindgren
2020-02-21 13:20 ` Peter Ujfalusi
2020-02-21 18:08 ` Tony Lindgren
2020-02-20 20:47 ` Sebastian Reichel
2021-01-24 9:27 Pavel Machek
2021-01-25 11:43 ` Péter Ujfalusi
2021-01-28 6:35 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218153429.GJ35972@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=peter.ujfalusi@ti.com \
--cc=spinal.by@gmail.com \
--cc=sre@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).