* [PATCH v2] ASoC: samsung: Silence warnings during deferred probe [not found] <CGME20200228101124eucas1p1f6ab761a38f4a953a4eeed89859fcf4a@eucas1p1.samsung.com> @ 2020-02-28 10:11 ` Marek Szyprowski 2020-02-28 11:31 ` Krzysztof Kozlowski ` (2 more replies) 0 siblings, 3 replies; 6+ messages in thread From: Marek Szyprowski @ 2020-02-28 10:11 UTC (permalink / raw) To: alsa-devel, linux-samsung-soc Cc: Sangbeom Kim, Mark Brown, Krzysztof Kozlowski, Sylwester Nawrocki, Marek Szyprowski Don't confuse user with meaningless warning about the failure in getting resources and registering card in case of deferred probe. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- sound/soc/samsung/arndale.c | 4 +++- sound/soc/samsung/littlemill.c | 2 +- sound/soc/samsung/lowland.c | 2 +- sound/soc/samsung/odroid.c | 4 +++- sound/soc/samsung/smdk_wm8994.c | 2 +- sound/soc/samsung/smdk_wm8994pcm.c | 2 +- sound/soc/samsung/snow.c | 4 +++- sound/soc/samsung/speyside.c | 2 +- sound/soc/samsung/tm2_wm5110.c | 3 ++- sound/soc/samsung/tobermory.c | 2 +- 10 files changed, 17 insertions(+), 10 deletions(-) diff --git a/sound/soc/samsung/arndale.c b/sound/soc/samsung/arndale.c index d64602950cbd..6e6d67d6e0ab 100644 --- a/sound/soc/samsung/arndale.c +++ b/sound/soc/samsung/arndale.c @@ -174,7 +174,9 @@ static int arndale_audio_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(card->dev, card); if (ret) { - dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, + "snd_soc_register_card() failed: %d\n", ret); goto err_put_of_nodes; } return 0; diff --git a/sound/soc/samsung/littlemill.c b/sound/soc/samsung/littlemill.c index 59904f44118b..2f2f83a8c23a 100644 --- a/sound/soc/samsung/littlemill.c +++ b/sound/soc/samsung/littlemill.c @@ -325,7 +325,7 @@ static int littlemill_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); diff --git a/sound/soc/samsung/lowland.c b/sound/soc/samsung/lowland.c index 098eefc764db..fcc7897ee7d0 100644 --- a/sound/soc/samsung/lowland.c +++ b/sound/soc/samsung/lowland.c @@ -183,7 +183,7 @@ static int lowland_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); diff --git a/sound/soc/samsung/odroid.c b/sound/soc/samsung/odroid.c index f0f5fa9c27d3..30c7e1bc2a30 100644 --- a/sound/soc/samsung/odroid.c +++ b/sound/soc/samsung/odroid.c @@ -311,7 +311,9 @@ static int odroid_audio_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(dev, card); if (ret < 0) { - dev_err(dev, "snd_soc_register_card() failed: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(dev, "snd_soc_register_card() failed: %d\n", + ret); goto err_put_clk_i2s; } diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c index 28f8be000aa1..8fa5f6b387ad 100644 --- a/sound/soc/samsung/smdk_wm8994.c +++ b/sound/soc/samsung/smdk_wm8994.c @@ -178,7 +178,7 @@ static int smdk_audio_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed:%d\n", ret); return ret; diff --git a/sound/soc/samsung/smdk_wm8994pcm.c b/sound/soc/samsung/smdk_wm8994pcm.c index 2e3dc7320c62..6e44f7927852 100644 --- a/sound/soc/samsung/smdk_wm8994pcm.c +++ b/sound/soc/samsung/smdk_wm8994pcm.c @@ -118,7 +118,7 @@ static int snd_smdk_probe(struct platform_device *pdev) smdk_pcm.dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, &smdk_pcm); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card failed %d\n", ret); return ret; diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c index f075aae9561a..bebcf0a4d608 100644 --- a/sound/soc/samsung/snow.c +++ b/sound/soc/samsung/snow.c @@ -216,7 +216,9 @@ static int snow_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(dev, card); if (ret) { - dev_err(&pdev->dev, "snd_soc_register_card failed (%d)\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, + "snd_soc_register_card failed (%d)\n", ret); return ret; } diff --git a/sound/soc/samsung/speyside.c b/sound/soc/samsung/speyside.c index ea0d1ec67f01..8f175f204eb7 100644 --- a/sound/soc/samsung/speyside.c +++ b/sound/soc/samsung/speyside.c @@ -330,7 +330,7 @@ static int speyside_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c index 10ff14b856f2..043a287728b3 100644 --- a/sound/soc/samsung/tm2_wm5110.c +++ b/sound/soc/samsung/tm2_wm5110.c @@ -611,7 +611,8 @@ static int tm2_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(dev, card); if (ret < 0) { - dev_err(dev, "Failed to register card: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to register card: %d\n", ret); goto dai_node_put; } diff --git a/sound/soc/samsung/tobermory.c b/sound/soc/samsung/tobermory.c index fdce28cc26c4..1aa3fdb4b152 100644 --- a/sound/soc/samsung/tobermory.c +++ b/sound/soc/samsung/tobermory.c @@ -229,7 +229,7 @@ static int tobermory_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ASoC: samsung: Silence warnings during deferred probe 2020-02-28 10:11 ` [PATCH v2] ASoC: samsung: Silence warnings during deferred probe Marek Szyprowski @ 2020-02-28 11:31 ` Krzysztof Kozlowski 2020-02-28 16:12 ` Mark Brown 2020-02-28 18:24 ` Applied "ASoC: samsung: Silence warnings during deferred probe" to the asoc tree Mark Brown 2 siblings, 0 replies; 6+ messages in thread From: Krzysztof Kozlowski @ 2020-02-28 11:31 UTC (permalink / raw) To: Marek Szyprowski Cc: Sangbeom Kim, alsa-devel, linux-samsung-soc, Mark Brown, Sylwester Nawrocki On Fri, Feb 28, 2020 at 11:11:20AM +0100, Marek Szyprowski wrote: > Don't confuse user with meaningless warning about the failure in getting > resources and registering card in case of deferred probe. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > sound/soc/samsung/arndale.c | 4 +++- > sound/soc/samsung/littlemill.c | 2 +- > sound/soc/samsung/lowland.c | 2 +- > sound/soc/samsung/odroid.c | 4 +++- > sound/soc/samsung/smdk_wm8994.c | 2 +- > sound/soc/samsung/smdk_wm8994pcm.c | 2 +- > sound/soc/samsung/snow.c | 4 +++- > sound/soc/samsung/speyside.c | 2 +- > sound/soc/samsung/tm2_wm5110.c | 3 ++- > sound/soc/samsung/tobermory.c | 2 +- > 10 files changed, 17 insertions(+), 10 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ASoC: samsung: Silence warnings during deferred probe 2020-02-28 10:11 ` [PATCH v2] ASoC: samsung: Silence warnings during deferred probe Marek Szyprowski 2020-02-28 11:31 ` Krzysztof Kozlowski @ 2020-02-28 16:12 ` Mark Brown 2020-02-28 17:45 ` Krzysztof Kozlowski 2020-02-28 18:24 ` Applied "ASoC: samsung: Silence warnings during deferred probe" to the asoc tree Mark Brown 2 siblings, 1 reply; 6+ messages in thread From: Mark Brown @ 2020-02-28 16:12 UTC (permalink / raw) To: Marek Szyprowski Cc: Sangbeom Kim, alsa-devel, linux-samsung-soc, Krzysztof Kozlowski, Sylwester Nawrocki [-- Attachment #1: Type: text/plain, Size: 809 bytes --] On Fri, Feb 28, 2020 at 11:11:20AM +0100, Marek Szyprowski wrote: > Don't confuse user with meaningless warning about the failure in getting > resources and registering card in case of deferred probe. > if (ret) { > - dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, > + "snd_soc_register_card() failed: %d\n", ret); This is completely removing the diagnostics so if things do get stuck the user will generally not have any hint as to what's going wrong - it's better with this sort of change to lower to dev_dbg() for deferral rather than completely removing the error message so the user has some ability to figure out what was missing. However in this case it's also the case that snd_soc_register_card() is fairly noisy. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ASoC: samsung: Silence warnings during deferred probe 2020-02-28 16:12 ` Mark Brown @ 2020-02-28 17:45 ` Krzysztof Kozlowski 2020-02-28 18:09 ` Mark Brown 0 siblings, 1 reply; 6+ messages in thread From: Krzysztof Kozlowski @ 2020-02-28 17:45 UTC (permalink / raw) To: Mark Brown Cc: Sangbeom Kim, alsa-devel, linux-samsung-soc, Sylwester Nawrocki, Marek Szyprowski On Fri, 28 Feb 2020 at 17:12, Mark Brown <broonie@kernel.org> wrote: > > On Fri, Feb 28, 2020 at 11:11:20AM +0100, Marek Szyprowski wrote: > > > Don't confuse user with meaningless warning about the failure in getting > > resources and registering card in case of deferred probe. > > > if (ret) { > > - dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); > > + if (ret != -EPROBE_DEFER) > > + dev_err(&pdev->dev, > > + "snd_soc_register_card() failed: %d\n", ret); > > This is completely removing the diagnostics so if things do get stuck > the user will generally not have any hint as to what's going wrong - > it's better with this sort of change to lower to dev_dbg() for deferral > rather than completely removing the error message so the user has some > ability to figure out what was missing. However in this case it's also > the case that snd_soc_register_card() is fairly noisy. This dev_dbg could be achieved with ftrace for probe() as well. I think it is quite common to skip all messages for deferred probes. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ASoC: samsung: Silence warnings during deferred probe 2020-02-28 17:45 ` Krzysztof Kozlowski @ 2020-02-28 18:09 ` Mark Brown 0 siblings, 0 replies; 6+ messages in thread From: Mark Brown @ 2020-02-28 18:09 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Sangbeom Kim, alsa-devel, linux-samsung-soc, Sylwester Nawrocki, Marek Szyprowski [-- Attachment #1: Type: text/plain, Size: 830 bytes --] On Fri, Feb 28, 2020 at 06:45:33PM +0100, Krzysztof Kozlowski wrote: > On Fri, 28 Feb 2020 at 17:12, Mark Brown <broonie@kernel.org> wrote: > > This is completely removing the diagnostics so if things do get stuck > > the user will generally not have any hint as to what's going wrong - > > it's better with this sort of change to lower to dev_dbg() for deferral > > rather than completely removing the error message so the user has some > > ability to figure out what was missing. However in this case it's also > > the case that snd_soc_register_card() is fairly noisy. > This dev_dbg could be achieved with ftrace for probe() as well. I > think it is quite common to skip all messages for deferred probes. Yes... and having had the pleasure of debugging problems with things not instantiating I'm not a fan of this trend. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 488 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* Applied "ASoC: samsung: Silence warnings during deferred probe" to the asoc tree 2020-02-28 10:11 ` [PATCH v2] ASoC: samsung: Silence warnings during deferred probe Marek Szyprowski 2020-02-28 11:31 ` Krzysztof Kozlowski 2020-02-28 16:12 ` Mark Brown @ 2020-02-28 18:24 ` Mark Brown 2 siblings, 0 replies; 6+ messages in thread From: Mark Brown @ 2020-02-28 18:24 UTC (permalink / raw) To: Marek Szyprowski Cc: alsa-devel, linux-samsung-soc, Sangbeom Kim, Krzysztof Kozlowski, Mark Brown, Sylwester Nawrocki The patch ASoC: samsung: Silence warnings during deferred probe has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 1a1b3743487317514f7d5d66dd9d6c9233321eba Mon Sep 17 00:00:00 2001 From: Marek Szyprowski <m.szyprowski@samsung.com> Date: Fri, 28 Feb 2020 11:11:20 +0100 Subject: [PATCH] ASoC: samsung: Silence warnings during deferred probe Don't confuse user with meaningless warning about the failure in getting resources and registering card in case of deferred probe. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Link: https://lore.kernel.org/r/20200228101120.28819-1-m.szyprowski@samsung.com Signed-off-by: Mark Brown <broonie@kernel.org> --- sound/soc/samsung/arndale.c | 4 +++- sound/soc/samsung/littlemill.c | 2 +- sound/soc/samsung/lowland.c | 2 +- sound/soc/samsung/odroid.c | 4 +++- sound/soc/samsung/smdk_wm8994.c | 2 +- sound/soc/samsung/smdk_wm8994pcm.c | 2 +- sound/soc/samsung/snow.c | 4 +++- sound/soc/samsung/speyside.c | 2 +- sound/soc/samsung/tm2_wm5110.c | 3 ++- sound/soc/samsung/tobermory.c | 2 +- 10 files changed, 17 insertions(+), 10 deletions(-) diff --git a/sound/soc/samsung/arndale.c b/sound/soc/samsung/arndale.c index d64602950cbd..6e6d67d6e0ab 100644 --- a/sound/soc/samsung/arndale.c +++ b/sound/soc/samsung/arndale.c @@ -174,7 +174,9 @@ static int arndale_audio_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(card->dev, card); if (ret) { - dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, + "snd_soc_register_card() failed: %d\n", ret); goto err_put_of_nodes; } return 0; diff --git a/sound/soc/samsung/littlemill.c b/sound/soc/samsung/littlemill.c index 59904f44118b..2f2f83a8c23a 100644 --- a/sound/soc/samsung/littlemill.c +++ b/sound/soc/samsung/littlemill.c @@ -325,7 +325,7 @@ static int littlemill_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); diff --git a/sound/soc/samsung/lowland.c b/sound/soc/samsung/lowland.c index 098eefc764db..fcc7897ee7d0 100644 --- a/sound/soc/samsung/lowland.c +++ b/sound/soc/samsung/lowland.c @@ -183,7 +183,7 @@ static int lowland_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); diff --git a/sound/soc/samsung/odroid.c b/sound/soc/samsung/odroid.c index f0f5fa9c27d3..30c7e1bc2a30 100644 --- a/sound/soc/samsung/odroid.c +++ b/sound/soc/samsung/odroid.c @@ -311,7 +311,9 @@ static int odroid_audio_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(dev, card); if (ret < 0) { - dev_err(dev, "snd_soc_register_card() failed: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(dev, "snd_soc_register_card() failed: %d\n", + ret); goto err_put_clk_i2s; } diff --git a/sound/soc/samsung/smdk_wm8994.c b/sound/soc/samsung/smdk_wm8994.c index 28f8be000aa1..8fa5f6b387ad 100644 --- a/sound/soc/samsung/smdk_wm8994.c +++ b/sound/soc/samsung/smdk_wm8994.c @@ -178,7 +178,7 @@ static int smdk_audio_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed:%d\n", ret); return ret; diff --git a/sound/soc/samsung/smdk_wm8994pcm.c b/sound/soc/samsung/smdk_wm8994pcm.c index 2e3dc7320c62..6e44f7927852 100644 --- a/sound/soc/samsung/smdk_wm8994pcm.c +++ b/sound/soc/samsung/smdk_wm8994pcm.c @@ -118,7 +118,7 @@ static int snd_smdk_probe(struct platform_device *pdev) smdk_pcm.dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, &smdk_pcm); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card failed %d\n", ret); return ret; diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c index f075aae9561a..bebcf0a4d608 100644 --- a/sound/soc/samsung/snow.c +++ b/sound/soc/samsung/snow.c @@ -216,7 +216,9 @@ static int snow_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(dev, card); if (ret) { - dev_err(&pdev->dev, "snd_soc_register_card failed (%d)\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(&pdev->dev, + "snd_soc_register_card failed (%d)\n", ret); return ret; } diff --git a/sound/soc/samsung/speyside.c b/sound/soc/samsung/speyside.c index ea0d1ec67f01..8f175f204eb7 100644 --- a/sound/soc/samsung/speyside.c +++ b/sound/soc/samsung/speyside.c @@ -330,7 +330,7 @@ static int speyside_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c index 10ff14b856f2..043a287728b3 100644 --- a/sound/soc/samsung/tm2_wm5110.c +++ b/sound/soc/samsung/tm2_wm5110.c @@ -611,7 +611,8 @@ static int tm2_probe(struct platform_device *pdev) ret = devm_snd_soc_register_card(dev, card); if (ret < 0) { - dev_err(dev, "Failed to register card: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(dev, "Failed to register card: %d\n", ret); goto dai_node_put; } diff --git a/sound/soc/samsung/tobermory.c b/sound/soc/samsung/tobermory.c index fdce28cc26c4..1aa3fdb4b152 100644 --- a/sound/soc/samsung/tobermory.c +++ b/sound/soc/samsung/tobermory.c @@ -229,7 +229,7 @@ static int tobermory_probe(struct platform_device *pdev) card->dev = &pdev->dev; ret = devm_snd_soc_register_card(&pdev->dev, card); - if (ret) + if (ret && ret != -EPROBE_DEFER) dev_err(&pdev->dev, "snd_soc_register_card() failed: %d\n", ret); -- 2.20.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-02-28 18:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200228101124eucas1p1f6ab761a38f4a953a4eeed89859fcf4a@eucas1p1.samsung.com>
2020-02-28 10:11 ` [PATCH v2] ASoC: samsung: Silence warnings during deferred probe Marek Szyprowski
2020-02-28 11:31 ` Krzysztof Kozlowski
2020-02-28 16:12 ` Mark Brown
2020-02-28 17:45 ` Krzysztof Kozlowski
2020-02-28 18:09 ` Mark Brown
2020-02-28 18:24 ` Applied "ASoC: samsung: Silence warnings during deferred probe" to the asoc tree Mark Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).