* [PATCH v3] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet
@ 2020-04-05 13:37 Hans de Goede
2020-04-05 14:08 ` Hans de Goede
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Hans de Goede @ 2020-04-05 13:37 UTC (permalink / raw)
To: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
Mark Brown, flove, shumingf, Oder Chiou
Cc: Hans de Goede, alsa-devel
The MPMAN MPWIN895CL tablet almost fully works with out default settings.
The only problem is that it has only 1 speaker so any sounds only playing
on the right channel get lost.
Add a quirk for this model using the default settings + MONO_SPEAKER.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 6bd9ae813be2..d14d5f7db168 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -591,6 +591,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
BYT_RT5640_SSP0_AIF1 |
BYT_RT5640_MCLK_EN),
},
+ {
+ /* MPMAN MPWIN895CL */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MPMAN"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MPWIN8900CL"),
+ },
+ .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
+ BYT_RT5640_MONO_SPEAKER |
+ BYT_RT5640_SSP0_AIF1 |
+ BYT_RT5640_MCLK_EN),
+ },
{ /* MSI S100 tablet */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."),
--
2.26.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet
2020-04-05 13:37 [PATCH v3] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet Hans de Goede
@ 2020-04-05 14:08 ` Hans de Goede
2020-04-05 22:55 ` Pierre-Louis Bossart
2020-04-06 14:03 ` Applied "ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet" to the asoc tree Mark Brown
2 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2020-04-05 14:08 UTC (permalink / raw)
To: Cezary Rojewski, Pierre-Louis Bossart, Liam Girdwood, Jie Yang,
Mark Brown, flove, shumingf, Oder Chiou
Cc: alsa-devel
Note the v3 in the Subject is my bad, this is the first version / v1 of this patch.
Regards,
Hans
On 4/5/20 3:37 PM, Hans de Goede wrote:
> The MPMAN MPWIN895CL tablet almost fully works with out default settings.
> The only problem is that it has only 1 speaker so any sounds only playing
> on the right channel get lost.
>
> Add a quirk for this model using the default settings + MONO_SPEAKER.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 6bd9ae813be2..d14d5f7db168 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -591,6 +591,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
> BYT_RT5640_SSP0_AIF1 |
> BYT_RT5640_MCLK_EN),
> },
> + {
> + /* MPMAN MPWIN895CL */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MPMAN"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MPWIN8900CL"),
> + },
> + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
> + BYT_RT5640_MONO_SPEAKER |
> + BYT_RT5640_SSP0_AIF1 |
> + BYT_RT5640_MCLK_EN),
> + },
> { /* MSI S100 tablet */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."),
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet
2020-04-05 13:37 [PATCH v3] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet Hans de Goede
2020-04-05 14:08 ` Hans de Goede
@ 2020-04-05 22:55 ` Pierre-Louis Bossart
2020-04-06 7:46 ` Hans de Goede
2020-04-06 14:03 ` Applied "ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet" to the asoc tree Mark Brown
2 siblings, 1 reply; 5+ messages in thread
From: Pierre-Louis Bossart @ 2020-04-05 22:55 UTC (permalink / raw)
To: Hans de Goede, Cezary Rojewski, Liam Girdwood, Jie Yang,
Mark Brown, flove, shumingf, Oder Chiou
Cc: alsa-devel
On 4/5/20 8:37 AM, Hans de Goede wrote:
> The MPMAN MPWIN895CL tablet almost fully works with out default settings.
> The only problem is that it has only 1 speaker so any sounds only playing
> on the right channel get lost.
>
> Add a quirk for this model using the default settings + MONO_SPEAKER.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks Hans!
> ---
> sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 6bd9ae813be2..d14d5f7db168 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -591,6 +591,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
> BYT_RT5640_SSP0_AIF1 |
> BYT_RT5640_MCLK_EN),
> },
> + {
> + /* MPMAN MPWIN895CL */
> + .matches = {
> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MPMAN"),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MPWIN8900CL"),
> + },
> + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
> + BYT_RT5640_MONO_SPEAKER |
> + BYT_RT5640_SSP0_AIF1 |
> + BYT_RT5640_MCLK_EN),
> + },
> { /* MSI S100 tablet */
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."),
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet
2020-04-05 22:55 ` Pierre-Louis Bossart
@ 2020-04-06 7:46 ` Hans de Goede
0 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2020-04-06 7:46 UTC (permalink / raw)
To: Pierre-Louis Bossart, Cezary Rojewski, Liam Girdwood, Jie Yang,
Mark Brown, flove, shumingf, Oder Chiou
Cc: alsa-devel
Hi,
On 4/6/20 12:55 AM, Pierre-Louis Bossart wrote:
>
>
> On 4/5/20 8:37 AM, Hans de Goede wrote:
>> The MPMAN MPWIN895CL tablet almost fully works with out default settings.
>> The only problem is that it has only 1 speaker so any sounds only playing
>> on the right channel get lost.
>>
>> Add a quirk for this model using the default settings + MONO_SPEAKER.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>
> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks. Can you please also review this quirk addition ? :
https://patchwork.kernel.org/patch/11471275/
Regards,
Hans
>> ---
>> sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
>> index 6bd9ae813be2..d14d5f7db168 100644
>> --- a/sound/soc/intel/boards/bytcr_rt5640.c
>> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
>> @@ -591,6 +591,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
>> BYT_RT5640_SSP0_AIF1 |
>> BYT_RT5640_MCLK_EN),
>> },
>> + {
>> + /* MPMAN MPWIN895CL */
>> + .matches = {
>> + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MPMAN"),
>> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MPWIN8900CL"),
>> + },
>> + .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
>> + BYT_RT5640_MONO_SPEAKER |
>> + BYT_RT5640_SSP0_AIF1 |
>> + BYT_RT5640_MCLK_EN),
>> + },
>> { /* MSI S100 tablet */
>> .matches = {
>> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."),
>>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Applied "ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet" to the asoc tree
2020-04-05 13:37 [PATCH v3] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet Hans de Goede
2020-04-05 14:08 ` Hans de Goede
2020-04-05 22:55 ` Pierre-Louis Bossart
@ 2020-04-06 14:03 ` Mark Brown
2 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2020-04-06 14:03 UTC (permalink / raw)
To: Hans de Goede
Cc: Oder Chiou, alsa-devel, Jie Yang, Cezary Rojewski,
Pierre-Louis Bossart, Liam Girdwood, Mark Brown, shumingf, flove
The patch
ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
From c8b78f24c1247b7bd0882885c672d9dec5800bc6 Mon Sep 17 00:00:00 2001
From: Hans de Goede <hdegoede@redhat.com>
Date: Sun, 5 Apr 2020 15:37:26 +0200
Subject: [PATCH] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL
tablet
The MPMAN MPWIN895CL tablet almost fully works with out default settings.
The only problem is that it has only 1 speaker so any sounds only playing
on the right channel get lost.
Add a quirk for this model using the default settings + MONO_SPEAKER.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20200405133726.24154-1-hdegoede@redhat.com
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/intel/boards/bytcr_rt5640.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
index 33fb8ea4e5cb..08f4ae964b02 100644
--- a/sound/soc/intel/boards/bytcr_rt5640.c
+++ b/sound/soc/intel/boards/bytcr_rt5640.c
@@ -591,6 +591,17 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = {
BYT_RT5640_SSP0_AIF1 |
BYT_RT5640_MCLK_EN),
},
+ {
+ /* MPMAN MPWIN895CL */
+ .matches = {
+ DMI_EXACT_MATCH(DMI_SYS_VENDOR, "MPMAN"),
+ DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "MPWIN8900CL"),
+ },
+ .driver_data = (void *)(BYTCR_INPUT_DEFAULTS |
+ BYT_RT5640_MONO_SPEAKER |
+ BYT_RT5640_SSP0_AIF1 |
+ BYT_RT5640_MCLK_EN),
+ },
{ /* MSI S100 tablet */
.matches = {
DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Micro-Star International Co., Ltd."),
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-06 14:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-05 13:37 [PATCH v3] ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet Hans de Goede
2020-04-05 14:08 ` Hans de Goede
2020-04-05 22:55 ` Pierre-Louis Bossart
2020-04-06 7:46 ` Hans de Goede
2020-04-06 14:03 ` Applied "ASoC: Intel: bytcr_rt5640: Add quirk for MPMAN MPWIN895CL tablet" to the asoc tree Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).