* [PATCH] ASoC: mxs-saif: Avoid unnecessary check
@ 2020-04-20 14:25 Tang Bin
2020-04-27 13:08 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2020-04-20 14:25 UTC (permalink / raw)
To: broonie, perex, tiwai, shawnguo, s.hauer, lgirdwood
Cc: alsa-devel, Shengju Zhang, linux-kernel, linux-arm-kernel, Tang Bin
The function mxs_saif_probe() is only called with an
openfirmware platform device. Therefore there is no
need to check that it has an openfirmware node.
Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
sound/soc/mxs/mxs-saif.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/mxs/mxs-saif.c b/sound/soc/mxs/mxs-saif.c
index 1e38ce858..64c095b91 100644
--- a/sound/soc/mxs/mxs-saif.c
+++ b/sound/soc/mxs/mxs-saif.c
@@ -736,9 +736,6 @@ static int mxs_saif_probe(struct platform_device *pdev)
int irq, ret = 0;
struct device_node *master;
- if (!np)
- return -EINVAL;
-
saif = devm_kzalloc(&pdev->dev, sizeof(*saif), GFP_KERNEL);
if (!saif)
return -ENOMEM;
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: mxs-saif: Avoid unnecessary check
2020-04-20 14:25 [PATCH] ASoC: mxs-saif: Avoid unnecessary check Tang Bin
@ 2020-04-27 13:08 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2020-04-27 13:08 UTC (permalink / raw)
To: Tang Bin, s.hauer, shawnguo, perex, tiwai, lgirdwood
Cc: alsa-devel, Shengju Zhang, linux-arm-kernel, linux-kernel
On Mon, 20 Apr 2020 22:25:09 +0800, Tang Bin wrote:
> The function mxs_saif_probe() is only called with an
> openfirmware platform device. Therefore there is no
> need to check that it has an openfirmware node.
>
> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8
Thanks!
[1/1] ASoC: mxs-saif: Avoid unnecessary check
commit: e66f385354b3bd29b713d8ab8556aa889723928f
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-27 13:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 14:25 [PATCH] ASoC: mxs-saif: Avoid unnecessary check Tang Bin
2020-04-27 13:08 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).