From: Mark Brown <broonie@kernel.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: dapm: don't call pm_runtime_* on card device
Date: Fri, 24 Jul 2020 14:01:51 +0100 [thread overview]
Message-ID: <20200724130151.GG5664@sirena.org.uk> (raw)
In-Reply-To: <CA+Px+wU-R2qOFK8RhLzTXTqDheZhzOyKuiR-1S9qXj02QdruAA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
On Fri, Jul 24, 2020 at 08:26:13PM +0800, Tzung-Bi Shih wrote:
> On Fri, Jul 24, 2020 at 7:16 PM Mark Brown <broonie@kernel.org> wrote:
> > Why is this a good fix, as opposed to only skipping the set_bias_level()
> > bit?
> Did you mean: skip to call snd_soc_dapm_set_bias_level() in
> dapm_pre_sequence_async() and dapm_post_sequence_async()?
No, I mean why not just add the missing puts which are currently being
skipped due to being caught up with the bias level changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-24 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 7:07 [PATCH] ASoC: dapm: don't call pm_runtime_* on card device Tzung-Bi Shih
2020-07-24 11:16 ` Mark Brown
2020-07-24 12:26 ` Tzung-Bi Shih
2020-07-24 13:01 ` Mark Brown [this message]
2020-07-24 14:41 ` Tzung-Bi Shih
2020-07-24 16:42 ` Mark Brown
2020-07-24 16:38 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724130151.GG5664@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).