alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH v2 0/2] soundwire: use {u32|u16}p_replace_bits
@ 2020-09-18 12:10 Liao, Bard
  2020-09-18 12:20 ` Vinod Koul
  0 siblings, 1 reply; 3+ messages in thread
From: Liao, Bard @ 2020-09-18 12:10 UTC (permalink / raw)
  To: Vinod Koul, alsa-devel
  Cc: Kale, Sanyog R, Srinivas Kandagatla, Pierre-Louis Bossart, Liao, Bard


On 9/17/2020 8:01 PM, Vinod Koul wrote:
> This is v2 of the series to fix usage of FIELD_PREP and use
> {u32|u16}p_replace_bits.
>
> v1 used u32_replace_bits but looks like it might be removed so use the
> {u32|u16}p_replace_bits() instead. Also this helped to find that one
> instance in intel driver should have used u16p_replace_bits() so that is
> fixed too
>
> Vinod Koul (2):
> soundwire: cadence: use u32p_replace_bits
> soundwire: intel: use {u32|u16}p_replace_bits
>
> drivers/soundwire/cadence_master.c | 21 ++++++++++-----------
> drivers/soundwire/intel.c | 14 +++++++-------
> 2 files changed, 17 insertions(+), 18 deletions(-)

Tested it on a Intel platform. So

Tested-by: Bard Liao <yung-chuan.liao@linux.intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 0/2] soundwire: use {u32|u16}p_replace_bits
  2020-09-18 12:10 [PATCH v2 0/2] soundwire: use {u32|u16}p_replace_bits Liao, Bard
@ 2020-09-18 12:20 ` Vinod Koul
  0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2020-09-18 12:20 UTC (permalink / raw)
  To: Liao, Bard
  Cc: alsa-devel, Srinivas Kandagatla, Kale, Sanyog R, Pierre-Louis Bossart

On 18-09-20, 12:10, Liao, Bard wrote:
> 
> On 9/17/2020 8:01 PM, Vinod Koul wrote:
> > This is v2 of the series to fix usage of FIELD_PREP and use
> > {u32|u16}p_replace_bits.
> >
> > v1 used u32_replace_bits but looks like it might be removed so use the
> > {u32|u16}p_replace_bits() instead. Also this helped to find that one
> > instance in intel driver should have used u16p_replace_bits() so that is
> > fixed too
> >
> > Vinod Koul (2):
> > soundwire: cadence: use u32p_replace_bits
> > soundwire: intel: use {u32|u16}p_replace_bits
> >
> > drivers/soundwire/cadence_master.c | 21 ++++++++++-----------
> > drivers/soundwire/intel.c | 14 +++++++-------
> > 2 files changed, 17 insertions(+), 18 deletions(-)
> 
> Tested it on a Intel platform. So
> 
> Tested-by: Bard Liao <yung-chuan.liao@linux.intel.com>

Thanks Bard, applied now

-- 
~Vinod

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 0/2] soundwire: use {u32|u16}p_replace_bits
@ 2020-09-17 12:01 Vinod Koul
  0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2020-09-17 12:01 UTC (permalink / raw)
  To: alsa-devel
  Cc: Srinivas Kandagatla, Sanyog Kale, Bard Liao,
	Pierre-Louis Bossart, Vinod Koul

This is v2 of the series to fix usage of FIELD_PREP and use
{u32|u16}p_replace_bits.

v1 used u32_replace_bits but looks like it might be removed so use the
{u32|u16}p_replace_bits() instead. Also this helped to find that one
instance in intel driver should have used u16p_replace_bits() so that is
fixed too

Vinod Koul (2):
  soundwire: cadence: use u32p_replace_bits
  soundwire: intel: use {u32|u16}p_replace_bits

 drivers/soundwire/cadence_master.c | 21 ++++++++++-----------
 drivers/soundwire/intel.c          | 14 +++++++-------
 2 files changed, 17 insertions(+), 18 deletions(-)

-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-09-18 12:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 12:10 [PATCH v2 0/2] soundwire: use {u32|u16}p_replace_bits Liao, Bard
2020-09-18 12:20 ` Vinod Koul
  -- strict thread matches above, loose matches on Subject: below --
2020-09-17 12:01 Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).