alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ALSA: usb-audio: Add quirk for RC-505
@ 2021-01-02 19:00 Timon Reinold
       [not found] ` <20210102210835.21268-1-tirei@agon.one>
  0 siblings, 1 reply; 2+ messages in thread
From: Timon Reinold @ 2021-01-02 19:00 UTC (permalink / raw)
  To: tiwai, perex, alsa-devel; +Cc: Harry Reinold, Timon Reinold

BOSS RC-505 (shown by lsusb as "Roland Corp. RC-505") does require the
same quirk as these other BOSS devices.

Without this quirk it is neither possible to capture audio from nor to
write audio to the RC-505. Both just result in an empty audio
stream. With these changes both capture and playback seem to work
quite fine. MIDI funtionality was not tested.

Tested-by: Harry Reinold <harry.reinold@posteo.de>
Signed-off-by: Timon Reinold <tirei@agon.one>
---

We found the hint to enable the same quirk as reqired by the BOSS
Katana for the RC-505 in this post:
https://old.reddit.com/r/linuxaudio/comments/fom7z4/roland_rc505_usb_audio_interface/frfgrfw/
But none of the code posted there was used (since that predates
implicit.c), so I think that shouldn't create any copyright
problems.

We're currently running the older version of this patch (without
implicit.c) on Linux Mint and it seems quite stable so far. We did
also test this version of the patch and that seems to work fine, too.

Yours sincerely,
Timon Reinold

 sound/usb/implicit.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/usb/implicit.c b/sound/usb/implicit.c
index 70b9777b2e63..2d7f747c0237 100644
--- a/sound/usb/implicit.c
+++ b/sound/usb/implicit.c
@@ -79,6 +79,7 @@ static const struct snd_usb_implicit_fb_match playback_implicit_fb_quirks[] = {
 	IMPLICIT_FB_SKIP_DEV(0x0582, 0x01d8),	/* BOSS Katana */
 	IMPLICIT_FB_SKIP_DEV(0x0582, 0x01e5),	/* BOSS GT-001 */
 	IMPLICIT_FB_SKIP_DEV(0x0582, 0x0203),   /* BOSS AD-10 */
+	IMPLICIT_FB_SKIP_DEV(0x0582, 0x0171),   /* BOSS RC-505 */
 
 	{} /* terminator */
 };
@@ -91,6 +92,7 @@ static const struct snd_usb_implicit_fb_match capture_implicit_fb_quirks[] = {
 	IMPLICIT_FB_FIXED_DEV(0x0582, 0x01d8, 0x0d, 0x01), /* BOSS Katana */
 	IMPLICIT_FB_FIXED_DEV(0x0582, 0x01e5, 0x0d, 0x01), /* BOSS GT-001 */
 	IMPLICIT_FB_FIXED_DEV(0x0582, 0x0203, 0x0d, 0x01), /* BOSS AD-10 */
+	IMPLICIT_FB_FIXED_DEV(0x0582, 0x0171, 0x0d, 0x01), /* BOSS RC-505 */
 
 	{} /* terminator */
 };
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ALSA: usb-audio: Add quirk for RC-505
       [not found] ` <20210102210835.21268-1-tirei@agon.one>
@ 2021-01-03  8:00   ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2021-01-03  8:00 UTC (permalink / raw)
  To: Timon Reinold; +Cc: alsa-devel, Harry Reinold, tiwai

On Sat, 02 Jan 2021 22:08:35 +0100,
Timon Reinold wrote:
> 
> BOSS RC-505 (shown by lsusb as "Roland Corp. RC-505") does require the
> same quirk as these other BOSS devices.
> 
> Without this quirk it is neither possible to capture audio from nor to
> write audio to the RC-505. Both just result in an empty audio
> stream. With these changes both capture and playback seem to work
> quite fine. MIDI funtionality was not tested.
> 
> Tested-by: Harry Reinold <harry.reinold@posteo.de>
> Signed-off-by: Timon Reinold <tirei@agon.one>
> ---
> 
> I just noticed that these entries should be sorted by ID. Sorry for that.

Thanks, applied now.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-03  8:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-02 19:00 [PATCH] ALSA: usb-audio: Add quirk for RC-505 Timon Reinold
     [not found] ` <20210102210835.21268-1-tirei@agon.one>
2021-01-03  8:00   ` [PATCH v2] " Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).