* [PATCH] ALSA: hda/hdmi - enable runtime pm for CI AMD display audio
@ 2021-01-05 17:52 Alex Deucher
2021-01-12 15:00 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2021-01-05 17:52 UTC (permalink / raw)
To: amd-gfx, alsa-devel; +Cc: Alex Deucher, Evan Quan
We are able to power down the GPU and audio via the GPU driver
so flag these asics as supporting runtime pm.
Reviewed-by: Evan Quan <evan.quan@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
sound/pci/hda/hda_intel.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index d539f52009a1..2ea46b5a9a23 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2597,7 +2597,8 @@ static const struct pci_device_id azx_ids[] = {
.driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB },
/* ATI HDMI */
{ PCI_DEVICE(0x1002, 0x0002),
- .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
+ .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
+ AZX_DCAPS_PM_RUNTIME },
{ PCI_DEVICE(0x1002, 0x1308),
.driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
{ PCI_DEVICE(0x1002, 0x157a),
@@ -2659,9 +2660,11 @@ static const struct pci_device_id azx_ids[] = {
{ PCI_DEVICE(0x1002, 0xaab0),
.driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
{ PCI_DEVICE(0x1002, 0xaac0),
- .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
+ .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
+ AZX_DCAPS_PM_RUNTIME },
{ PCI_DEVICE(0x1002, 0xaac8),
- .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
+ .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
+ AZX_DCAPS_PM_RUNTIME },
{ PCI_DEVICE(0x1002, 0xaad8),
.driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
AZX_DCAPS_PM_RUNTIME },
--
2.29.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/hdmi - enable runtime pm for CI AMD display audio
2021-01-05 17:52 [PATCH] ALSA: hda/hdmi - enable runtime pm for CI AMD display audio Alex Deucher
@ 2021-01-12 15:00 ` Takashi Iwai
2021-01-12 15:03 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2021-01-12 15:00 UTC (permalink / raw)
To: Alex Deucher; +Cc: Alex Deucher, alsa-devel, Evan Quan, amd-gfx
On Tue, 05 Jan 2021 18:52:45 +0100,
Alex Deucher wrote:
>
> We are able to power down the GPU and audio via the GPU driver
> so flag these asics as supporting runtime pm.
>
> Reviewed-by: Evan Quan <evan.quan@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
I wanted to apply this one now, but noticed that the author address
(gmail) is different from your S-o-b address (amd.com).
Alex, is this intentional and keep it, or should I correct the author
address?
thanks,
Takashi
> ---
> sound/pci/hda/hda_intel.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index d539f52009a1..2ea46b5a9a23 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2597,7 +2597,8 @@ static const struct pci_device_id azx_ids[] = {
> .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB },
> /* ATI HDMI */
> { PCI_DEVICE(0x1002, 0x0002),
> - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> + AZX_DCAPS_PM_RUNTIME },
> { PCI_DEVICE(0x1002, 0x1308),
> .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> { PCI_DEVICE(0x1002, 0x157a),
> @@ -2659,9 +2660,11 @@ static const struct pci_device_id azx_ids[] = {
> { PCI_DEVICE(0x1002, 0xaab0),
> .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> { PCI_DEVICE(0x1002, 0xaac0),
> - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> + AZX_DCAPS_PM_RUNTIME },
> { PCI_DEVICE(0x1002, 0xaac8),
> - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> + AZX_DCAPS_PM_RUNTIME },
> { PCI_DEVICE(0x1002, 0xaad8),
> .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> AZX_DCAPS_PM_RUNTIME },
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/hdmi - enable runtime pm for CI AMD display audio
2021-01-12 15:00 ` Takashi Iwai
@ 2021-01-12 15:03 ` Alex Deucher
2021-01-12 15:06 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2021-01-12 15:03 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Alex Deucher, alsa-devel, Evan Quan, amd-gfx list
On Tue, Jan 12, 2021 at 10:00 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Tue, 05 Jan 2021 18:52:45 +0100,
> Alex Deucher wrote:
> >
> > We are able to power down the GPU and audio via the GPU driver
> > so flag these asics as supporting runtime pm.
> >
> > Reviewed-by: Evan Quan <evan.quan@amd.com>
> > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>
> I wanted to apply this one now, but noticed that the author address
> (gmail) is different from your S-o-b address (amd.com).
> Alex, is this intentional and keep it, or should I correct the author
> address?
The s-o-b address is the correct one. Thanks!
Alex
>
>
> thanks,
>
> Takashi
>
> > ---
> > sound/pci/hda/hda_intel.c | 9 ++++++---
> > 1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> > index d539f52009a1..2ea46b5a9a23 100644
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -2597,7 +2597,8 @@ static const struct pci_device_id azx_ids[] = {
> > .driver_data = AZX_DRIVER_GENERIC | AZX_DCAPS_PRESET_AMD_SB },
> > /* ATI HDMI */
> > { PCI_DEVICE(0x1002, 0x0002),
> > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > { PCI_DEVICE(0x1002, 0x1308),
> > .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> > { PCI_DEVICE(0x1002, 0x157a),
> > @@ -2659,9 +2660,11 @@ static const struct pci_device_id azx_ids[] = {
> > { PCI_DEVICE(0x1002, 0xaab0),
> > .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> > { PCI_DEVICE(0x1002, 0xaac0),
> > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > { PCI_DEVICE(0x1002, 0xaac8),
> > - .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS },
> > + .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > + AZX_DCAPS_PM_RUNTIME },
> > { PCI_DEVICE(0x1002, 0xaad8),
> > .driver_data = AZX_DRIVER_ATIHDMI_NS | AZX_DCAPS_PRESET_ATI_HDMI_NS |
> > AZX_DCAPS_PM_RUNTIME },
> > --
> > 2.29.2
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: hda/hdmi - enable runtime pm for CI AMD display audio
2021-01-12 15:03 ` Alex Deucher
@ 2021-01-12 15:06 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-01-12 15:06 UTC (permalink / raw)
To: Alex Deucher; +Cc: Alex Deucher, alsa-devel, Evan Quan, amd-gfx list
On Tue, 12 Jan 2021 16:03:41 +0100,
Alex Deucher wrote:
>
> On Tue, Jan 12, 2021 at 10:00 AM Takashi Iwai <tiwai@suse.de> wrote:
> >
> > On Tue, 05 Jan 2021 18:52:45 +0100,
> > Alex Deucher wrote:
> > >
> > > We are able to power down the GPU and audio via the GPU driver
> > > so flag these asics as supporting runtime pm.
> > >
> > > Reviewed-by: Evan Quan <evan.quan@amd.com>
> > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> >
> > I wanted to apply this one now, but noticed that the author address
> > (gmail) is different from your S-o-b address (amd.com).
> > Alex, is this intentional and keep it, or should I correct the author
> > address?
>
> The s-o-b address is the correct one. Thanks!
Alright, now applied. Thanks!
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-12 15:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 17:52 [PATCH] ALSA: hda/hdmi - enable runtime pm for CI AMD display audio Alex Deucher
2021-01-12 15:00 ` Takashi Iwai
2021-01-12 15:03 ` Alex Deucher
2021-01-12 15:06 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).