alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: amd: acp6x-pdm-dma: Constify static snd_soc_dai_ops
@ 2021-12-04 11:08 Rikard Falkeborn
  2021-12-06 18:00 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Rikard Falkeborn @ 2021-12-04 11:08 UTC (permalink / raw)
  To: Vijendar Mukunda, Liam Girdwood, Mark Brown
  Cc: linux-kernel, alsa-devel, Takashi Iwai, Rikard Falkeborn

The only usage of acp6x_pdm_dai_ops is to assign its address to the ops
field in the snd_soc_dai_driver struct, which is a pointer to const
snd_soc_dai_ops. Make it const to allow the compiler to put it in
read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 sound/soc/amd/yc/acp6x-pdm-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/amd/yc/acp6x-pdm-dma.c b/sound/soc/amd/yc/acp6x-pdm-dma.c
index e604f4ea524f..7e66393e4153 100644
--- a/sound/soc/amd/yc/acp6x-pdm-dma.c
+++ b/sound/soc/amd/yc/acp6x-pdm-dma.c
@@ -318,7 +318,7 @@ static int acp6x_pdm_dai_trigger(struct snd_pcm_substream *substream,
 	return ret;
 }
 
-static struct snd_soc_dai_ops acp6x_pdm_dai_ops = {
+static const struct snd_soc_dai_ops acp6x_pdm_dai_ops = {
 	.trigger   = acp6x_pdm_dai_trigger,
 };
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: amd: acp6x-pdm-dma: Constify static snd_soc_dai_ops
  2021-12-04 11:08 [PATCH] ASoC: amd: acp6x-pdm-dma: Constify static snd_soc_dai_ops Rikard Falkeborn
@ 2021-12-06 18:00 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-12-06 18:00 UTC (permalink / raw)
  To: Rikard Falkeborn, Vijendar Mukunda, Liam Girdwood
  Cc: linux-kernel, alsa-devel, Takashi Iwai

On Sat, 4 Dec 2021 12:08:48 +0100, Rikard Falkeborn wrote:
> The only usage of acp6x_pdm_dai_ops is to assign its address to the ops
> field in the snd_soc_dai_driver struct, which is a pointer to const
> snd_soc_dai_ops. Make it const to allow the compiler to put it in
> read-only memory.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: acp6x-pdm-dma: Constify static snd_soc_dai_ops
      commit: 7bef00106bc68beddcddcd06e3b02dde5525face

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-06 18:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-04 11:08 [PATCH] ASoC: amd: acp6x-pdm-dma: Constify static snd_soc_dai_ops Rikard Falkeborn
2021-12-06 18:00 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).