alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* Add support for some non-alphanumeric variable names in the math expr evaluator
       [not found] <1638859636214114904-webhooks-bot@alsa-project.org>
@ 2021-12-07  6:47 ` GitHub issues - edited
  0 siblings, 0 replies; 3+ messages in thread
From: GitHub issues - edited @ 2021-12-07  6:47 UTC (permalink / raw)
  To: alsa-devel

alsa-project/alsa-lib issue #197 was edited from ranj063:

The math expression evaluator expects variable names to only be alpha-numeric. So if I have something like "[$DYNAMIC_PIPELINE + 2]", I get the error:

ALSA lib confeval.c:263:(snd_config_evaluate_string) wrong expression '$[$DYNAMIC_PIPELINE + 77]'
ALSA lib conf.c:5632:(snd_config_expand_custom) Expand error (walk): Invalid argument
Failed to expand pre-processor definitions in input config

Is it possible to add support for some non-alphanumeric characters in the variable names , esp '_'? I tried this change it seems to suffice:
```
diff --git a/src/confeval.c b/src/confeval.c
index a971bf38..7330d67e 100644
--- a/src/confeval.c
+++ b/src/confeval.c
@@ -190,7 +190,7 @@ int _snd_eval_string(snd_config_t **dst, const char *s,
                        } else {
                                e = s + 1;
                                while (*e) {
-                                       if (!isalnum(*e))
+                                       if (!isalnum(*e) && (*e != '_'))
                                                break;
                                        e++;
                                }

```

Issue URL     : https://github.com/alsa-project/alsa-lib/issues/197
Repository URL: https://github.com/alsa-project/alsa-lib

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Add support for some non-alphanumeric variable names in the math expr evaluator
       [not found] <1638859659063849926-webhooks-bot@alsa-project.org>
@ 2021-12-07  6:47 ` GitHub issues - edited
  0 siblings, 0 replies; 3+ messages in thread
From: GitHub issues - edited @ 2021-12-07  6:47 UTC (permalink / raw)
  To: alsa-devel

alsa-project/alsa-lib issue #197 was edited from ranj063:

The math expression evaluator expects variable names to only be alpha-numeric. So if I have something like "[$DYNAMIC_PIPELINE + 2]", I get the error:

ALSA lib confeval.c:263:(snd_config_evaluate_string) wrong expression '$[$DYNAMIC_PIPELINE + 2]'
ALSA lib conf.c:5632:(snd_config_expand_custom) Expand error (walk): Invalid argument
Failed to expand pre-processor definitions in input config

Is it possible to add support for some non-alphanumeric characters in the variable names , esp '_'? I tried this change it seems to suffice:
```
diff --git a/src/confeval.c b/src/confeval.c
index a971bf38..7330d67e 100644
--- a/src/confeval.c
+++ b/src/confeval.c
@@ -190,7 +190,7 @@ int _snd_eval_string(snd_config_t **dst, const char *s,
                        } else {
                                e = s + 1;
                                while (*e) {
-                                       if (!isalnum(*e))
+                                       if (!isalnum(*e) && (*e != '_'))
                                                break;
                                        e++;
                                }

```

Issue URL     : https://github.com/alsa-project/alsa-lib/issues/197
Repository URL: https://github.com/alsa-project/alsa-lib

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Add support for some non-alphanumeric variable names in the math expr evaluator
       [not found] <1638859531323084116-webhooks-bot@alsa-project.org>
@ 2021-12-07  6:45 ` GitHub issues - opened
  0 siblings, 0 replies; 3+ messages in thread
From: GitHub issues - opened @ 2021-12-07  6:45 UTC (permalink / raw)
  To: alsa-devel

alsa-project/alsa-lib issue #197 was opened from ranj063:

The math expression evaluator expects variable names to only be alpha-numeric. So if I have something like "[$DMIC_CH_COUNT + 2]", I get the error:

Issue URL     : https://github.com/alsa-project/alsa-lib/issues/197
Repository URL: https://github.com/alsa-project/alsa-lib

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-12-07  6:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1638859636214114904-webhooks-bot@alsa-project.org>
2021-12-07  6:47 ` Add support for some non-alphanumeric variable names in the math expr evaluator GitHub issues - edited
     [not found] <1638859659063849926-webhooks-bot@alsa-project.org>
2021-12-07  6:47 ` GitHub issues - edited
     [not found] <1638859531323084116-webhooks-bot@alsa-project.org>
2021-12-07  6:45 ` GitHub issues - opened

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).