From: Ameer Hamza <amhamza.mgc@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>,
"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: test-component: fix null pointer dereference.
Date: Tue, 7 Dec 2021 13:15:22 +0500 [thread overview]
Message-ID: <20211207081522.GA9690@hamza-OptiPlex-7040> (raw)
In-Reply-To: <TYCPR01MB5581998AD64AE249C7D86C26D46D9@TYCPR01MB5581.jpnprd01.prod.outlook.com>
On Mon, Dec 06, 2021 at 11:19:36PM +0000, Kuninori Morimoto wrote:
>
> Hi Ameer
>
> >> Probing this driver without adata is strange for me.
> >> How did probe this driver ??
> >
> > Thank you for your response. Unfortunately, I am not aware of
> > implementation details of this component. Coverity suggested that there
> > can be a potential NULL pointer access which seems logical to me. Do you
> > agree with coverity here?
>
> I think no potential NULL pointer access, because this driver can't
> be called without of_id->data.
> But, potential NULL pointer check itself is good idea.
> It seems your patch was already accepted :)
Yes, indeed.
> I noticed that we can replace it to use of_device_get_match_data()
>
> - const struct of_device_id *of_id = of_match_device(test_of_match, &pdev->dev);
> - const struct test_adata *adata = of_id->data;
> + const struct test_adata *adata = of_device_get_match_data(&pdev->dev);
Thanks, that's a cleaner way. Can you advise how should proceed with
this since previous patch is already applied. Should I send a updated
version of patch, e.g., v2 or a new patch.
>
> Best regards
> ---
> Kuninori Morimoto
next prev parent reply other threads:[~2021-12-07 8:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 20:42 [PATCH] ASoC: test-component: fix null pointer dereference Ameer Hamza
2021-12-05 22:40 ` Kuninori Morimoto
2021-12-06 9:29 ` Ameer Hamza
2021-12-06 23:19 ` Kuninori Morimoto
2021-12-07 8:15 ` Ameer Hamza [this message]
2021-12-07 12:51 ` Mark Brown
2021-12-07 14:23 ` [PATCH v2] " Ameer Hamza
2021-12-08 0:05 ` Kuninori Morimoto
2021-12-08 12:05 ` Ameer Hamza
2021-12-08 12:36 ` [PATCH] ASoC: test-component: replace of_match_device() to of_device_get_match_data() Ameer Hamza
2021-12-08 12:40 ` Ameer Hamza
2021-12-08 22:40 ` Kuninori Morimoto
2021-12-09 13:45 ` [PATCH v2] ASoC: test-component: fix null pointer dereference Mark Brown
2021-12-07 23:53 ` [PATCH] " Kuninori Morimoto
2021-12-06 18:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211207081522.GA9690@hamza-OptiPlex-7040 \
--to=amhamza.mgc@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).