From: Mark Brown <broonie@kernel.org>
To: Ameer Hamza <amhamza.mgc@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>
Subject: Re: [PATCH] ASoC: test-component: fix null pointer dereference.
Date: Tue, 7 Dec 2021 12:51:18 +0000 [thread overview]
Message-ID: <Ya9YxoUqkATCOASh@sirena.org.uk> (raw)
In-Reply-To: <20211207081522.GA9690@hamza-OptiPlex-7040>
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Tue, Dec 07, 2021 at 01:15:22PM +0500, Ameer Hamza wrote:
> On Mon, Dec 06, 2021 at 11:19:36PM +0000, Kuninori Morimoto wrote:
> > - const struct test_adata *adata = of_id->data;
> > + const struct test_adata *adata = of_device_get_match_data(&pdev->dev);
> Thanks, that's a cleaner way. Can you advise how should proceed with
> this since previous patch is already applied. Should I send a updated
> version of patch, e.g., v2 or a new patch.
Please send an incremental patch on top of what is already applied as
covered in the message saying the patch was applied.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-12-07 12:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 20:42 [PATCH] ASoC: test-component: fix null pointer dereference Ameer Hamza
2021-12-05 22:40 ` Kuninori Morimoto
2021-12-06 9:29 ` Ameer Hamza
2021-12-06 23:19 ` Kuninori Morimoto
2021-12-07 8:15 ` Ameer Hamza
2021-12-07 12:51 ` Mark Brown [this message]
2021-12-07 14:23 ` [PATCH v2] " Ameer Hamza
2021-12-08 0:05 ` Kuninori Morimoto
2021-12-08 12:05 ` Ameer Hamza
2021-12-08 12:36 ` [PATCH] ASoC: test-component: replace of_match_device() to of_device_get_match_data() Ameer Hamza
2021-12-08 12:40 ` Ameer Hamza
2021-12-08 22:40 ` Kuninori Morimoto
2021-12-09 13:45 ` [PATCH v2] ASoC: test-component: fix null pointer dereference Mark Brown
2021-12-07 23:53 ` [PATCH] " Kuninori Morimoto
2021-12-06 18:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya9YxoUqkATCOASh@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=amhamza.mgc@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).