[PATCH] ASoC: AMD: acp-config: fix missing dependency on SND_SOC_ACPI

[PATCH] ASoC: AMD: acp-config: fix missing dependency on SND_SOC_ACPI

[Pierre-Louis Bossart]

With a custom .config, the following error is thrown:

ERROR: modpost: "snd_soc_acpi_codec_list"
[sound/soc/amd/snd-acp-config.ko] undefined!

Fix by adding a clear dependency on SND_SOC_ACPI

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
---
 sound/soc/amd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index 8961b8fd23eb..bcfeb3fc2592 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -98,6 +98,7 @@ config SND_SOC_AMD_YC_MACH
 
 config SND_AMD_ACP_CONFIG
 	tristate "AMD ACP configuration selection"
+	depends on SND_SOC_ACPI
 	help
 	 This option adds an auto detection to determine which ACP
 	 driver modules to use
-- 
2.25.1

Re: [PATCH] ASoC: AMD: acp-config: fix missing dependency on SND_SOC_ACPI

[Mark Brown]

On Tue, 7 Dec 2021 13:23:09 -0600, Pierre-Louis Bossart wrote:
> With a custom .config, the following error is thrown:
> 
> ERROR: modpost: "snd_soc_acpi_codec_list"
> [sound/soc/amd/snd-acp-config.ko] undefined!
> 
> Fix by adding a clear dependency on SND_SOC_ACPI
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: AMD: acp-config: fix missing dependency on SND_SOC_ACPI
      commit: d9b994cd7641ad8eda97aa8633f4e2f35d7d0a79

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark