Re: [PATCH] wm8962: add a simple DMIC enable control

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Fri, Feb 04, 2022 at 10:43:53AM +0100, Martin Kepplinger wrote:
> yes my bad :) If I may, just let me describe my situation again and see
> whether anything else comes to your mind.
> 
> It's weird but I when I set "Capture Volume" to 60 instead of 29, I
> didn't hear a difference.
> 
> So far I don't hear a difference when setting "INPGAR IN1R Switch" on.
> 
> Does "Value" in this ucm description make any sense to you?

Mostly a couple comments inline.

> 
> EnableSequence [                                                      
>                 cset "name='Digital Capture Volume' 127,127"          
>                 cset "name='Capture Volume' 63,63"                    
>                 cset "name='MIXINR IN3R Switch' on"                   
>                 cset "name='MIXINR IN3R Volume' 7"                    
>                 cset "name='INPGAR IN1R Switch' on"                   
>                 cset "name='Input Mode' Analog"                       

Little hard to say without the rest of the ucm file (happy to
have a look at that if you had a handy link?), but this
looks a bit weird. Why are you connecting the MIXINR IN3R stuff
here, you want to go through the PGA most likely?

>         ]                                                             
>                                                                       
> DisableSequence [                                                     
>                 cset "name='INPGAR IN1R Switch' off"                  
>                 cset "name='MIXINR IN3R Switch' off"                  
>                 cset "name='MIXINR IN3R Volume' 0"                    
>                 cset "name='Input Mode' Digital"                      
>         ]                                                             
>                                                                       
> Value {                                                               
>                 CapturePriority "100"                                 
>                 CaptureChannels "2"                                   
>                 CaptureSwitch "name='MIXINR IN3R Volume'"             

This should probably be CaptureVolume, rather than CaptureSwitch.

>                 CaptureSwitch "name='MIXINR IN3R Switch'"             
>                 CapturePCM "hw:${CardId},0"                           
>                 JackControl "Headphones Jack"                         

Assuming your machine driver creates an appropriately named
control.

>         }
> 
> 
> Let me just append the correct amixer contents where I hear my usual
> "quiet and bad signal" recording:

> numid=11,iface=MIXER,name='Capture Switch'
>   ; type=BOOLEAN,access=rw------,values=2
>   : values=off,off

This still looks weird, I wouldn't expect you would hear anything
with the "Capture Switch" off, it mutes the PGA. Can you confirm
if this is on whilst you are actually capturing audio?

> numid=84,iface=MIXER,name='INPGAR IN1R Switch'
>   ; type=BOOLEAN,access=rw------,values=1
>   : values=on

I definitely would consider turning this on as just a test thing
not a recommendation on how the part should be used, until we see
if it helps. It was just a weird hunch, I feel the routing is
probably more sensible without it.

> numid=92,iface=MIXER,name='MIXINR IN3R Switch'
>   ; type=BOOLEAN,access=rw------,values=1
>   : values=on
> numid=93,iface=MIXER,name='MIXINR PGA Switch'
>   ; type=BOOLEAN,access=rw------,values=1
>   : values=on

I don't think you should have both the IN3R and PGA switches
enabled at once. I would suggest only using the PGA switch.

Ok, I think what is happening here is you have both of
these connected, and because you have the PGA muted, you are
only hearing the unboosted mic signal coming through MIXINR
IN3R. This would explain both why the Capture Volume has no
effect and why your signal is quiet.

Thanks,
Charles