Re: [PATCH] wm8962: add a simple DMIC enable control

[Charles Keepax <ckeepax@opensource.cirrus.com>]

On Wed, Mar 02, 2022 at 03:11:00PM +0100, Martin Kepplinger wrote:
> Am Mittwoch, dem 02.03.2022 um 13:40 +0000 schrieb Charles Keepax:
> > On Wed, Mar 02, 2022 at 12:48:28PM +0100, Martin Kepplinger wrote:
> > > Am Dienstag, dem 01.03.2022 um 15:00 +0100 schrieb Martin
> > > > Am Dienstag, dem 01.03.2022 um 13:44 +0000 schrieb Charles
> > > > > On Mon, Feb 07, 2022 at 02:21:29PM +0000, Charles Keepax wrote:
> > > > > > On Mon, Feb 07, 2022 at 11:49:32AM +0100, Martin Kepplinger
> > > > > > > Am Freitag, dem 04.02.2022 um 17:21 +0000 schrieb Charles
> > > > > > > > On Fri, Feb 04, 2022 at 10:43:53AM +0100, Martin
> > Although your previous control dumps had that input set
> > on. I suspect if you have both enabled you will get some slightly
> > weird effects, there is probably a slightly phase delay through
> > the PGA and there won't be on the direct path, so when they mix
> > together it will likely sound weird.
> 
> it was not that bad but with your changes, especially a recorded "s"
> sounds indeed better now.
> 

Awesome hopefully that should be us getting pretty close.

> > Hopefully that gets us to a clean signal. The settings described
> > in your commit message give +9dB analogue gain which seems
> > reasonable to me, and from the patch itself looks like you have
> > +15dB digital gain, which feels a little high but not total
> > unreasonable.
> I left MIXINR PGA Volume at 1 and Capture Volume ("Input PGA Volume
> Control") at 39 for now since I think it shouldn't be quieter than that
> at least.

I think we probably bump the PGA gain up another 3dB, maybe even
6dB if you really need to, I would just be careful to test some
very loud sound levels to make sure your not starting to clip the
signal.

Thanks,
Charles