* [PATCH] ASoC: Intel: avs: correct config reference for I2S test board
@ 2022-07-05 10:32 Lukas Bulwahn
2022-07-05 10:48 ` Amadeusz Sławiński
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lukas Bulwahn @ 2022-07-05 10:32 UTC (permalink / raw)
To: Amadeusz Sławiński, Cezary Rojewski, Mark Brown, alsa-devel
Cc: Kai Vehmanen, Peter Ujfalusi, Takashi Iwai, kernel-janitors,
Pierre-Louis Bossart, Ranjani Sridharan, Liam Girdwood,
Lukas Bulwahn, Bard Liao, linux-kernel
Commit e39acc4cfd92 ("ASoC: Intel: avs: Add I2S-test machine board") adds
the config "SND_SOC_INTEL_AVS_MACH_I2S_TEST", but in the Makefile refers
to config "SND_SOC_INTEL_AVS_MACH_i2s_TEST" (notice the uppercase and
lowercase difference).
Adjust the Makefile to refer to the actual existing config.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Amadeusz, Cezary, please ack.
Mark, please pick this minor build config fix.
sound/soc/intel/avs/boards/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/intel/avs/boards/Makefile b/sound/soc/intel/avs/boards/Makefile
index 25e8c4bb07db..bc75376d58c2 100644
--- a/sound/soc/intel/avs/boards/Makefile
+++ b/sound/soc/intel/avs/boards/Makefile
@@ -16,7 +16,7 @@ snd-soc-avs-ssm4567-objs := ssm4567.o
obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_DA7219) += snd-soc-avs-da7219.o
obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_DMIC) += snd-soc-avs-dmic.o
obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_HDAUDIO) += snd-soc-avs-hdaudio.o
-obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_i2s_TEST) += snd-soc-avs-i2s-test.o
+obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_I2S_TEST) += snd-soc-avs-i2s-test.o
obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_MAX98357A) += snd-soc-avs-max98357a.o
obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_MAX98373) += snd-soc-avs-max98373.o
obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_NAU8825) += snd-soc-avs-nau8825.o
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: Intel: avs: correct config reference for I2S test board
2022-07-05 10:32 [PATCH] ASoC: Intel: avs: correct config reference for I2S test board Lukas Bulwahn
@ 2022-07-05 10:48 ` Amadeusz Sławiński
2022-07-05 10:51 ` Cezary Rojewski
2022-07-05 18:52 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Amadeusz Sławiński @ 2022-07-05 10:48 UTC (permalink / raw)
To: Lukas Bulwahn, Cezary Rojewski, Mark Brown, alsa-devel
Cc: Pierre-Louis Bossart, Kai Vehmanen, Bard Liao, kernel-janitors,
Ranjani Sridharan, Takashi Iwai, Liam Girdwood, Peter Ujfalusi,
linux-kernel
On 7/5/2022 12:32 PM, Lukas Bulwahn wrote:
> Commit e39acc4cfd92 ("ASoC: Intel: avs: Add I2S-test machine board") adds
> the config "SND_SOC_INTEL_AVS_MACH_I2S_TEST", but in the Makefile refers
> to config "SND_SOC_INTEL_AVS_MACH_i2s_TEST" (notice the uppercase and
> lowercase difference).
>
> Adjust the Makefile to refer to the actual existing config.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Amadeusz, Cezary, please ack.
>
> Mark, please pick this minor build config fix.
>
> sound/soc/intel/avs/boards/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/avs/boards/Makefile b/sound/soc/intel/avs/boards/Makefile
> index 25e8c4bb07db..bc75376d58c2 100644
> --- a/sound/soc/intel/avs/boards/Makefile
> +++ b/sound/soc/intel/avs/boards/Makefile
> @@ -16,7 +16,7 @@ snd-soc-avs-ssm4567-objs := ssm4567.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_DA7219) += snd-soc-avs-da7219.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_DMIC) += snd-soc-avs-dmic.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_HDAUDIO) += snd-soc-avs-hdaudio.o
> -obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_i2s_TEST) += snd-soc-avs-i2s-test.o
> +obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_I2S_TEST) += snd-soc-avs-i2s-test.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_MAX98357A) += snd-soc-avs-max98357a.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_MAX98373) += snd-soc-avs-max98373.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_NAU8825) += snd-soc-avs-nau8825.o
Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: Intel: avs: correct config reference for I2S test board
2022-07-05 10:32 [PATCH] ASoC: Intel: avs: correct config reference for I2S test board Lukas Bulwahn
2022-07-05 10:48 ` Amadeusz Sławiński
@ 2022-07-05 10:51 ` Cezary Rojewski
2022-07-05 18:52 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Cezary Rojewski @ 2022-07-05 10:51 UTC (permalink / raw)
To: Lukas Bulwahn, Amadeusz Sławiński, Mark Brown, alsa-devel
Cc: Kai Vehmanen, Peter Ujfalusi, Takashi Iwai, kernel-janitors,
Pierre-Louis Bossart, Ranjani Sridharan, Liam Girdwood,
Bard Liao, linux-kernel
On 2022-07-05 12:32 PM, Lukas Bulwahn wrote:
> Commit e39acc4cfd92 ("ASoC: Intel: avs: Add I2S-test machine board") adds
> the config "SND_SOC_INTEL_AVS_MACH_I2S_TEST", but in the Makefile refers
> to config "SND_SOC_INTEL_AVS_MACH_i2s_TEST" (notice the uppercase and
> lowercase difference).
>
> Adjust the Makefile to refer to the actual existing config.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Thanks for the fix.
Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>
> ---
> Amadeusz, Cezary, please ack.
>
> Mark, please pick this minor build config fix.
>
> sound/soc/intel/avs/boards/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/avs/boards/Makefile b/sound/soc/intel/avs/boards/Makefile
> index 25e8c4bb07db..bc75376d58c2 100644
> --- a/sound/soc/intel/avs/boards/Makefile
> +++ b/sound/soc/intel/avs/boards/Makefile
> @@ -16,7 +16,7 @@ snd-soc-avs-ssm4567-objs := ssm4567.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_DA7219) += snd-soc-avs-da7219.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_DMIC) += snd-soc-avs-dmic.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_HDAUDIO) += snd-soc-avs-hdaudio.o
> -obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_i2s_TEST) += snd-soc-avs-i2s-test.o
> +obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_I2S_TEST) += snd-soc-avs-i2s-test.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_MAX98357A) += snd-soc-avs-max98357a.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_MAX98373) += snd-soc-avs-max98373.o
> obj-$(CONFIG_SND_SOC_INTEL_AVS_MACH_NAU8825) += snd-soc-avs-nau8825.o
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ASoC: Intel: avs: correct config reference for I2S test board
2022-07-05 10:32 [PATCH] ASoC: Intel: avs: correct config reference for I2S test board Lukas Bulwahn
2022-07-05 10:48 ` Amadeusz Sławiński
2022-07-05 10:51 ` Cezary Rojewski
@ 2022-07-05 18:52 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2022-07-05 18:52 UTC (permalink / raw)
To: amadeuszx.slawinski, lukas.bulwahn, cezary.rojewski, alsa-devel
Cc: kai.vehmanen, peter.ujfalusi, kernel-janitors, tiwai,
pierre-louis.bossart, liam.r.girdwood, ranjani.sridharan,
yung-chuan.liao, linux-kernel
On Tue, 5 Jul 2022 12:32:38 +0200, Lukas Bulwahn wrote:
> Commit e39acc4cfd92 ("ASoC: Intel: avs: Add I2S-test machine board") adds
> the config "SND_SOC_INTEL_AVS_MACH_I2S_TEST", but in the Makefile refers
> to config "SND_SOC_INTEL_AVS_MACH_i2s_TEST" (notice the uppercase and
> lowercase difference).
>
> Adjust the Makefile to refer to the actual existing config.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: Intel: avs: correct config reference for I2S test board
commit: f4ba35b79bd0104f00e8e21e400b980bfaa2f17e
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-05 18:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-05 10:32 [PATCH] ASoC: Intel: avs: correct config reference for I2S test board Lukas Bulwahn
2022-07-05 10:48 ` Amadeusz Sławiński
2022-07-05 10:51 ` Cezary Rojewski
2022-07-05 18:52 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).