* [PATCH 1/2] sound: realtek: Add pincfg for ASUS G533Z
@ 2022-08-25 22:01 Luke D. Jones
2022-08-25 22:01 ` [PATCH 2/2] sound: realtek: Add pincfg for ASUS G513 Luke D. Jones
2022-08-26 6:08 ` [PATCH 1/2] sound: realtek: Add pincfg for ASUS G533Z Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Luke D. Jones @ 2022-08-25 22:01 UTC (permalink / raw)
To: tiwai; +Cc: Luke D. Jones, alsa-devel, kai.heng.feng, andy.chi, linux-kernel
Fixes up the pincfg for ASUS ROG Strix G15 (G533Z) laptop.
Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
sound/pci/hda/patch_realtek.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index fd630d62b5a0..e9cad49ee2a5 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5828,7 +5828,7 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec,
struct alc_spec *spec = codec->spec;
spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
alc255_set_default_jack_type(codec);
- }
+ }
else
alc_fixup_headset_mode(codec, fix, action);
}
@@ -7022,6 +7022,7 @@ enum {
ALC294_FIXUP_ASUS_GX502_HP,
ALC294_FIXUP_ASUS_GX502_PINS,
ALC294_FIXUP_ASUS_GX502_VERBS,
+ ALC285_FIXUP_ASUS_G533Z_PINS,
ALC294_FIXUP_ASUS_GU502_HP,
ALC294_FIXUP_ASUS_GU502_PINS,
ALC294_FIXUP_ASUS_GU502_VERBS,
@@ -8363,6 +8364,17 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = alc294_fixup_gu502_hp,
},
+ [ALC285_FIXUP_ASUS_G533Z_PINS] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x14, 0x90170120 },
+ { 0x19, 0x03A11050 }, /* front HP mic */
+ { 0x1B, 0x03A11C30 }, /* rear external mic */
+ { 0x21, 0x03211420 }, /* front HP out */
+ { }
+ },
+ .chained = false,
+ },
[ALC294_FIXUP_ASUS_COEF_1B] = {
.type = HDA_FIXUP_VERBS,
.v.verbs = (const struct hda_verb[]) {
@@ -9294,6 +9306,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK),
SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
SND_PCI_QUIRK(0x1043, 0x1881, "ASUS Zephyrus S/M", ALC294_FIXUP_ASUS_GX502_PINS),
+ SND_PCI_QUIRK(0x1043, 0x1c92, "ASUS ROG Strix G15", ALC285_FIXUP_ASUS_G533Z_PINS),
SND_PCI_QUIRK(0x1043, 0x18b1, "Asus MJ401TA", ALC256_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x18f1, "Asus FX505DT", ALC256_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x194e, "ASUS UX563FD", ALC294_FIXUP_ASUS_HPE),
--
2.37.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] sound: realtek: Add pincfg for ASUS G513
2022-08-25 22:01 [PATCH 1/2] sound: realtek: Add pincfg for ASUS G533Z Luke D. Jones
@ 2022-08-25 22:01 ` Luke D. Jones
2022-08-26 6:08 ` [PATCH 1/2] sound: realtek: Add pincfg for ASUS G533Z Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Luke D. Jones @ 2022-08-25 22:01 UTC (permalink / raw)
To: tiwai; +Cc: Luke D. Jones, alsa-devel, kai.heng.feng, andy.chi, linux-kernel
Fixes up the pincfg for ASUS ROG Strix G513
Signed-off-by: Luke D. Jones <luke@ljones.dev>
---
sound/pci/hda/patch_realtek.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index e9cad49ee2a5..abf3fb50692a 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7023,6 +7023,7 @@ enum {
ALC294_FIXUP_ASUS_GX502_PINS,
ALC294_FIXUP_ASUS_GX502_VERBS,
ALC285_FIXUP_ASUS_G533Z_PINS,
+ ALC294_FIXUP_ASUS_G513_PINS,
ALC294_FIXUP_ASUS_GU502_HP,
ALC294_FIXUP_ASUS_GU502_PINS,
ALC294_FIXUP_ASUS_GU502_VERBS,
@@ -8308,6 +8309,16 @@ static const struct hda_fixup alc269_fixups[] = {
.chained = true,
.chain_id = ALC294_FIXUP_ASUS_HEADSET_MIC
},
+ [ALC294_FIXUP_ASUS_G513_PINS] = {
+ .type = HDA_FIXUP_PINS,
+ .v.pins = (const struct hda_pintbl[]) {
+ { 0x19, 0x03a11050 }, /* front HP mic */
+ { 0x1a, 0x03a11c30 }, /* rear external mic */
+ { 0x21, 0x03211420 }, /* front HP out */
+ { }
+ },
+ .chained = false
+ },
[ALC294_FIXUP_ASUS_GX502_PINS] = {
.type = HDA_FIXUP_PINS,
.v.pins = (const struct hda_pintbl[]) {
@@ -9307,6 +9318,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK),
SND_PCI_QUIRK(0x1043, 0x1881, "ASUS Zephyrus S/M", ALC294_FIXUP_ASUS_GX502_PINS),
SND_PCI_QUIRK(0x1043, 0x1c92, "ASUS ROG Strix G15", ALC285_FIXUP_ASUS_G533Z_PINS),
+ SND_PCI_QUIRK(0x1043, 0x1e5e, "ASUS ROG Strix G513", ALC294_FIXUP_ASUS_G513_PINS),
SND_PCI_QUIRK(0x1043, 0x18b1, "Asus MJ401TA", ALC256_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x18f1, "Asus FX505DT", ALC256_FIXUP_ASUS_HEADSET_MIC),
SND_PCI_QUIRK(0x1043, 0x194e, "ASUS UX563FD", ALC294_FIXUP_ASUS_HPE),
--
2.37.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] sound: realtek: Add pincfg for ASUS G533Z
2022-08-25 22:01 [PATCH 1/2] sound: realtek: Add pincfg for ASUS G533Z Luke D. Jones
2022-08-25 22:01 ` [PATCH 2/2] sound: realtek: Add pincfg for ASUS G513 Luke D. Jones
@ 2022-08-26 6:08 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2022-08-26 6:08 UTC (permalink / raw)
To: Luke D. Jones; +Cc: linux-kernel, alsa-devel, kai.heng.feng, tiwai, andy.chi
On Fri, 26 Aug 2022 00:01:29 +0200,
Luke D. Jones wrote:
>
> Fixes up the pincfg for ASUS ROG Strix G15 (G533Z) laptop.
>
> Signed-off-by: Luke D. Jones <luke@ljones.dev>
Just minor nitpicking:
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5828,7 +5828,7 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec,
> struct alc_spec *spec = codec->spec;
> spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
> alc255_set_default_jack_type(codec);
> - }
> + }
> else
> alc_fixup_headset_mode(codec, fix, action);
> }
Please avoid touching unnecessary parts.
> @@ -8363,6 +8364,17 @@ static const struct hda_fixup alc269_fixups[] = {
> .type = HDA_FIXUP_FUNC,
> .v.func = alc294_fixup_gu502_hp,
> },
> + [ALC285_FIXUP_ASUS_G533Z_PINS] = {
> + .type = HDA_FIXUP_PINS,
> + .v.pins = (const struct hda_pintbl[]) {
> + { 0x14, 0x90170120 },
> + { 0x19, 0x03A11050 }, /* front HP mic */
> + { 0x1B, 0x03A11C30 }, /* rear external mic */
> + { 0x21, 0x03211420 }, /* front HP out */
We prefer the lower letters for hex numbers.
> + { }
> + },
> + .chained = false,
This is initialization superfluous, please drop.
Last but not least, the subject prefix should be rather "ALSA:"
instead of "sound:".
The same applied to the second patch.
Could you try to address those and resubmit as v2?
thanks,
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-26 6:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-25 22:01 [PATCH 1/2] sound: realtek: Add pincfg for ASUS G533Z Luke D. Jones
2022-08-25 22:01 ` [PATCH 2/2] sound: realtek: Add pincfg for ASUS G513 Luke D. Jones
2022-08-26 6:08 ` [PATCH 1/2] sound: realtek: Add pincfg for ASUS G533Z Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).