* [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties
@ 2022-11-02 18:19 Nícolas F. R. A. Prado
2022-11-02 18:19 ` [PATCH v2 1/8] ASoC: dt-bindings: realtek, rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
` (7 more replies)
0 siblings, 8 replies; 11+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-11-02 18:19 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: Oder Chiou, devicetree, alsa-devel, Nícolas F. R. A. Prado,
linux-arm-msm, Takashi Iwai, Konrad Dybcio, Liam Girdwood,
Rob Herring, Andy Gross, Derek Fang, Krzysztof Kozlowski,
Chen-Yu Tsai, kernel, linux-kernel, AngeloGioacchino Del Regno
This series sets straight the usage of power supply properties for the
rt5682 and rt5682s audio codecs.
These properties were already being used by sc7180-trogdor.dtsi (and
derived DTs like sc7180-trogdor-kingoftown.dtsi).
We start by documenting the power supplies that are already in use and
then add few others that were missing to the bindings.
Then we update the drivers to also support the new supplies.
Finally we update the trogdor DTs so they have the newly added but
required supplies and remove a superfluous one that was causing
warnings.
v1: https://lore.kernel.org/all/20221028205540.3197304-1-nfraprado@collabora.com
Changes in v2:
- Made new supply names uppercase to be consistent with the existing
ones
Nícolas F. R. A. Prado (8):
ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies
ASoC: dt-bindings: realtek,rt5682s: Add DBVDD and LDO1-IN supplies
ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies
ASoC: dt-bindings: rt5682: Add DBVDD and LDO1-IN supplies
ASoC: rt5682s: Support DBVDD and LDO1-IN supplies
ASoC: rt5682: Support DBVDD and LDO1-IN supplies
arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682
arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s
.../bindings/sound/realtek,rt5682s.yaml | 23 +++++++++++++++++++
.../devicetree/bindings/sound/rt5682.txt | 20 ++++++++++++++++
.../dts/qcom/sc7180-trogdor-kingoftown.dtsi | 1 +
...0-trogdor-wormdingler-rev1-boe-rt5682s.dts | 1 +
...0-trogdor-wormdingler-rev1-inx-rt5682s.dts | 1 +
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 ++
sound/soc/codecs/rt5682.c | 2 ++
sound/soc/codecs/rt5682.h | 2 +-
sound/soc/codecs/rt5682s.c | 22 ++++++++++++++++++
sound/soc/codecs/rt5682s.h | 2 ++
10 files changed, 75 insertions(+), 1 deletion(-)
--
2.38.1
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2 1/8] ASoC: dt-bindings: realtek, rt5682s: Add AVDD and MICVDD supplies
2022-11-02 18:19 [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
@ 2022-11-02 18:19 ` Nícolas F. R. A. Prado
2022-11-02 18:19 ` [PATCH v2 2/8] ASoC: dt-bindings: realtek, rt5682s: Add DBVDD and LDO1-IN supplies Nícolas F. R. A. Prado
` (6 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-11-02 18:19 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: devicetree, alsa-devel, Nícolas F. R. A. Prado,
Liam Girdwood, linux-kernel, Rob Herring, Derek Fang,
Krzysztof Kozlowski, Chen-Yu Tsai, kernel,
AngeloGioacchino Del Regno
The rt5682s codec has two supplies - AVDD and MICVDD - which are already
used by sc7180-trogdor-kingoftown.dtsi. Document them in the binding.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
(no changes since v1)
.../devicetree/bindings/sound/realtek,rt5682s.yaml | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
index 1c0b06d82369..b7338bfc0f5a 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
@@ -90,11 +90,20 @@ properties:
"#sound-dai-cells":
const: 1
+ AVDD-supply:
+ description: Regulator supplying analog power through the AVDD pin.
+
+ MICVDD-supply:
+ description: Regulator supplying power for the microphone bias through the
+ MICVDD pin.
+
additionalProperties: false
required:
- compatible
- reg
+ - AVDD-supply
+ - MICVDD-supply
examples:
- |
@@ -120,5 +129,8 @@ examples:
clocks = <&osc>;
clock-names = "mclk";
+
+ AVDD-supply = <&avdd_reg>;
+ MICVDD-supply = <&micvdd_reg>;
};
};
--
2.38.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 2/8] ASoC: dt-bindings: realtek, rt5682s: Add DBVDD and LDO1-IN supplies
2022-11-02 18:19 [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
2022-11-02 18:19 ` [PATCH v2 1/8] ASoC: dt-bindings: realtek, rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
@ 2022-11-02 18:19 ` Nícolas F. R. A. Prado
2022-11-04 21:52 ` Rob Herring
2022-11-02 18:19 ` [PATCH v2 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Nícolas F. R. A. Prado
` (5 subsequent siblings)
7 siblings, 1 reply; 11+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-11-02 18:19 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: devicetree, alsa-devel, Nícolas F. R. A. Prado,
Liam Girdwood, linux-kernel, Rob Herring, Derek Fang,
Krzysztof Kozlowski, Chen-Yu Tsai, kernel,
AngeloGioacchino Del Regno
The rt5682s codec has two additional power supply pins, DBVDD and
LDO1_IN, that aren't currently described in the binding. Add them.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Changes in v2:
- Made names uppercase
.../devicetree/bindings/sound/realtek,rt5682s.yaml | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
index b7338bfc0f5a..dc418652f241 100644
--- a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
+++ b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
@@ -97,6 +97,13 @@ properties:
description: Regulator supplying power for the microphone bias through the
MICVDD pin.
+ DBVDD-supply:
+ description: Regulator supplying I/O power through the DBVDD pin.
+
+ LDO1-IN-supply:
+ description: Regulator supplying power to the digital core and charge pump
+ through the LDO1_IN pin.
+
additionalProperties: false
required:
@@ -104,6 +111,8 @@ required:
- reg
- AVDD-supply
- MICVDD-supply
+ - DBVDD-supply
+ - LDO1-IN-supply
examples:
- |
@@ -132,5 +141,7 @@ examples:
AVDD-supply = <&avdd_reg>;
MICVDD-supply = <&micvdd_reg>;
+ DBVDD-supply = <&dbvdd_reg>;
+ LDO1-IN-supply = <&ldo1_in_reg>;
};
};
--
2.38.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies
2022-11-02 18:19 [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
2022-11-02 18:19 ` [PATCH v2 1/8] ASoC: dt-bindings: realtek, rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
2022-11-02 18:19 ` [PATCH v2 2/8] ASoC: dt-bindings: realtek, rt5682s: Add DBVDD and LDO1-IN supplies Nícolas F. R. A. Prado
@ 2022-11-02 18:19 ` Nícolas F. R. A. Prado
2022-11-02 18:19 ` [PATCH v2 4/8] ASoC: dt-bindings: rt5682: Add DBVDD and LDO1-IN supplies Nícolas F. R. A. Prado
` (4 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-11-02 18:19 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: devicetree, alsa-devel, Nícolas F. R. A. Prado,
Liam Girdwood, linux-kernel, Rob Herring, Krzysztof Kozlowski,
Chen-Yu Tsai, kernel, AngeloGioacchino Del Regno
The rt5682 codec has three supplies - AVDD, MICVDD and VBAT - which are
already used by sc7180-trogdor.dtsi. Document them in the binding.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
(no changes since v1)
Documentation/devicetree/bindings/sound/rt5682.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
index 6b87db68337c..89e6245b870e 100644
--- a/Documentation/devicetree/bindings/sound/rt5682.txt
+++ b/Documentation/devicetree/bindings/sound/rt5682.txt
@@ -8,6 +8,15 @@ Required properties:
- reg : The I2C address of the device.
+- AVDD-supply: phandle to the regulator supplying analog power through the
+ AVDD pin
+
+- MICVDD-supply: phandle to the regulator supplying power for the microphone
+ bias through the MICVDD pin. Either MICVDD or VBAT should be present.
+
+- VBAT-supply: phandle to the regulator supplying battery power through the
+ VBAT pin. Either MICVDD or VBAT should be present.
+
Optional properties:
- interrupts : The CODEC's interrupt output.
@@ -75,4 +84,7 @@ rt5682 {
clocks = <&osc>;
clock-names = "mclk";
+
+ AVDD-supply = <&avdd_reg>;
+ MICVDD-supply = <&micvdd_reg>;
};
--
2.38.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 4/8] ASoC: dt-bindings: rt5682: Add DBVDD and LDO1-IN supplies
2022-11-02 18:19 [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
` (2 preceding siblings ...)
2022-11-02 18:19 ` [PATCH v2 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Nícolas F. R. A. Prado
@ 2022-11-02 18:19 ` Nícolas F. R. A. Prado
2022-11-04 21:52 ` Rob Herring
2022-11-02 18:19 ` [PATCH v2 5/8] ASoC: rt5682s: Support " Nícolas F. R. A. Prado
` (3 subsequent siblings)
7 siblings, 1 reply; 11+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-11-02 18:19 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: devicetree, alsa-devel, Nícolas F. R. A. Prado,
Liam Girdwood, linux-kernel, Rob Herring, Krzysztof Kozlowski,
Chen-Yu Tsai, kernel, AngeloGioacchino Del Regno
The rt5682 codec has two additional power supply pins, DBVDD and
LDO1_IN, that aren't currently described in the binding. Add them.
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Changes in v2:
- Made names uppercase
Documentation/devicetree/bindings/sound/rt5682.txt | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
index 89e6245b870e..5e1d08de18a5 100644
--- a/Documentation/devicetree/bindings/sound/rt5682.txt
+++ b/Documentation/devicetree/bindings/sound/rt5682.txt
@@ -17,6 +17,12 @@ Required properties:
- VBAT-supply: phandle to the regulator supplying battery power through the
VBAT pin. Either MICVDD or VBAT should be present.
+- DBVDD-supply: phandle to the regulator supplying I/O power through the DBVDD
+ pin.
+
+- LDO1-IN-supply: phandle to the regulator supplying power to the digital core
+ and charge pump through the LDO1_IN pin.
+
Optional properties:
- interrupts : The CODEC's interrupt output.
@@ -87,4 +93,6 @@ rt5682 {
AVDD-supply = <&avdd_reg>;
MICVDD-supply = <&micvdd_reg>;
+ DBVDD-supply = <&dbvdd_reg>;
+ LDO1-IN-supply = <&ldo1_in_reg>;
};
--
2.38.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 5/8] ASoC: rt5682s: Support DBVDD and LDO1-IN supplies
2022-11-02 18:19 [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
` (3 preceding siblings ...)
2022-11-02 18:19 ` [PATCH v2 4/8] ASoC: dt-bindings: rt5682: Add DBVDD and LDO1-IN supplies Nícolas F. R. A. Prado
@ 2022-11-02 18:19 ` Nícolas F. R. A. Prado
2022-11-02 18:20 ` [PATCH v2 6/8] ASoC: rt5682: " Nícolas F. R. A. Prado
` (2 subsequent siblings)
7 siblings, 0 replies; 11+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-11-02 18:19 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: Oder Chiou, alsa-devel, Nícolas F. R. A. Prado,
linux-kernel, Takashi Iwai, Liam Girdwood, Chen-Yu Tsai, kernel,
AngeloGioacchino Del Regno
Add support for the DBVDD and LDO1-IN supplies.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Changes in v2:
- Made names uppercase
sound/soc/codecs/rt5682s.c | 22 ++++++++++++++++++++++
sound/soc/codecs/rt5682s.h | 2 ++
2 files changed, 24 insertions(+)
diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c
index 80c673aa14db..f5e5dbc3b0f0 100644
--- a/sound/soc/codecs/rt5682s.c
+++ b/sound/soc/codecs/rt5682s.c
@@ -44,6 +44,8 @@ static const struct rt5682s_platform_data i2s_default_platform_data = {
static const char *rt5682s_supply_names[RT5682S_NUM_SUPPLIES] = {
[RT5682S_SUPPLY_AVDD] = "AVDD",
[RT5682S_SUPPLY_MICVDD] = "MICVDD",
+ [RT5682S_SUPPLY_DBVDD] = "DBVDD",
+ [RT5682S_SUPPLY_LDO1_IN] = "LDO1-IN",
};
static const struct reg_sequence patch_list[] = {
@@ -3089,6 +3091,14 @@ static void rt5682s_i2c_disable_regulators(void *data)
if (ret)
dev_err(dev, "Failed to disable supply AVDD: %d\n", ret);
+ ret = regulator_disable(rt5682s->supplies[RT5682S_SUPPLY_DBVDD].consumer);
+ if (ret)
+ dev_err(dev, "Failed to disable supply DBVDD: %d\n", ret);
+
+ ret = regulator_disable(rt5682s->supplies[RT5682S_SUPPLY_LDO1_IN].consumer);
+ if (ret)
+ dev_err(dev, "Failed to disable supply LDO1-IN: %d\n", ret);
+
usleep_range(1000, 1500);
ret = regulator_disable(rt5682s->supplies[RT5682S_SUPPLY_MICVDD].consumer);
@@ -3150,6 +3160,18 @@ static int rt5682s_i2c_probe(struct i2c_client *i2c)
return ret;
}
+ ret = regulator_enable(rt5682s->supplies[RT5682S_SUPPLY_DBVDD].consumer);
+ if (ret) {
+ dev_err(&i2c->dev, "Failed to enable supply DBVDD: %d\n", ret);
+ return ret;
+ }
+
+ ret = regulator_enable(rt5682s->supplies[RT5682S_SUPPLY_LDO1_IN].consumer);
+ if (ret) {
+ dev_err(&i2c->dev, "Failed to enable supply LDO1-IN: %d\n", ret);
+ return ret;
+ }
+
if (gpio_is_valid(rt5682s->pdata.ldo1_en)) {
if (devm_gpio_request_one(&i2c->dev, rt5682s->pdata.ldo1_en,
GPIOF_OUT_INIT_HIGH, "rt5682s"))
diff --git a/sound/soc/codecs/rt5682s.h b/sound/soc/codecs/rt5682s.h
index 45464a041765..67f86a38a1cc 100644
--- a/sound/soc/codecs/rt5682s.h
+++ b/sound/soc/codecs/rt5682s.h
@@ -1438,6 +1438,8 @@ struct pll_calc_map {
enum {
RT5682S_SUPPLY_AVDD,
RT5682S_SUPPLY_MICVDD,
+ RT5682S_SUPPLY_DBVDD,
+ RT5682S_SUPPLY_LDO1_IN,
RT5682S_NUM_SUPPLIES,
};
--
2.38.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH v2 6/8] ASoC: rt5682: Support DBVDD and LDO1-IN supplies
2022-11-02 18:19 [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
` (4 preceding siblings ...)
2022-11-02 18:19 ` [PATCH v2 5/8] ASoC: rt5682s: Support " Nícolas F. R. A. Prado
@ 2022-11-02 18:20 ` Nícolas F. R. A. Prado
2022-11-10 17:55 ` (subset) [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Mark Brown
2022-12-06 18:19 ` Bjorn Andersson
7 siblings, 0 replies; 11+ messages in thread
From: Nícolas F. R. A. Prado @ 2022-11-02 18:20 UTC (permalink / raw)
To: Mark Brown, Bjorn Andersson
Cc: Oder Chiou, alsa-devel, Nícolas F. R. A. Prado,
linux-kernel, Takashi Iwai, Liam Girdwood, Chen-Yu Tsai, kernel,
AngeloGioacchino Del Regno
Add support for the DBVDD and LDO1-IN supplies.
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
Changes in v2:
- Made names uppercase
sound/soc/codecs/rt5682.c | 2 ++
sound/soc/codecs/rt5682.h | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5682.c b/sound/soc/codecs/rt5682.c
index 2df95e792900..7e3eb65afe16 100644
--- a/sound/soc/codecs/rt5682.c
+++ b/sound/soc/codecs/rt5682.c
@@ -35,6 +35,8 @@ const char *rt5682_supply_names[RT5682_NUM_SUPPLIES] = {
"AVDD",
"MICVDD",
"VBAT",
+ "DBVDD",
+ "LDO1-IN",
};
EXPORT_SYMBOL_GPL(rt5682_supply_names);
diff --git a/sound/soc/codecs/rt5682.h b/sound/soc/codecs/rt5682.h
index 52ff0d9c36c5..d568c6993c33 100644
--- a/sound/soc/codecs/rt5682.h
+++ b/sound/soc/codecs/rt5682.h
@@ -1424,7 +1424,7 @@ enum {
RT5682_CLK_SEL_I2S2_ASRC,
};
-#define RT5682_NUM_SUPPLIES 3
+#define RT5682_NUM_SUPPLIES 5
struct rt5682_priv {
struct snd_soc_component *component;
--
2.38.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2 2/8] ASoC: dt-bindings: realtek, rt5682s: Add DBVDD and LDO1-IN supplies
2022-11-02 18:19 ` [PATCH v2 2/8] ASoC: dt-bindings: realtek, rt5682s: Add DBVDD and LDO1-IN supplies Nícolas F. R. A. Prado
@ 2022-11-04 21:52 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-11-04 21:52 UTC (permalink / raw)
To: Nícolas F. R. A. Prado
Cc: devicetree, alsa-devel, Bjorn Andersson, Liam Girdwood,
Rob Herring, linux-kernel, Mark Brown, Derek Fang,
Krzysztof Kozlowski, Chen-Yu Tsai, kernel,
AngeloGioacchino Del Regno
On Wed, 02 Nov 2022 14:19:56 -0400, Nícolas F. R. A. Prado wrote:
> The rt5682s codec has two additional power supply pins, DBVDD and
> LDO1_IN, that aren't currently described in the binding. Add them.
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
> Changes in v2:
> - Made names uppercase
>
> .../devicetree/bindings/sound/realtek,rt5682s.yaml | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2 4/8] ASoC: dt-bindings: rt5682: Add DBVDD and LDO1-IN supplies
2022-11-02 18:19 ` [PATCH v2 4/8] ASoC: dt-bindings: rt5682: Add DBVDD and LDO1-IN supplies Nícolas F. R. A. Prado
@ 2022-11-04 21:52 ` Rob Herring
0 siblings, 0 replies; 11+ messages in thread
From: Rob Herring @ 2022-11-04 21:52 UTC (permalink / raw)
To: Nícolas F. R. A. Prado
Cc: devicetree, alsa-devel, Mark Brown, Liam Girdwood, linux-kernel,
Rob Herring, Krzysztof Kozlowski, Chen-Yu Tsai, kernel,
Bjorn Andersson, AngeloGioacchino Del Regno
On Wed, 02 Nov 2022 14:19:58 -0400, Nícolas F. R. A. Prado wrote:
> The rt5682 codec has two additional power supply pins, DBVDD and
> LDO1_IN, that aren't currently described in the binding. Add them.
>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>
> ---
>
> Changes in v2:
> - Made names uppercase
>
> Documentation/devicetree/bindings/sound/rt5682.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties
2022-11-02 18:19 [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
` (5 preceding siblings ...)
2022-11-02 18:20 ` [PATCH v2 6/8] ASoC: rt5682: " Nícolas F. R. A. Prado
@ 2022-11-10 17:55 ` Mark Brown
2022-12-06 18:19 ` Bjorn Andersson
7 siblings, 0 replies; 11+ messages in thread
From: Mark Brown @ 2022-11-10 17:55 UTC (permalink / raw)
To: Nícolas F. R. A. Prado, Bjorn Andersson
Cc: Oder Chiou, devicetree, alsa-devel, linux-arm-msm, Konrad Dybcio,
Liam Girdwood, Takashi Iwai, Rob Herring, Derek Fang, Andy Gross,
Krzysztof Kozlowski, Chen-Yu Tsai, kernel, linux-kernel,
AngeloGioacchino Del Regno
On Wed, 2 Nov 2022 14:19:54 -0400, Nícolas F. R. A. Prado wrote:
> This series sets straight the usage of power supply properties for the
> rt5682 and rt5682s audio codecs.
>
> These properties were already being used by sc7180-trogdor.dtsi (and
> derived DTs like sc7180-trogdor-kingoftown.dtsi).
>
> We start by documenting the power supplies that are already in use and
> then add few others that were missing to the bindings.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/8] ASoC: dt-bindings: realtek,rt5682s: Add AVDD and MICVDD supplies
commit: 163460262782b183a28d07255403fa72151fa20b
[2/8] ASoC: dt-bindings: realtek,rt5682s: Add DBVDD and LDO1-IN supplies
commit: ed20a9bf3f16e413a41cd09db74fc7f8dcb1dcef
[3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies
commit: 4d3c884ca7fb8ea25555c9a4b5ab1f9acad22587
[4/8] ASoC: dt-bindings: rt5682: Add DBVDD and LDO1-IN supplies
commit: 9354fa7f6ee4ef721351c29316b59eb8f724ca49
[5/8] ASoC: rt5682s: Support DBVDD and LDO1-IN supplies
commit: 5aab1a56b3dd031603a50ed7fd53e3c607a42a86
[6/8] ASoC: rt5682: Support DBVDD and LDO1-IN supplies
commit: 318ff0693095defc683d00bb3fd7c482d10b03d7
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: (subset) [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties
2022-11-02 18:19 [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
` (6 preceding siblings ...)
2022-11-10 17:55 ` (subset) [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Mark Brown
@ 2022-12-06 18:19 ` Bjorn Andersson
7 siblings, 0 replies; 11+ messages in thread
From: Bjorn Andersson @ 2022-12-06 18:19 UTC (permalink / raw)
To: broonie, nfraprado
Cc: oder_chiou, devicetree, alsa-devel, linux-arm-msm, konrad.dybcio,
lgirdwood, tiwai, robh+dt, derek.fang, Andy Gross,
krzysztof.kozlowski+dt, wenst, kernel, linux-kernel,
angelogioacchino.delregno
On Wed, 2 Nov 2022 14:19:54 -0400, Nícolas F. R. A. Prado wrote:
> This series sets straight the usage of power supply properties for the
> rt5682 and rt5682s audio codecs.
>
> These properties were already being used by sc7180-trogdor.dtsi (and
> derived DTs like sc7180-trogdor-kingoftown.dtsi).
>
> We start by documenting the power supplies that are already in use and
> then add few others that were missing to the bindings.
>
> [...]
Applied, thanks!
[7/8] arm64: dts: qcom: sc7180-trogdor: Add missing supplies for rt5682
commit: 172cb25fd25786a3290cffd38dea677edb0b7cca
[8/8] arm64: dts: qcom: sc7180-trogdor: Remove VBAT supply from rt5682s
commit: 147e8b2080f1a0496a1f51739cf591324f133619
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-12-06 18:21 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-02 18:19 [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Nícolas F. R. A. Prado
2022-11-02 18:19 ` [PATCH v2 1/8] ASoC: dt-bindings: realtek, rt5682s: Add AVDD and MICVDD supplies Nícolas F. R. A. Prado
2022-11-02 18:19 ` [PATCH v2 2/8] ASoC: dt-bindings: realtek, rt5682s: Add DBVDD and LDO1-IN supplies Nícolas F. R. A. Prado
2022-11-04 21:52 ` Rob Herring
2022-11-02 18:19 ` [PATCH v2 3/8] ASoC: dt-bindings: rt5682: Add AVDD, MICVDD and VBAT supplies Nícolas F. R. A. Prado
2022-11-02 18:19 ` [PATCH v2 4/8] ASoC: dt-bindings: rt5682: Add DBVDD and LDO1-IN supplies Nícolas F. R. A. Prado
2022-11-04 21:52 ` Rob Herring
2022-11-02 18:19 ` [PATCH v2 5/8] ASoC: rt5682s: Support " Nícolas F. R. A. Prado
2022-11-02 18:20 ` [PATCH v2 6/8] ASoC: rt5682: " Nícolas F. R. A. Prado
2022-11-10 17:55 ` (subset) [PATCH v2 0/8] Adjust usage of rt5682(s) power supply properties Mark Brown
2022-12-06 18:19 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).